fix(auth): Disallow refresh token access to API endpoints#10840
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughToken type validation is refactored by introducing two public constants (ACCESS_TOKEN_TYPE and REFRESH_TOKEN_TYPE) to replace hardcoded strings across JWT token handling. JWT-based current-user retrieval now enforces ACCESS_TOKEN_TYPE validation. The secrets baseline file is reorganized and line numbers updated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touchesImportant Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings, 1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (39.99%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10840 +/- ##
==========================================
- Coverage 32.82% 32.55% -0.28%
==========================================
Files 1367 1370 +3
Lines 64017 63523 -494
Branches 9553 9391 -162
==========================================
- Hits 21014 20677 -337
+ Misses 41943 41806 -137
+ Partials 1060 1040 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
CC @Ming Luo (in case this change affects Astra) |
72ac72c to
8435682
Compare
ea332f8 to
2c304bb
Compare
Problem
api/v1/run/sessionAPI endpoint using a refresh tokenapi/v1/run/sessionAPI endpoint using an access tokenWork Done
accessandrefreshtoken types1.7.0branchResearch
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.