Skip to content

Chore: update anthropic Models#10860

Merged
edwinjosechittilappilly merged 3 commits into
mainfrom
fix-anthropic-constants
Dec 3, 2025
Merged

Chore: update anthropic Models#10860
edwinjosechittilappilly merged 3 commits into
mainfrom
fix-anthropic-constants

Conversation

@edwinjosechittilappilly
Copy link
Copy Markdown
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly commented Dec 3, 2025

This pull request updates the list of Anthropic models in anthropic_constants.py to reflect the latest available models, clarify which are deprecated, and improve how deprecated and unsupported models are represented. The most important changes are:

New Model Additions:

  • Added support for new models: claude-opus-4-5-20251101, claude-haiku-4-5-20251001, claude-3-5-haiku-20241022, and claude-3-haiku-20240307 with tool calling enabled.

Deprecation and Organization Improvements:

  • Moved previously listed models (e.g., claude-3-7-sonnet-latest, claude-3-5-sonnet-latest, claude-3-5-haiku-latest, claude-3-opus-latest) to a new "Deprecated models" section and explicitly marked them as deprecated.
  • Marked older models without tool calling support (claude-2.1, claude-2.0) as deprecated and moved them to the deprecated section for clarity.

Cleanup and Clarity:

  • Removed redundant or outdated entries, and reorganized the order to separate active, deprecated, and unsupported models more clearly.

Summary by CodeRabbit

  • New Features

    • Added support for new Anthropic AI models (claude-opus-4-5-20251101, claude-haiku-4-5-20251001)
  • Updates

    • Multiple Anthropic models marked as deprecated (claude-3-7-sonnet-latest, claude-3-5-sonnet-latest, claude-3-5-haiku-latest, claude-3-opus-latest)
    • Enhanced tool-calling capabilities for select models
    • Reconfigured model availability across the platform

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 3, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

This pull request updates the Anthropic model constants by adding two new models (claude-opus-4-5-20251101 and claude-haiku-4-5-20251001), removing four model variants, marking multiple models as deprecated, and adjusting tool_calling capabilities across the catalog.

Changes

Cohort / File(s) Summary
Anthropic model configuration
src/lfx/src/lfx/base/models/anthropic_constants.py
Added new Anthropic models with updated capabilities; removed legacy model entries; deprecated four model variants; adjusted tool_calling flags for multiple models; reconfigured model catalog to reflect current Anthropic offerings

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify new model identifiers (claude-opus-4-5-20251101, claude-haiku-4-5-20251001) match current Anthropic API
  • Confirm tool_calling capability flags align with Anthropic's actual model specifications
  • Validate that deprecated models are correctly marked and correspond to Anthropic's official deprecation schedule

Possibly related PRs

Suggested labels

enhancement, lgtm

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error No test files were added or modified to validate changes to anthropic_constants.py model configurations. Add test file (e.g., test_anthropic_constants.py) to validate new models, deprecated flags, and tool-calling capabilities are correctly configured.
Test Quality And Coverage ⚠️ Warning PR updates Anthropic model constants but lacks test coverage validating new models, deprecated flags, and tool_calling configurations. Add pytest tests validating new model configurations, deprecated flags, tool_calling capabilities, and preventing regressions in model constants.
Test File Naming And Structure ❓ Inconclusive Modified anthropic_constants.py lacks accompanying unit tests following test_*.py naming convention despite test infrastructure present. Create dedicated test file test_anthropic_constants.py with tests verifying model configurations, deprecation flags, and tool-calling capabilities.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Chore: update anthropic Models' is directly related to the changeset, which updates the Anthropic models configuration file with new models, deprecated entries, and reorganized structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Excessive Mock Usage Warning ✅ Passed Pull request modifies only anthropic_constants.py configuration file; test files appropriately use constants as real data fixtures with mocks limited to external API dependencies.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Anthropic model configuration to reflect current model availability, organizing models into active and deprecated categories while adding support for newer model versions.

Key Changes:

  • Adds four new Anthropic models including Claude Opus 4.5 and Haiku variants
  • Reorganizes deprecated models into a dedicated section with explicit deprecated=True flags
  • Removes the "Tool calling unsupported models" section by incorporating those models into the deprecated section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

create_model_metadata(provider="Anthropic", name="claude-3-5-sonnet-latest", icon="Anthropic", tool_calling=True),
create_model_metadata(provider="Anthropic", name="claude-3-5-haiku-latest", icon="Anthropic", tool_calling=True),
create_model_metadata(provider="Anthropic", name="claude-3-opus-latest", icon="Anthropic", tool_calling=True),
create_model_metadata(provider="Anthropic", name="claude-3-5-haiku-20241022", icon="Anthropic", tool_calling=True),
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model 'claude-3-5-haiku-20241022' appears in both the active models section (line 11) and the deprecated models section (line 39). This duplication could lead to confusion and inconsistent behavior. Remove one of these entries based on the model's actual status.

Copilot uses AI. Check for mistakes.
create_model_metadata(provider="Anthropic", name="claude-3-5-haiku-latest", icon="Anthropic", tool_calling=True),
create_model_metadata(provider="Anthropic", name="claude-3-opus-latest", icon="Anthropic", tool_calling=True),
create_model_metadata(provider="Anthropic", name="claude-3-5-haiku-20241022", icon="Anthropic", tool_calling=True),
create_model_metadata(provider="Anthropic", name="claude-3-haiku-20240307", icon="Anthropic", tool_calling=True),
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model 'claude-3-haiku-20240307' appears in both the active models section (line 12) and the deprecated models section (line 38 in the original diff context). This duplication could cause inconsistent behavior. Clarify whether this model should be active or deprecated and remove the duplicate entry.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 15%
15.43% (4244/27499) 8.61% (1811/21013) 9.69% (587/6057)

Unit Test Results

Tests Skipped Failures Errors Time
1671 0 💤 0 ❌ 0 🔥 21.544s ⏱️

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.53%. Comparing base (17af7fb) to head (a3859c9).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (39.99%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10860      +/-   ##
==========================================
- Coverage   32.82%   32.53%   -0.29%     
==========================================
  Files        1367     1370       +3     
  Lines       64017    63518     -499     
  Branches     9553     9391     -162     
==========================================
- Hits        21014    20667     -347     
+ Misses      41943    41811     -132     
+ Partials     1060     1040      -20     
Flag Coverage Δ
backend 51.50% <ø> (-0.45%) ⬇️
frontend 14.28% <ø> (+0.15%) ⬆️
lfx 39.99% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lfx/src/lfx/base/models/anthropic_constants.py 100.00% <ø> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2025
@edwinjosechittilappilly edwinjosechittilappilly added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit fbfa529 Dec 3, 2025
52 of 53 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-anthropic-constants branch December 3, 2025 21:39
Wallgau pushed a commit that referenced this pull request Dec 16, 2025
* Update anthropic_constants.py

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants