fix: release workflow

[Adam-Aghili]

fix release workflow
#11087 was not meant to be merged yet. The fact it passed CI so quickly concerns me

I didn't get a chance to run a dry run before merge

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cz/release-1.7.0-lfx-publish

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ogabrielluiz]

If there are no backend or frontend changes the tests don't run

[Copilot]

Pull request overview

This PR fixes critical issues in the release workflow that were introduced in a prematurely merged PR (#11087). The changes implement automatic LFX package publishing as a dependency for langflow-base releases, while also enabling manual LFX releases.

Key Changes:

• Added automatic LFX dependency publishing via new ensure-lfx-published job that checks PyPI and publishes if needed
• Removed the "not implemented" validation check for release_lfx parameter and made it optional
• Reorganized job order by moving build-lfx job earlier and commenting out test-lfx-cross-platform job

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
.secrets.baseline	Updated line number reference from 128 to 122 to reflect removed validation lines in workflow
.github/workflows/release.yml	Modified release_lfx parameter to be optional; removed validation error; added ensure-lfx-published job to auto-publish LFX before building langflow-base; updated build-base dependencies; repositioned build-lfx job; commented out test-lfx-cross-platform job

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The description "Release LFX package (manually triggered)" could be clearer. Consider adding information about when this should be used versus when LFX is automatically published via the ensure-lfx-published job, e.g., "Manually release LFX package (not needed when releasing langflow-base as it auto-publishes LFX)".

Suggested change

	description: "Release LFX package (manually triggered)"
	description: "Manually release LFX package (not needed when releasing langflow-base, which auto-publishes LFX via ensure-lfx-published)"

[Copilot]

The bash range expression {1..5} may not work in all shell environments (particularly with sh instead of bash). Consider using seq 1 5 or explicitly specifying bash as the shell with shell: bash in the step configuration for portability.

Suggested change

	for i in {1..5}; do
	for i in $(seq 1 5); do

[Copilot]

The grep-based parsing of version from pyproject.toml is fragile and may break if the format changes. Consider using a more robust tool like tomli (Python's TOML parser), yq, or uv tree to extract version information reliably.

Suggested change

	LFX_REQUIREMENT=$(grep -E "^\s*\"lfx" pyproject.toml | head -1 | sed 's/.*lfx[~>=<]*//' | sed 's/[",].*//')
	echo "LFX requirement from langflow-base: $LFX_REQUIREMENT"
	# Get the actual lfx version from source
	cd ../../lfx
	LFX_SOURCE_VERSION=$(grep -E "^version\s*=" pyproject.toml | head -1 | sed 's/.*"\(.*\)".*/\1/')
	LFX_REQUIREMENT=$(python - << 'PY'
	import re
	import tomllib
	from pathlib import Path
	data = tomllib.loads(Path("pyproject.toml").read_text(encoding="utf-8"))
	deps = data.get("project", {}).get("dependencies", [])
	version = ""
	for dep in deps:
	if isinstance(dep, str) and dep.strip().startswith("lfx"):
	match = re.search(r'\d+(\.\d+)*', dep)
	if match:
	version = match.group(0)
	break
	print(version)
	PY
	)
	echo "LFX requirement from langflow-base: $LFX_REQUIREMENT"
	# Get the actual lfx version from source
	cd ../../lfx
	LFX_SOURCE_VERSION=$(python - << 'PY'
	import tomllib
	from pathlib import Path
	data = tomllib.loads(Path("pyproject.toml").read_text(encoding="utf-8"))
	print(data.get("project", {}).get("version", ""))
	PY
	)

[Copilot]

The grep-based parsing of version from pyproject.toml is fragile and may break if the format changes. Consider using a more robust tool like tomli (Python's TOML parser), yq, or uv tree to extract version information reliably.

Suggested change

	LFX_REQUIREMENT=$(grep -E "^\s*\"lfx" pyproject.toml | head -1 | sed 's/.*lfx[~>=<]*//' | sed 's/[",].*//')
	echo "LFX requirement from langflow-base: $LFX_REQUIREMENT"
	# Get the actual lfx version from source
	cd ../../lfx
	LFX_SOURCE_VERSION=$(grep -E "^version\s*=" pyproject.toml | head -1 | sed 's/.*"\(.*\)".*/\1/')
	LFX_REQUIREMENT=$(python - << 'EOF'
	import pathlib
	import tomllib
	data = tomllib.loads(pathlib.Path("pyproject.toml").read_text(encoding="utf-8"))
	deps = data.get("project", {}).get("dependencies", [])
	requirement = ""
	for dep in deps:
	if isinstance(dep, str) and dep.startswith("lfx"):
	# Use the full requirement string for robustness, e.g. "lfx>=1.2.3"
	requirement = dep
	break
	print(requirement)
	EOF
	)
	echo "LFX requirement from langflow-base: $LFX_REQUIREMENT"
	# Get the actual lfx version from source
	cd ../../lfx
	LFX_SOURCE_VERSION=$(python - << 'EOF'
	import pathlib
	import tomllib
	data = tomllib.loads(pathlib.Path("pyproject.toml").read_text(encoding="utf-8"))
	print(data.get("project", {}).get("version", ""))
	EOF
	)

[Copilot]

Using uv tree | grep 'lfx' to extract version is unreliable as it may match multiple lines or return inconsistent results. Consider reading the version directly from the pyproject.toml file using a more robust method, similar to what's done in the ensure-lfx-published job at line 159.

Suggested change

	version=$(uv tree | grep 'lfx' | head -n 1 | awk '{print $2}' | sed 's/^v//')
	version=$(python - << 'PY'
	import pathlib
	import tomllib
	pyproject_path = pathlib.Path("pyproject.toml")
	data = tomllib.loads(pyproject_path.read_bytes())
	version = data.get("project", {}).get("version", "")
	if not version:
	raise SystemExit("Could not determine version from pyproject.toml")
	print(version)
	PY
	)

[Copilot]

The ensure-lfx-published job can potentially conflict with the manual build-lfx/publish-lfx jobs if both release_package_base and release_lfx are set to true. While there are checks for already-published versions, there's a risk of race conditions or duplicate publish attempts. Consider adding mutual exclusion logic or documenting that these options should not be used together.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.21%. Comparing base (cd90e87) to head (9aeba04).
⚠️ Report is 4 commits behind head on release-1.7.0.

❌ Your project check has failed because the head coverage (39.96%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-1.7.0   #11089      +/-   ##
=================================================
- Coverage          33.22%   33.21%   -0.02%     
=================================================
  Files               1369     1369              
  Lines              64055    64055              
  Branches            9417     9417              
=================================================
- Hits               21282    21274       -8     
- Misses             41725    41733       +8     
  Partials            1048     1048              

Flag	Coverage Δ
backend	53.22% <ø> (-0.05%)	⬇️
frontend	14.41% <ø> (ø)
lfx	39.96% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 17 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ogabrielluiz]

I'm not comfortable with the release being automatic like this but I guess it's fine

[Adam-Aghili]

@ogabrielluiz I just want to make sure 1.7.0 isn't blocked. I don't know if we will run into issues after this.
We can remove lfx release in the future and have it go back to be manual again and add proper process so we don't run into an issue like this again.