fix: Agent component not detecting provider fields for WatsonX by dkaushik94 · Pull Request #12022 · langflow-ai/langflow

dkaushik94 · 2026-03-03T22:31:21Z

Refactored model provider underlying methods to work with WatsonX to detect model provider settings.
Wired in for the component to auto-detect globally configured WatsonX fields.

LE-449

…detect model provider settings.

coderabbitai · 2026-03-03T22:31:30Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch le-449

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-03T22:39:19Z

Frontend Unit Test Coverage Report

Coverage Summary

Lines	Statements	Branches	Functions
	22.88% (7986/34896)	15.46% (4227/27340)	15.62% (1148/7349)

Unit Test Results

Tests	Skipped	Failures	Errors	Time
2611	0 💤	0 ❌	0 🔥	45.598s ⏱️

codecov · 2026-03-03T23:41:08Z

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.12%. Comparing base (a25aa8c) to head (2a0fd58).
⚠️ Report is 17 commits behind head on release-1.8.0.

Files with missing lines	Patch %	Lines
src/lfx/src/lfx/base/models/unified_models.py	80.00%	3 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (41.96%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-1.8.0   #12022      +/-   ##
=================================================
- Coverage          37.05%   35.12%   -1.94%     
=================================================
  Files               1588     1588              
  Lines              77969    77976       +7     
  Branches           11803    11805       +2     
=================================================
- Hits               28893    27389    -1504     
- Misses             47454    48951    +1497     
- Partials            1622     1636      +14

Flag	Coverage Δ
backend	`49.86% <ø> (-7.48%)`	⬇️
frontend	`20.50% <ø> (ø)`
lfx	`41.96% <80.00%> (+0.47%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/lfx/src/lfx/base/models/unified_models.py	`38.44% <80.00%> (+14.69%)`	⬆️

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ogabrielluiz

PR Review Summary

Critical (2)

Swapped variable keys in validate_model_provider_key break validation for both OpenAI and WatsonX (see inline comments)

Important (2)

Agent component only calls apply_provider_variable_config_to_build_config for WatsonX, while LanguageModelComponent calls it for all providers
Overly broad except (ValueError, Exception) swallows all errors in get_all_variables_for_provider

Minor (1)

Import inside loop body in apply_provider_variable_config_to_build_config

The core approach (threading user_id, env-first then DB-override, moving field visibility outside field_name == "model") looks good. The variable key swap is the blocking issue.

ogabrielluiz · 2026-03-04T13:19:55Z

            from langchain_openai import ChatOpenAI  # type: ignore  # noqa: PGH003

-            api_key = variables.get("OPENAI_API_KEY")
+            api_key = variables.get("OPENAI_APIKEY")


Bug: Variable key is wrong. Should be OPENAI_API_KEY (with underscore), not OPENAI_APIKEY.

MODEL_PROVIDER_METADATA in model_metadata.py:78 defines the key as "OPENAI_API_KEY". The variables dict passed to this function is built from that metadata, so it will have key "OPENAI_API_KEY", but this line looks up "OPENAI_APIKEY", which will never match. This means OpenAI API key validation is silently skipped and invalid keys are accepted.

Suggested change

api_key = variables.get("OPENAI_APIKEY")

api_key = variables.get("OPENAI_API_KEY")

ogabrielluiz · 2026-03-04T13:19:55Z

            from langchain_ibm import ChatWatsonx

-            api_key = variables.get("WATSONX_APIKEY")
+            api_key = variables.get("WATSONX_API_KEY")


Bug: Variable key is wrong. Should be WATSONX_APIKEY, not WATSONX_API_KEY.

MODEL_PROVIDER_METADATA in model_metadata.py:182 defines the key as "WATSONX_APIKEY". Same issue as the OpenAI one above. The keys appear to have been accidentally swapped between the two providers. WatsonX validation is silently skipped.

Suggested change

api_key = variables.get("WATSONX_API_KEY")

api_key = variables.get("WATSONX_APIKEY")

ogabrielluiz · 2026-03-04T13:19:55Z

+
+            # Show/hide watsonx fields
+            is_watsonx = provider == "IBM WatsonX"
+            if is_watsonx:


Inconsistency: apply_provider_variable_config_to_build_config is only called for WatsonX here, but LanguageModelComponent calls it for ALL providers.

In language_model.py:138-144, this is called unconditionally when provider is truthy. But here it is guarded by if is_watsonx:, meaning env/DB prefilling probably will not work for OpenAI, Anthropic, Google, or Ollama in the Agent component. Is this intentional?

ogabrielluiz · 2026-03-04T13:19:55Z

+                    # If found in DB, it overrides environment variable
                    if value and str(value).strip():
                        values[var_key] = str(value)
                except (ValueError, Exception):  # noqa: BLE001


Overly broad exception catch. (ValueError, Exception) catches everything.

Exception is a superclass of ValueError, so the tuple is redundant. This catches all exceptions. Database connection failures, timeouts, and programming bugs all get logged at DEBUG level with the misleading message "Variable not found in database." Consider narrowing to the specific exception that get_variable raises for "not found", and logging infrastructure errors at WARNING.

ogabrielluiz · 2026-03-04T13:19:55Z

+
+            # Check if current value is just the hardcoded component default
+            # We want to allow the Global Variable to strictly override these specific defaults
+            from lfx.base.models.watsonx_constants import IBM_WATSONX_URLS


Minor: Import inside loop body.

from lfx.base.models.watsonx_constants import IBM_WATSONX_URLS runs on every iteration. Move to the top of the function for clarity, and to avoid a potential ImportError crashing all providers if the watsonx module has issues.

dkaushik94 · 2026-03-04T22:26:57Z

Closing this PR since this was tackled in a different PR from @edwinjosechittilappilly
PR: #12050

Refactored model provider underlying methods to work with WatsonX to …

09eaadf

…detect model provider settings.

autofix-ci Bot added 2 commits March 3, 2026 22:34

[autofix.ci] apply automated fixes

fee800e

[autofix.ci] apply automated fixes (attempt 2/3)

2a0fd58

ogabrielluiz changed the title ~~Bugfix: le-449: Agent component not detecting provider fields for WatsonX~~ fix: Agent component not detecting provider fields for WatsonX Mar 4, 2026

github-actions Bot added the bug Something isn't working label Mar 4, 2026

ogabrielluiz requested changes Mar 4, 2026

View reviewed changes

dkaushik94 closed this Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Agent component not detecting provider fields for WatsonX#12022

fix: Agent component not detecting provider fields for WatsonX#12022
dkaushik94 wants to merge 3 commits into
release-1.8.0from
le-449

dkaushik94 commented Mar 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

codecov Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

ogabrielluiz left a comment

Uh oh!

ogabrielluiz Mar 4, 2026

Uh oh!

ogabrielluiz Mar 4, 2026

Uh oh!

ogabrielluiz Mar 4, 2026

Uh oh!

ogabrielluiz Mar 4, 2026

Uh oh!

ogabrielluiz Mar 4, 2026

Uh oh!

dkaushik94 commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	api_key = variables.get("OPENAI_APIKEY")
	api_key = variables.get("OPENAI_API_KEY")

	api_key = variables.get("WATSONX_API_KEY")
	api_key = variables.get("WATSONX_APIKEY")

Conversation

dkaushik94 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Mar 3, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Unit Test Results

Uh oh!

codecov Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ogabrielluiz left a comment

Choose a reason for hiding this comment

PR Review Summary

Critical (2)

Important (2)

Minor (1)

Uh oh!

ogabrielluiz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ogabrielluiz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ogabrielluiz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ogabrielluiz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ogabrielluiz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

dkaushik94 commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkaushik94 commented Mar 3, 2026 •

edited

Loading

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading

codecov Bot commented Mar 3, 2026 •

edited

Loading