fix: make LANGFUSE_BASE_URL the preferred URL variable#12154
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR updates the Langfuse integration to rename the host configuration environment variable from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12154 +/- ##
=======================================
Coverage 38.39% 38.40%
=======================================
Files 1630 1630
Lines 80290 80290
Branches 12120 12120
=======================================
+ Hits 30830 30834 +4
+ Misses 47724 47719 -5
- Partials 1736 1737 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/Develop/integrations-langfuse.mdx`:
- Around line 44-54: Add missing title attributes to the code fences shown in
the diff: update the first ```bash fence containing the env vars to ```bash
title=".env", change the ```bash fence with the uv run command to ```bash
title="terminal", change the ```yml fence for the docker-compose snippet to
```yml title="docker-compose.yml", and change the ```sh fence with the docker
compose exec command to ```sh title="terminal" so all code blocks follow the
docs standard; locate these by the existing fences (```bash, ```yml, ```sh) and
the shared snippet contents to apply the titles.
- Around line 133-136: The troubleshooting note is misleading because the sample
command reads LANGFUSE_BASE_URL inside the langflow container; update the text
to instruct users to set LANGFUSE_BASE_URL in the docker compose service's
environment section (not their host shell) and then recreate/restart the
langflow service so the container picks up the change (e.g., recreate the
service via docker compose up -d or equivalent), while keeping the existing
docker compose exec langflow python... check as the validation step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 83a416de-89cb-4e1b-9b89-daf15846f0c6
📒 Files selected for processing (2)
docs/docs/Develop/integrations-langfuse.mdxsrc/backend/base/langflow/services/tracing/langfuse.py
aimurphy
left a comment
There was a problem hiding this comment.
approving docs changes with one comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Build successful! ✅ |
Langflow previously used
LANGFUSE_HOSTas the variable for the Langfuse base URL.If you copy values from Langfuse, it now uses
LANGFUSE_BASE_URL.This pull request makes
LANGFUSE_BASE_URLthe preferred environment variable, and includesLANGFUSE_HOSTfor backward compatibility.LANGFUSE_BASE_URLwill be used if both values are set.Nonehost is returned if neither (which is the current behavior).Docs are updated to use the
LANGFUSE_BASE_URLvalue, and includes a note for users that may still be using LANGFUSE_HOST.Summary by CodeRabbit
Documentation
.envfile workflow in setup examples.Chores