fix: add missing edge from AstraDB Search Results to Parser in Vector Store RAG template#12261
fix: add missing edge from AstraDB Search Results to Parser in Vector Store RAG template#12261viktoravelino wants to merge 2 commits into
Conversation
… Store RAG template The Vector Store RAG template was missing the edge connecting the Search Results output of the Astra DB (retriever) component to the JSON or Table input of the Parser component, causing a broken/floating edge to appear on the canvas whenever the template was opened.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (44.58%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.9.0 #12261 +/- ##
=================================================
- Coverage 38.23% 38.21% -0.02%
=================================================
Files 1647 1647
Lines 82369 82369
Branches 12223 12223
=================================================
- Hits 31494 31481 -13
- Misses 49092 49105 +13
Partials 1783 1783
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@viktoravelino thank you so much for doing this - i didnt see this and merged in a big unified models refactor which included restoring to that link as a consequence. Do you mind checking to see if it works okay for you on |
@erichare Yeah, looks like 1.9 is fine. I'll close it and mention on the Jira ticket |
|
This was fixed before.... |
|
Thanks @viktoravelino - fixed in #12025 |
Summary
Vector Store RAG.jsontemplate was missing the edge connecting the Search Results output of the Astra DB (retriever) component (AstraDB-hIUdP) to the JSON or Table input of the Parser component (parser-w1MvR)search_resultsoutput had no target connectionoutput_types: ["JSON"]→inputTypes: ["DataFrame", "Table", "Data", "JSON"])Test plan
Chat Input → Astra DB (search_results) → Parser → Prompt → Language Model → Chat Output