Skip to content

fix: Close popup when navigating to MCP settings#12358

Merged
erichare merged 2 commits into
release-1.9.0from
fix-mcp-settings-link
Apr 2, 2026
Merged

fix: Close popup when navigating to MCP settings#12358
erichare merged 2 commits into
release-1.9.0from
fix-mcp-settings-link

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

This pull request introduces a small usability improvement to the MCP server modal. Now, when a user clicks the "settings" link, the modal will automatically close, providing a smoother user experience.

  • When the "settings" link (CustomLink) is clicked in the AddMcpServerModal, the modal is closed by calling setOpen(false).

@erichare erichare requested a review from HzaRashid March 27, 2026 03:06
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4ae0bdf9-9246-47d7-8278-4d3338dd7e47

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-mcp-settings-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label Mar 27, 2026
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.23%. Comparing base (efbc4a1) to head (d030e81).
⚠️ Report is 42 commits behind head on release-1.9.0.

Files with missing lines Patch % Lines
...rc/frontend/src/modals/addMcpServerModal/index.tsx 0.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (44.86%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.9.0   #12358      +/-   ##
=================================================
- Coverage          48.41%   48.23%   -0.19%     
=================================================
  Files               1860     1861       +1     
  Lines             163624   162958     -666     
  Branches           24928    22498    -2430     
=================================================
- Hits               79226    78607     -619     
+ Misses             83516    83468      -48     
- Partials             882      883       +1     
Flag Coverage Δ
backend 53.82% <ø> (-0.03%) ⬇️
frontend 47.69% <0.00%> (-0.26%) ⬇️
lfx 44.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/frontend/src/modals/addMcpServerModal/index.tsx 42.98% <0.00%> (-0.70%) ⬇️

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 26%
26.68% (27018/101233) 63.32% (3345/5282) 28.82% (639/2217)

Unit Test Results

Tests Skipped Failures Errors Time
2784 0 💤 0 ❌ 0 🔥 5m 31s ⏱️

Copy link
Copy Markdown
Collaborator

@Adam-Aghili Adam-Aghili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested by creating a flow and using sidebar Add MCP Server button
Screenshot 2026-04-02 at 12 42 22 PM

Im pretty confused by the ticket for this PR.
When you are in the settings page you should have the settings link active.
Image

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Apr 2, 2026
@erichare erichare added this pull request to the merge queue Apr 2, 2026
@erichare erichare removed this pull request from the merge queue due to a manual request Apr 2, 2026
@erichare erichare added this pull request to the merge queue Apr 2, 2026
Merged via the queue into release-1.9.0 with commit 103ef7d Apr 2, 2026
95 of 97 checks passed
@erichare erichare deleted the fix-mcp-settings-link branch April 2, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants