chore: remove mypy from CI#12448
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis pull request removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (45.87%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.9.0 #12448 +/- ##
================================================
Coverage 48.86% 48.86%
================================================
Files 1897 1896 -1
Lines 167656 168352 +696
Branches 23193 24429 +1236
================================================
+ Hits 81928 82271 +343
- Misses 84817 85158 +341
- Partials 911 923 +12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Makefile (1)
100-100: Optional: keep transitional cleanup for legacy mypy cache.Line 100 removes
tycache correctly; consider also cleaning.mypy_cachefor a couple of releases to avoid stale local artifacts on upgraded dev machines.Suggested diff
- $(call CLEAR_DIRS,.ty_cache ) + $(call CLEAR_DIRS,.ty_cache .mypy_cache)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` at line 100, The Makefile currently calls $(call CLEAR_DIRS,.ty_cache) to remove legacy ty cache; extend this transitional cleanup to also remove .mypy_cache by updating the CLEAR_DIRS invocation to include both caches (e.g., pass ".ty_cache .mypy_cache") so that both .ty_cache and .mypy_cache are cleaned for a couple of releases; locate the CLEAR_DIRS call in the Makefile (symbol: CLEAR_DIRS, argument ".ty_cache") and add ".mypy_cache" to the arguments.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Makefile`:
- Line 100: The Makefile currently calls $(call CLEAR_DIRS,.ty_cache) to remove
legacy ty cache; extend this transitional cleanup to also remove .mypy_cache by
updating the CLEAR_DIRS invocation to include both caches (e.g., pass ".ty_cache
.mypy_cache") so that both .ty_cache and .mypy_cache are cleaned for a couple of
releases; locate the CLEAR_DIRS call in the Makefile (symbol: CLEAR_DIRS,
argument ".ty_cache") and add ".mypy_cache" to the arguments.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ae50c24a-8328-43af-9fe0-fe0a70993405
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
.github/workflows/ci.ymlMakefilepyproject.tomlsrc/backend/base/pyproject.toml
💤 Files with no reviewable changes (1)
- .github/workflows/ci.yml
mypy hasn't caught issues in a long time due to its lenient config (follow_imports=skip, ignore_missing_imports=true). We evaluated ty as a replacement but it lacks Pydantic and SQLModel support, producing too many false positives. Removing the type checker until a viable alternative matures.
56c1e0b to
7baa125
Compare
chore: remove mypy from CI and dev dependencies mypy hasn't caught issues in a long time due to its lenient config (follow_imports=skip, ignore_missing_imports=true). We evaluated ty as a replacement but it lacks Pydantic and SQLModel support, producing too many false positives. Removing the type checker until a viable alternative matures.
Summary
follow_imports = "skip",ignore_missing_imports = true)types-*stub packages, and[tool.mypy]config sectionsmake lintis a no-op for now until we have a viable type checker