Skip to content

feat(ui): Add "Connect other models" option for model-type handles#12466

Merged
Cristhianzl merged 20 commits into
release-1.9.0from
cz/fix-llm-input-handle
Apr 2, 2026
Merged

feat(ui): Add "Connect other models" option for model-type handles#12466
Cristhianzl merged 20 commits into
release-1.9.0from
cz/fix-llm-input-handle

Conversation

@Cristhianzl
Copy link
Copy Markdown
Member

OBJECTIVE: Allow users to discover and connect compatible model providers through a new connection mode on model-type input handles.

CHANGES:

  • Add "Connect other models" button to model input component that triggers connection filter mode
  • Implement muted handle state for model-type handles (invisible when disconnected, visible during connection mode)
  • Refactor useModelConnectionLogic hook to support connection filter activation
  • Add backend support for model edge connections in param_handler
  • Add unit tests for muted state logic, connection logic hook, and param handler model edges
image image image image

@github-actions github-actions Bot added the enhancement New feature or request label Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c5f6b3dd-c7df-49ac-949a-062fe489d1dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cz/fix-llm-input-handle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@erichare erichare self-requested a review April 2, 2026 16:49
Copy link
Copy Markdown
Collaborator

@erichare erichare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cristhianzl are there some mcp server related changes not required here? Can you just confirm that aspect?

@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 45.10638% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.34%. Comparing base (45325f6) to head (3c58a16).
⚠️ Report is 3 commits behind head on release-1.9.0.

Files with missing lines Patch % Lines
...delInputComponent/hooks/useModelConnectionLogic.ts 3.61% 80 Missing ⚠️
...Component/components/modelInputComponent/index.tsx 70.70% 29 Missing ⚠️
...ricNode/components/handleRenderComponent/index.tsx 61.90% 16 Missing ⚠️
src/frontend/src/types/flow/index.ts 0.00% 2 Missing ⚠️
...src/lfx/base/models/unified_models/build_config.py 0.00% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (47.87%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.9.0   #12466      +/-   ##
=================================================
- Coverage          49.37%   49.34%   -0.04%     
=================================================
  Files               1924     1924              
  Lines             170395   170520     +125     
  Branches           23556    24871    +1315     
=================================================
+ Hits               84135    84144       +9     
- Misses             85256    85372     +116     
  Partials            1004     1004              
Flag Coverage Δ
backend 55.52% <ø> (+0.02%) ⬆️
frontend 48.26% <43.80%> (-0.06%) ⬇️
lfx 47.87% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lfx/src/lfx/graph/vertex/param_handler.py 83.09% <100.00%> (+0.50%) ⬆️
src/frontend/src/types/flow/index.ts 0.00% <0.00%> (ø)
...src/lfx/base/models/unified_models/build_config.py 27.00% <0.00%> (-0.28%) ⬇️
...ricNode/components/handleRenderComponent/index.tsx 46.37% <61.90%> (+0.06%) ⬆️
...Component/components/modelInputComponent/index.tsx 91.27% <70.70%> (-5.38%) ⬇️
...delInputComponent/hooks/useModelConnectionLogic.ts 22.22% <3.61%> (+22.22%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Cristhianzl Cristhianzl force-pushed the cz/fix-llm-input-handle branch from 6b4e2b4 to 5a55972 Compare April 2, 2026 17:02
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@erichare erichare self-requested a review April 2, 2026 17:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 28%
28.05% (29259/104305) 64.63% (3721/5757) 30.05% (690/2296)

Unit Test Results

Tests Skipped Failures Errors Time
3049 0 💤 0 ❌ 0 🔥 4m 31s ⏱️

@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added the enhancement New feature or request label Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@Cristhianzl Cristhianzl enabled auto-merge April 2, 2026 18:51
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2026
@Cristhianzl Cristhianzl added this pull request to the merge queue Apr 2, 2026
Merged via the queue into release-1.9.0 with commit e6846ea Apr 2, 2026
99 of 100 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-llm-input-handle branch April 2, 2026 20:25
Adam-Aghili pushed a commit that referenced this pull request Apr 15, 2026
…12466)

* Display proper error messages and strip null params from tool calls

* add connect other models option

* fix model provider selection state

* fix tests and ruff

* revert mcp changes

* [autofix.ci] apply automated fixes

* fix handle not appearing properly

* fix jest test

* [autofix.ci] apply automated fixes

* address qa fixes

* add tests to validate be and fe

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* ruff style and checker

* fix tests failuer

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants