Skip to content

docs: concatenate and merge options for dataframe operations component#12819

Merged
mendonk merged 3 commits into
mainfrom
docs-concatenate-and-merge-table-operations
Apr 22, 2026
Merged

docs: concatenate and merge options for dataframe operations component#12819
mendonk merged 3 commits into
mainfrom
docs-concatenate-and-merge-table-operations

Conversation

@mendonk
Copy link
Copy Markdown
Collaborator

@mendonk mendonk commented Apr 21, 2026

Add the Concatenate and Merge options to the Table Operations component.

#11601

Summary by CodeRabbit

  • Documentation
    • Added documentation for Concatenate operation to stack multiple tables vertically into a single output table
    • Added documentation for Merge operation to combine two tables by matching on a shared column with configurable merge type options

@mendonk mendonk requested review from Cristhianzl and aimurphy April 21, 2026 19:16
@mendonk mendonk self-assigned this Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6155d64-494a-4cbb-89c0-34c03c872fc0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Documentation additions describing two new Table Operations: Concatenate for vertically stacking multiple Table inputs, and Merge for combining two Table objects by matching on a shared column. Changes applied to both current and versioned documentation files.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/docs/Components/dataframe-operations.mdx, docs/versioned_docs/version-1.9.0/Components/dataframe-operations.mdx
Added two new Table Operations in tabbed parameters: Concatenate (stacking multiple Table inputs vertically) and Merge (combining two Table objects with column matching, including new parameters for left/right tables, merge column, and merge type).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 8 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Excessive Mock Usage Warning ⚠️ Warning Test file restore-dismissed-node.test.tsx contains 29 mocks for only 2 test cases, representing poor test design patterns inconsistent with other repository test files. Refactor the test file to reduce mock usage, use real component implementations where feasible, and follow established mocking guidelines documented in .agents/skills/frontend-testing/references/mocking.md.
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding documentation for concatenate and merge options to the dataframe operations component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Coverage For New Implementations ✅ Passed This PR is a documentation-only change that adds descriptions of existing Concatenate and Merge features to the Table Operations component documentation. The two modified files are .mdx documentation files with no code changes, no new components, and no new functionality being introduced. The features being documented already exist in the codebase with corresponding tests already in place.
Test Quality And Coverage ✅ Passed Documentation-only PR for already-implemented Concatenate and Merge features with comprehensive existing test coverage of 13+ tests.
Test File Naming And Structure ✅ Passed This PR is a documentation-only change modifying .mdx files for Concatenate and Merge operations; no test files are included or affected.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs-concatenate-and-merge-table-operations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 21, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/docs/Components/dataframe-operations.mdx`:
- Around line 157-160: Update the documentation text to clarify that
merge_on_column is optional (when empty the implementation falls back to an
index-based merge) and that merge_how controls retention of unmatched rows (use
inner for only matches, left/right to retain unmatched rows from the specified
side, and outer to retain unmatched rows from both); reference the merge
parameters merge_on_column and merge_how and mirror the actual behavior
implemented in dataframe_operations.py (the merge routine handling index-based
merges and left/right/outer semantics).

In `@docs/versioned_docs/version-1.9.0/Components/dataframe-operations.mdx`:
- Around line 157-160: The documentation incorrectly states merge only happens
on columns and that output contains only matched rows; update the wording for
merge_on_column and merge_how to describe that leaving merge_on_column empty
triggers an index-based merge and that merge_how governs whether unmatched rows
are retained (inner = only matched rows; left/right = keep all rows from
respective side including unmatched; outer = keep all rows from both sides), and
clarify the function/class that returns a Table with rows from both inputs
according to these rules (refer to merge_on_column and merge_how and the
dataframe_operations implementation that handles index-based merging).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d39df159-81f5-4b70-b490-7859f675f139

📥 Commits

Reviewing files that changed from the base of the PR and between 9aae6de and 32b046e.

📒 Files selected for processing (2)
  • docs/docs/Components/dataframe-operations.mdx
  • docs/versioned_docs/version-1.9.0/Components/dataframe-operations.mdx

Comment thread docs/docs/Components/dataframe-operations.mdx
@github-actions

This comment has been minimized.

Comment thread docs/docs/Components/dataframe-operations.mdx Outdated
@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 22, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@mendonk mendonk enabled auto-merge April 22, 2026 17:10
@mendonk mendonk added this pull request to the merge queue Apr 22, 2026
Merged via the queue into main with commit 0202cb9 Apr 22, 2026
21 checks passed
@mendonk mendonk deleted the docs-concatenate-and-merge-table-operations branch April 22, 2026 17:21
@mendonk mendonk restored the docs-concatenate-and-merge-table-operations branch April 22, 2026 17:35
@mendonk mendonk deleted the docs-concatenate-and-merge-table-operations branch April 22, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants