Skip to content

fix: prevent canvas text-selection highlight on shift+drag in Tauri#12995

Merged
olayinkaadelakun merged 5 commits into
release-1.10.0from
LE-1100
May 13, 2026
Merged

fix: prevent canvas text-selection highlight on shift+drag in Tauri#12995
olayinkaadelakun merged 5 commits into
release-1.10.0from
LE-1100

Conversation

@olayinkaadelakun
Copy link
Copy Markdown
Collaborator

@olayinkaadelakun olayinkaadelakun commented May 6, 2026

Summary

  • Fixes a desktop-only visual bug where shift-dragging to box-select nodes caused
    The canvas viewport div to render a blue browser selection highlight in the
    Tauri app but not in the OSS web version

Root cause

Tauri uses WKWebView (WebKit) on macOS rather than a Chromium renderer. Chromium
automatically suppresses text selection on elements during pointer-drag gestures,
even without an explicit user-select rule. WKWebView does not — it applies the
native selection highlight unless the element explicitly opts out via
-webkit-user-select: none.

Test plan

  • Open the desktop app and shift+drag across the canvas to box-select nodes —
    confirm no blue text-selection highlight appears on the viewport div
  • Confirm normal node drag, pan, and box-select still work as expected
  • Verify the OSS web version is unaffected (rule is a no-op in Chromium since
    drag already suppresses selection natively)

Before on Safari
Screenshot 2026-05-06 at 5 07 28 PM
After on Safari
Screenshot 2026-05-06 at 5 08 21 PM

@olayinkaadelakun olayinkaadelakun self-assigned this May 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b616c9f-2594-4c1a-96bb-4d1fdf37eb5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch LE-1100

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.58%. Comparing base (80d0db3) to head (6272d84).
⚠️ Report is 3 commits behind head on release-1.10.0.

Files with missing lines Patch % Lines
.../pages/FlowPage/components/PageComponent/index.tsx 66.66% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (50.74%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #12995      +/-   ##
==================================================
- Coverage           54.69%   54.58%   -0.11%     
==================================================
  Files                2101     2102       +1     
  Lines              192799   192835      +36     
  Branches            29257    27674    -1583     
==================================================
- Hits               105443   105267     -176     
- Misses              86186    86398     +212     
  Partials             1170     1170              
Flag Coverage Δ
backend 57.66% <ø> (+0.03%) ⬆️
frontend 54.76% <97.22%> (-0.16%) ⬇️
lfx 50.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nents/PageComponent/hooks/useShiftDragSelectFix.ts 100.00% <100.00%> (ø)
.../pages/FlowPage/components/PageComponent/index.tsx 53.02% <66.66%> (-0.53%) ⬇️

... and 58 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 37%
37.87% (45673/120580) 67.48% (6271/9293) 37.62% (1053/2799)

Unit Test Results

Tests Skipped Failures Errors Time
4236 0 💤 0 ❌ 0 🔥 10m 2s ⏱️

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 6, 2026
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 6, 2026
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 6, 2026
Copy link
Copy Markdown
Collaborator

@viktoravelino viktoravelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label May 11, 2026
@olayinkaadelakun olayinkaadelakun disabled auto-merge May 11, 2026 15:17
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 11, 2026
@olayinkaadelakun olayinkaadelakun added this pull request to the merge queue May 13, 2026
Merged via the queue into release-1.10.0 with commit 191aaba May 13, 2026
104 of 105 checks passed
@olayinkaadelakun olayinkaadelakun deleted the LE-1100 branch May 13, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants