fix: pin postgres image to bookworm in docker_example#13027
Conversation
…ation mismatch The postgres:16 tag silently moved its base from Debian Bookworm (glibc 2.36) to Trixie (glibc 2.41), causing a recurring collation version mismatch warning on existing langflow-postgres volumes. Pin to postgres:16-bookworm in both docker-compose files and update the README so existing data volumes keep matching the OS locale data. Refs: #9608
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mirror the docker_example pin in the four current docs that publish copyable Compose snippets pairing postgres:16 with a persistent langflow-postgres volume. Prevents the same Bookworm-to-Trixie collation version mismatch warning when users follow docs instead of docker_example. Versioned historical docs are left as-is. Refs: #9608
This comment has been minimized.
This comment has been minimized.
vjgit96
left a comment
There was a problem hiding this comment.
we recently updated deb base image to trixie from bookworm(buid-time) so just curious to know why not trixie and just bookworm?
Aligns the pinned postgres base with the langflow runtime image, which moved to Debian Trixie in #12990. Keeping postgres on bookworm would have diverged the stack and locked the database to an aging glibc that will receive fewer security backports as bookworm ages into oldstable. The pin itself still solves the original bug — postgres:16 cannot silently roll its OS underneath an existing volume. Document the one-time REFRESH COLLATION VERSION step for users upgrading from a bookworm-initialized volume in docker_example/README.md. Refs: #9608
This comment has been minimized.
This comment has been minimized.
|
Build successful! ✅ |
* fix: pin postgres image to bookworm in docker_example to prevent collation mismatch The postgres:16 tag silently moved its base from Debian Bookworm (glibc 2.36) to Trixie (glibc 2.41), causing a recurring collation version mismatch warning on existing langflow-postgres volumes. Pin to postgres:16-bookworm in both docker-compose files and update the README so existing data volumes keep matching the OS locale data. Refs: #9608 * docs: pin postgres image to bookworm in current docs compose snippets Mirror the docker_example pin in the four current docs that publish copyable Compose snippets pairing postgres:16 with a persistent langflow-postgres volume. Prevents the same Bookworm-to-Trixie collation version mismatch warning when users follow docs instead of docker_example. Versioned historical docs are left as-is. Refs: #9608 * fix: switch postgres pin from bookworm to trixie for OS consistency Aligns the pinned postgres base with the langflow runtime image, which moved to Debian Trixie in #12990. Keeping postgres on bookworm would have diverged the stack and locked the database to an aging glibc that will receive fewer security backports as bookworm ages into oldstable. The pin itself still solves the original bug — postgres:16 cannot silently roll its OS underneath an existing volume. Document the one-time REFRESH COLLATION VERSION step for users upgrading from a bookworm-initialized volume in docker_example/README.md. Refs: #9608 (cherry picked from commit 7504eb4)
Summary
Pin the PostgreSQL image in
docker_example/frompostgres:16topostgres:16-bookwormto prevent a recurring collation version mismatch warning on existinglangflow-postgresvolumes.Background
Users running Langflow with the example
docker-compose.ymlandpull_policy: alwayssee this warning after Docker Hub silently rolled thepostgres:16tag from Debian Bookworm (glibc 2.36) to Debian Trixie (glibc 2.41):The warning is harmless in most cases but floods logs and creates user confusion. Reported in #9608.
Root cause
docker_example/docker-compose.ymlusedpostgres:16without a base-OS qualifier. When Docker Hub updatedpostgres:16from a Bookworm-based build to a Trixie-based build, any user withpull_policy: alwayspulled the new image and started it against a data directory initialized under the older glibc collation version.Fix
postgres:16-bookwormin docker_example/docker-compose.yml and docker_example/pre.docker-compose.yml.Bookworm specifically (vs. Trixie) keeps the OS locale data stable for users with pre-existing volumes initialized under glibc 2.36, while still receiving 16.x patch updates.
Test plan
docker compose -f docker_example/docker-compose.yml upstarts cleanlycollation version mismatchwarning on container startuplangflow-postgresvolumes (initialized under glibc 2.36) start without the warninglangflowservice can still connect to the pinned postgres