Skip to content

chore: Block hardcoded Tailwind palette via Biome lint#13125

Merged
Cristhianzl merged 8 commits into
release-1.10.0from
cz/fix-biome-tailwind-colors
May 15, 2026
Merged

chore: Block hardcoded Tailwind palette via Biome lint#13125
Cristhianzl merged 8 commits into
release-1.10.0from
cz/fix-biome-tailwind-colors

Conversation

@Cristhianzl
Copy link
Copy Markdown
Member

OBJECTIVE: Enforce use of semantic color tokens from src/style/index.css over hardcoded Tailwind palette classes in frontend code.

CHANGES:

  • Add Biome GritQL plugin flagging hardcoded Tailwind palettes (e.g. bg-zinc-900, text-slate-500) in JS/TS/TSX
  • Refactor 8 files (knowledge ingestion UI, assistant panel, NodeStatus, etc.) to use semantic tokens (bg-accent-emerald, text-destructive, bg-error-red, …)
  • Suppress plugin per-line in styleUtils.ts for the intentional decorative gradient palette
  • Wire lint-js.yml into ci.yml as a required job gated on frontend path-filter
  • Add fetch-depth: 0 to checkout so biome check --changed can diff against main

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2bb9ebc4-2e9a-4e99-9d14-fa7e79dfa5af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cz/fix-biome-tailwind-colors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 67.08861% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.83%. Comparing base (bbe2ccd) to head (8aceec6).
⚠️ Report is 10 commits behind head on release-1.10.0.

Files with missing lines Patch % Lines
.../knowledgePage/components/IngestionRunsSection.tsx 8.33% 11 Missing ⚠️
...owledgePage/components/IngestionRunDetailModal.tsx 0.00% 9 Missing ⚠️
...antPanel/components/assistant-component-result.tsx 71.42% 2 Missing ⚠️
...seUploadModal/components/IngestionHistoryPanel.tsx 83.33% 2 Missing ⚠️
...chat-view/chat-messages/components/bot-message.tsx 0.00% 1 Missing ⚠️
...nd/src/components/core/sanitizedMarkdown/index.tsx 50.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (49.30%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #13125      +/-   ##
==================================================
+ Coverage           54.56%   54.83%   +0.27%     
==================================================
  Files                2140     2145       +5     
  Lines              199445   200237     +792     
  Branches            30124    30202      +78     
==================================================
+ Hits               108825   109802     +977     
+ Misses              89439    89252     -187     
- Partials             1181     1183       +2     
Flag Coverage Δ
backend 59.90% <ø> (+0.18%) ⬆️
frontend 54.91% <67.08%> (+0.33%) ⬆️
lfx 49.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mNodes/GenericNode/components/NodeStatus/index.tsx 34.51% <100.00%> (+0.18%) ⬆️
...ts/core/canvasControlsComponent/CanvasControls.tsx 89.88% <100.00%> (ø)
src/frontend/src/utils/styleUtils.ts 95.43% <100.00%> (+0.19%) ⬆️
...chat-view/chat-messages/components/bot-message.tsx 73.35% <0.00%> (ø)
...nd/src/components/core/sanitizedMarkdown/index.tsx 75.54% <50.00%> (+0.13%) ⬆️
...antPanel/components/assistant-component-result.tsx 37.66% <71.42%> (-0.27%) ⬇️
...seUploadModal/components/IngestionHistoryPanel.tsx 88.23% <83.33%> (+0.11%) ⬆️
...owledgePage/components/IngestionRunDetailModal.tsx 10.55% <0.00%> (ø)
.../knowledgePage/components/IngestionRunsSection.tsx 10.14% <8.33%> (-0.10%) ⬇️

... and 89 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 38%
38.41% (47907/124697) 67.9% (6542/9634) 38.28% (1100/2873)

Unit Test Results

Tests Skipped Failures Errors Time
4302 0 💤 0 ❌ 0 🔥 9m 13s ⏱️

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label May 14, 2026
@Cristhianzl Cristhianzl added this pull request to the merge queue May 15, 2026
Merged via the queue into release-1.10.0 with commit 53c62bc May 15, 2026
114 of 115 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-biome-tailwind-colors branch May 15, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants