fix: upgrade langchain-classic to 1.0.7#13130
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe ChangesDependency Version Update
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 9✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.9.3 #13130 +/- ##
================================================
Coverage ? 53.02%
================================================
Files ? 2033
Lines ? 184537
Branches ? 27397
================================================
Hits ? 97849
Misses ? 85576
Partials ? 1112
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ogabrielluiz
left a comment
There was a problem hiding this comment.
LGTM. Safe hotfix bump — picks up the load/storage hardening fixes from langchain-classic 1.0.5–1.0.7. Verified no Langflow code imports the modules that were tightened (storage, load, hub); all callers use agents/chains/memory surface which is unchanged.
The failing 3.14 Group 5 check is an unrelated pre-existing pydantic v1 issue in langchain_community's baidu_qianfan import, not caused by this PR.
Minor (non-blocking) thought: the constraint widens from ~=1.0.0 to >=1.0.7,<2.0.0, so downstream consumers without a lock will accept future 1.x minors. If you want tighter pinning on a release branch, ~=1.0.7 would limit to 1.0.x. Either is reasonable.
| "loguru>=0.7.3,<1.0.0", | ||
| "langchain~=1.2.0", | ||
| "langchain-classic~=1.0.0", | ||
| "langchain-classic>=1.0.7,<2.0.0", |
There was a problem hiding this comment.
nit: since this is a hotfix on a release branch, would ~=1.0.7 work here? that keeps it pinned to 1.0.x and still picks up the security fixes, but avoids downstream installs (without our lock) auto-pulling future 1.x minor releases of langchain-classic. happy either way though — not blocking.
- Update version constraint from ~=1.0.0 to ~=1.0.7 - Fixes issues present in version 1.0.4 - Update uv.lock with new dependency resolution
1cd262a to
949fe4f
Compare
Summary by CodeRabbit