Skip to content

fix: Clean up the text output of the URL component#8158

Merged
erichare merged 13 commits into
native-components-cleanfrom
fix-url-comp-output
May 21, 2025
Merged

fix: Clean up the text output of the URL component#8158
erichare merged 13 commits into
native-components-cleanfrom
fix-url-comp-output

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

This pull request cleans up the text output of the URL component and ensures its parsed correctly in chat output.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels May 21, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 21, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 21, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 21, 2025
@erichare erichare merged commit 227e259 into native-components-clean May 21, 2025
15 of 17 checks passed
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 21, 2025
@erichare erichare deleted the fix-url-comp-output branch May 21, 2025 18:42
github-merge-queue Bot pushed a commit that referenced this pull request May 30, 2025
* url component update.

* update to url component and tests

* Make directory component legacy

* Only output dataframe from file component

* Update base_file.py

* Update description and output

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Deprecate Processing Components.

* Move Tool and CQL Astra to bundle

* Comprehensive improvements to Save to File

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Clean up description, dont unlink file

* Remove print statement

* fix: Clean up the text output of the URL component (#8158)

* Clean text output from url component

* [autofix.ci] apply automated fixes

* Update data.py

* Make a visible function

* URL component cleaning refactor

* Update data.py

* [autofix.ci] apply automated fixes

* Update with chat output fixes and template updates

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* Fix linting issues

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* revert datastax component bundle

* Restore the two tools as well

* Two more template updates

* Update Vector Store RAG.json

* Update Vector Store RAG.json

* Update __init__.py

* Update directory.py

* Update url.py

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Update test_basic_prompting.py

* Unit test updates

* Fix unit tests one more time

* Fix conversion in safe convert

* Update chat.py

* Temporary disabling of save to file tests

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Fix some more unit tests

* Update test_split_text_component.py

* [autofix.ci] apply automated fixes

* Update test_url_component.py

* Update file component outputs in tests

* Fix starter projects with old data to message

* Update test_split_text_component.py

* fix slider inputs

* Update data.py

* [autofix.ci] apply automated fixes

* Update data.py

* 🐛 (typescript_test.yml): increase the maximum shard count to 40 to improve test distribution and performance

* Rename safe file component

* [autofix.ci] apply automated fixes

* Make sure we import the right save to file

* 🔧 (freeze.spec.ts): update test description to match the changed element's test ID
🔧 (Blog Writer.spec.ts): add click event to test file input element
🔧 (edit-tools.spec.ts): update assertion to check if rowsCount is greater than 2 instead of 3
🔧 (loop-component.spec.ts): add import statement for uploadFile function
🔧 (tool-mode.spec.ts): update targetPosition coordinates for dragTo action
🔧 (chatInputOutputUser-shard-1.spec.ts): update test description to match the changed element's test ID

* ✨ (stop-building.spec.ts): update click target for better test coverage and accuracy
✨ (fileUploadComponent.spec.ts): adjust drag target position and update click targets for improved testing flow and coverage

* 🐛 (typescript_test.yml): adjust the maximum shard count to 10 to prevent excessive parallelization and improve test performance

* Two url component types

* Update ruff formatting

* [autofix.ci] apply automated fixes

* Revert name of method

* 🐛 (typescript_test.yml): increase the maximum shard count to 40 to improve test distribution and performance

* ✨ (freeze.spec.ts): update test to use correct testid for element
✨ (stop-building.spec.ts): update test to use correct testid for element
✨ (loop-component.spec.ts): update test to use correct testid for element
✨ (chatInputOutputUser-shard-1.spec.ts): update tests to use correct testid for element

* ✨ (freeze.spec.ts, stop-building.spec.ts, loop-component.spec.ts, chatInputOutputUser-shard-1.spec.ts): update test selectors to match changes in the frontend UI, improving test reliability and maintainability.

* ✨ (stop-building.spec.ts): update test to use correct testId for clicking element
✨ (loop-component.spec.ts): update test to use correct testId for clicking element
✨ (chatInputOutputUser-shard-1.spec.ts): update multiple tests to use correct testId for clicking element

* 📝 (freeze.spec.ts): update test selector to match the correct element on the page for better test accuracy

* 🔧 (typescript_test.yml): adjust optimal shard count calculation to ensure a maximum of 10 shards for test execution
🔧 (chatInputOutputUser-shard-1.spec.ts): update test selectors to match changes in the frontend output structure for integration tests

* ✨ (chatInputOutputUser-shard-1.spec.ts): update test selectors for better clarity and consistency in the integration tests.

---------

Co-authored-by: Eric Hare <ericrhare@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
ogabrielluiz pushed a commit to bkatya2001/langflow that referenced this pull request Jun 24, 2025
* url component update.

* update to url component and tests

* Make directory component legacy

* Only output dataframe from file component

* Update base_file.py

* Update description and output

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Deprecate Processing Components.

* Move Tool and CQL Astra to bundle

* Comprehensive improvements to Save to File

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Clean up description, dont unlink file

* Remove print statement

* fix: Clean up the text output of the URL component (langflow-ai#8158)

* Clean text output from url component

* [autofix.ci] apply automated fixes

* Update data.py

* Make a visible function

* URL component cleaning refactor

* Update data.py

* [autofix.ci] apply automated fixes

* Update with chat output fixes and template updates

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* Fix linting issues

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* revert datastax component bundle

* Restore the two tools as well

* Two more template updates

* Update Vector Store RAG.json

* Update Vector Store RAG.json

* Update __init__.py

* Update directory.py

* Update url.py

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Update test_basic_prompting.py

* Unit test updates

* Fix unit tests one more time

* Fix conversion in safe convert

* Update chat.py

* Temporary disabling of save to file tests

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Fix some more unit tests

* Update test_split_text_component.py

* [autofix.ci] apply automated fixes

* Update test_url_component.py

* Update file component outputs in tests

* Fix starter projects with old data to message

* Update test_split_text_component.py

* fix slider inputs

* Update data.py

* [autofix.ci] apply automated fixes

* Update data.py

* 🐛 (typescript_test.yml): increase the maximum shard count to 40 to improve test distribution and performance

* Rename safe file component

* [autofix.ci] apply automated fixes

* Make sure we import the right save to file

* 🔧 (freeze.spec.ts): update test description to match the changed element's test ID
🔧 (Blog Writer.spec.ts): add click event to test file input element
🔧 (edit-tools.spec.ts): update assertion to check if rowsCount is greater than 2 instead of 3
🔧 (loop-component.spec.ts): add import statement for uploadFile function
🔧 (tool-mode.spec.ts): update targetPosition coordinates for dragTo action
🔧 (chatInputOutputUser-shard-1.spec.ts): update test description to match the changed element's test ID

* ✨ (stop-building.spec.ts): update click target for better test coverage and accuracy
✨ (fileUploadComponent.spec.ts): adjust drag target position and update click targets for improved testing flow and coverage

* 🐛 (typescript_test.yml): adjust the maximum shard count to 10 to prevent excessive parallelization and improve test performance

* Two url component types

* Update ruff formatting

* [autofix.ci] apply automated fixes

* Revert name of method

* 🐛 (typescript_test.yml): increase the maximum shard count to 40 to improve test distribution and performance

* ✨ (freeze.spec.ts): update test to use correct testid for element
✨ (stop-building.spec.ts): update test to use correct testid for element
✨ (loop-component.spec.ts): update test to use correct testid for element
✨ (chatInputOutputUser-shard-1.spec.ts): update tests to use correct testid for element

* ✨ (freeze.spec.ts, stop-building.spec.ts, loop-component.spec.ts, chatInputOutputUser-shard-1.spec.ts): update test selectors to match changes in the frontend UI, improving test reliability and maintainability.

* ✨ (stop-building.spec.ts): update test to use correct testId for clicking element
✨ (loop-component.spec.ts): update test to use correct testId for clicking element
✨ (chatInputOutputUser-shard-1.spec.ts): update multiple tests to use correct testId for clicking element

* 📝 (freeze.spec.ts): update test selector to match the correct element on the page for better test accuracy

* 🔧 (typescript_test.yml): adjust optimal shard count calculation to ensure a maximum of 10 shards for test execution
🔧 (chatInputOutputUser-shard-1.spec.ts): update test selectors to match changes in the frontend output structure for integration tests

* ✨ (chatInputOutputUser-shard-1.spec.ts): update test selectors for better clarity and consistency in the integration tests.

---------

Co-authored-by: Eric Hare <ericrhare@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant