Skip to content

chore: Refactor dependencies in pyproject.toml files#8249

Merged
ogabrielluiz merged 3 commits into
mainfrom
update-lc-exp
May 30, 2025
Merged

chore: Refactor dependencies in pyproject.toml files#8249
ogabrielluiz merged 3 commits into
mainfrom
update-lc-exp

Conversation

@ogabrielluiz
Copy link
Copy Markdown
Contributor

@ogabrielluiz ogabrielluiz commented May 28, 2025

Remove the deploy dependency group and update the setuptools version constraint. Additionally, add a version constraint for the datasets dependency.

Summary by CodeRabbit

  • Chores
    • Updated dependency versions and added a new required package.
    • Removed the optional "deploy" dependency group and related packages from the dependency list.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 28, 2025
@ogabrielluiz ogabrielluiz enabled auto-merge May 28, 2025 15:05
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 28, 2025

CodSpeed Performance Report

Merging #8249 will degrade performances by 16.23%

Comparing update-lc-exp (22e0847) with main (d84ea5c)

Summary

❌ 1 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cancel_nonexistent_build 8.3 ms 9.9 ms -16.23%

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 30, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2025

Walkthrough

The updates modify dependency specifications in two pyproject.toml files. A new main dependency, datasets>2.14.7, is added, and the optional deploy dependency group—containing celery, redis, and flower—is removed from both files. Additionally, the setuptools version constraint is updated in one file.

Changes

File(s) Change Summary
pyproject.toml Added datasets>2.14.7 to main dependencies; removed deploy optional dependency group.
src/backend/base/pyproject.toml Updated setuptools to >=78.1.0,<79.0.0; removed deploy group; updated all group accordingly.

Poem

In the garden of code, dependencies bloom,
"datasets" hops in, dispelling some gloom.
The "deploy" group hops away,
While "setuptools" finds a brand new day.
With lighter paws and fresher air,
This rabbit leaps—your project’s rare! 🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdf658a and 22e0847.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • pyproject.toml (1 hunks)
  • src/backend/base/pyproject.toml (1 hunks)
🔇 Additional comments (1)
src/backend/base/pyproject.toml (1)

67-67: Verify updated setuptools version constraint

The new constraint setuptools>=78.1.0,<79.0.0 locks to a narrow range. Ensure that version 78.1.0 is published on PyPI and compatible with your build backend (hatchling) and any dependent tooling.

Comment thread pyproject.toml
"elasticsearch==8.16.0",
"pytube==15.0.0",
"dspy-ai==2.5.41",
"datasets>2.14.7",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Validate 'datasets' version specifier

The constraint "datasets>2.14.7" uses a strict greater-than operator, excluding exactly version 2.14.7. If you intend to include that release, consider changing it to datasets>=2.14.7.

🤖 Prompt for AI Agents
In pyproject.toml at line 54, the version specifier for 'datasets' uses a strict
greater-than operator (">2.14.7"), which excludes version 2.14.7 itself. To
include version 2.14.7 and later, change the specifier to use a
greater-than-or-equal operator (">=2.14.7").

@ogabrielluiz ogabrielluiz added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 9b345cc May 30, 2025
33 of 34 checks passed
@ogabrielluiz ogabrielluiz deleted the update-lc-exp branch May 30, 2025 14:40
ogabrielluiz added a commit to bkatya2001/langflow that referenced this pull request Jun 24, 2025
* feat: add datasets dependency version constraint

* fix: update setuptools version constraint to 78.1.1

* refactor: remove deploy dependency group from pyproject.toml
smatiolids pushed a commit to smatiolids/langflow-dev that referenced this pull request Jul 4, 2025
* feat: add datasets dependency version constraint

* fix: update setuptools version constraint to 78.1.1

* refactor: remove deploy dependency group from pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants