Skip to content

docs: update details summary css for better arrow alignment#8376

Merged
mendonk merged 3 commits into
mainfrom
docs-align-details-style
Jun 4, 2025
Merged

docs: update details summary css for better arrow alignment#8376
mendonk merged 3 commits into
mainfrom
docs-align-details-style

Conversation

@mendonk
Copy link
Copy Markdown
Collaborator

@mendonk mendonk commented Jun 4, 2025

Fix details summary css to align arrow with text and trim the clickable label.

Preview build at Results tab

Before
Screenshot 2025-06-04 at 1 43 33 PM

After
Screenshot 2025-06-04 at 1 41 06 PM

Summary by CodeRabbit

Summary by CodeRabbit

  • Style
    • Improved the appearance and alignment of summary elements in markdown details for a cleaner and more consistent look.
    • Enhanced keyboard accessibility with a visible focus outline on summary elements.

@mendonk mendonk requested a review from KimberlyFields June 4, 2025 17:43
@mendonk mendonk self-assigned this Jun 4, 2025
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 4, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2025

Walkthrough

The CSS rules for .markdown details summary were modified to replace block-level styling and padding with flexbox layout, centered alignment, and spacing between items. A new focus-visible outline style was added for improved keyboard accessibility.

Changes

File Change Summary
docs/css/custom.css Changed .markdown details summary from block layout with padding to flex layout with centered alignment, gap, no list style, and no outline; added focus-visible outline style for accessibility.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to CSS styling.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52d303e and 3c611fb.

📒 Files selected for processing (1)
  • docs/css/custom.css (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/css/custom.css
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-and-deploy

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jun 4, 2025
@mendonk mendonk changed the title docs: update details-summary css for better arrow alignment docs: update details summary css for better arrow alignment Jun 4, 2025
@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Jun 4, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/css/custom.css (1)

400-406: Touch target size: ensure tappable area remains sufficient
By removing width: 100% and padding, the hit area for the summary is now limited to its content, which may be too small on touch devices. Please test on mobile to ensure the summary stays easily tappable (≥44×44 px). Consider re-introducing minimal padding or a min-height if necessary.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 227a091 and 52d303e.

📒 Files selected for processing (1)
  • docs/css/custom.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-and-deploy

Comment thread docs/css/custom.css
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jun 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 4, 2025
@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jun 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Jun 4, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 4, 2025
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 4, 2025
@mendonk mendonk added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 06f7279 Jun 4, 2025
28 of 33 checks passed
@mendonk mendonk deleted the docs-align-details-style branch June 4, 2025 19:19
ogabrielluiz pushed a commit that referenced this pull request Jun 5, 2025
* align-details-summary-appearance

* accessibility-suggestion
ogabrielluiz pushed a commit to bkatya2001/langflow that referenced this pull request Jun 24, 2025
…-ai#8376)

* align-details-summary-appearance

* accessibility-suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants