-
Notifications
You must be signed in to change notification settings - Fork 9.1k
feat: add sessions endpoint with session management enhancements #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
857d016
📝 (monitor.py): Add endpoint to get sessions and handle session_id en…
Cristhianzl 668a325
📝 (constants.ts): Add SESSIONS constant to API URLs for monitoring se…
Cristhianzl e9e1a53
Merge branch 'main' into cz/message-playground
Cristhianzl b5ca559
🔧 (pyproject.toml): update testpaths to point to the correct director…
Cristhianzl 20129db
✨ (use-get-sessions-from-flow.ts): Always include the flow ID as the …
Cristhianzl 041df22
♻️ (use-get-messages-mutation.ts): remove unused imports and refactor…
Cristhianzl 4dbf1b5
✨ (test_session_endpoint.py): refactor test function names for better…
Cristhianzl a29f798
✨ (create-new-session-name.ts): add function to generate a new sessio…
Cristhianzl ad392bc
[autofix.ci] apply automated fixes
autofix-ci[bot] 52c1f36
✨ (monitor.py): rename get_sessions endpoint to get_message_sessions …
Cristhianzl d2704f4
📝 (monitor.py): Remove unnecessary whitespace and import statement
Cristhianzl 4d72d57
[autofix.ci] apply automated fixes
autofix-ci[bot] 39ba6c6
🐛 (monitor.py): Fix type hinting issue in delete_messages function
Cristhianzl c16532b
merge fix
Cristhianzl 49250b9
[autofix.ci] apply automated fixes
autofix-ci[bot] 09c6b41
Merge branch 'main' into cz/message-playground
ogabrielluiz d342452
fix: update SQL statement to use col() for session_id filtering in ge…
ogabrielluiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| from uuid import uuid4 | ||
|
|
||
| import pytest | ||
| from httpx import AsyncClient | ||
| from langflow.memory import aadd_messagetables | ||
| from langflow.services.database.models.message.model import MessageTable | ||
| from langflow.services.deps import session_scope | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| async def messages_with_flow_ids(session): # noqa: ARG001 | ||
| """Create messages with different session_ids and flow_ids for testing sessions endpoint.""" | ||
| async with session_scope() as _session: | ||
| flow_id_1 = uuid4() | ||
| flow_id_2 = uuid4() | ||
|
|
||
| # Create MessageTable objects directly since MessageCreate doesn't have flow_id field | ||
| messagetables = [ | ||
| MessageTable( | ||
| text="Message 1", sender="User", sender_name="User", session_id="session_A", flow_id=flow_id_1 | ||
| ), | ||
| MessageTable(text="Message 2", sender="AI", sender_name="AI", session_id="session_A", flow_id=flow_id_1), | ||
| MessageTable( | ||
| text="Message 3", sender="User", sender_name="User", session_id="session_B", flow_id=flow_id_1 | ||
| ), | ||
| MessageTable( | ||
| text="Message 4", sender="User", sender_name="User", session_id="session_C", flow_id=flow_id_2 | ||
| ), | ||
| MessageTable(text="Message 5", sender="AI", sender_name="AI", session_id="session_D", flow_id=flow_id_2), | ||
| MessageTable( | ||
| text="Message 6", | ||
| sender="User", | ||
| sender_name="User", | ||
| session_id="session_E", | ||
| flow_id=None, # No flow_id | ||
| ), | ||
| ] | ||
| created_messages = await aadd_messagetables(messagetables, _session) | ||
|
|
||
| return { | ||
| "messages": created_messages, | ||
| "flow_id_1": flow_id_1, | ||
| "flow_id_2": flow_id_2, | ||
| "expected_sessions_flow_1": {"session_A", "session_B"}, | ||
| "expected_sessions_flow_2": {"session_C", "session_D"}, | ||
| "expected_all_sessions": {"session_A", "session_B", "session_C", "session_D", "session_E"}, | ||
| } | ||
|
|
||
|
|
||
| # Tests for /sessions endpoint | ||
| @pytest.mark.api_key_required | ||
| async def test_get_sessions_all(client: AsyncClient, logged_in_headers, messages_with_flow_ids): | ||
| """Test getting all sessions without any filter.""" | ||
| response = await client.get("api/v1/monitor/messages/sessions", headers=logged_in_headers) | ||
|
|
||
| assert response.status_code == 200, response.text | ||
| sessions = response.json() | ||
| assert isinstance(sessions, list) | ||
|
|
||
| # Convert to set for easier comparison since order doesn't matter | ||
| returned_sessions = set(sessions) | ||
| expected_sessions = messages_with_flow_ids["expected_all_sessions"] | ||
|
|
||
| assert returned_sessions == expected_sessions | ||
| assert len(sessions) == len(expected_sessions) | ||
|
|
||
|
|
||
| @pytest.mark.api_key_required | ||
| async def test_get_sessions_with_flow_id_filter(client: AsyncClient, logged_in_headers, messages_with_flow_ids): | ||
| """Test getting sessions filtered by flow_id.""" | ||
| flow_id_1 = messages_with_flow_ids["flow_id_1"] | ||
|
|
||
| response = await client.get( | ||
| "api/v1/monitor/messages/sessions", params={"flow_id": str(flow_id_1)}, headers=logged_in_headers | ||
| ) | ||
|
|
||
| assert response.status_code == 200, response.text | ||
| sessions = response.json() | ||
| assert isinstance(sessions, list) | ||
|
|
||
| returned_sessions = set(sessions) | ||
| expected_sessions = messages_with_flow_ids["expected_sessions_flow_1"] | ||
|
|
||
| assert returned_sessions == expected_sessions | ||
| assert len(sessions) == len(expected_sessions) | ||
|
|
||
|
|
||
| @pytest.mark.api_key_required | ||
| async def test_get_sessions_with_different_flow_id(client: AsyncClient, logged_in_headers, messages_with_flow_ids): | ||
| """Test getting sessions filtered by a different flow_id.""" | ||
| flow_id_2 = messages_with_flow_ids["flow_id_2"] | ||
|
|
||
| response = await client.get( | ||
| "api/v1/monitor/messages/sessions", params={"flow_id": str(flow_id_2)}, headers=logged_in_headers | ||
| ) | ||
|
|
||
| assert response.status_code == 200, response.text | ||
| sessions = response.json() | ||
| assert isinstance(sessions, list) | ||
|
|
||
| returned_sessions = set(sessions) | ||
| expected_sessions = messages_with_flow_ids["expected_sessions_flow_2"] | ||
|
|
||
| assert returned_sessions == expected_sessions | ||
| assert len(sessions) == len(expected_sessions) | ||
|
|
||
|
|
||
| @pytest.mark.api_key_required | ||
| async def test_get_sessions_with_non_existent_flow_id(client: AsyncClient, logged_in_headers): | ||
| """Test getting sessions with a non-existent flow_id returns empty list.""" | ||
| non_existent_flow_id = uuid4() | ||
|
|
||
| response = await client.get( | ||
| "api/v1/monitor/messages/sessions", params={"flow_id": str(non_existent_flow_id)}, headers=logged_in_headers | ||
| ) | ||
|
|
||
| assert response.status_code == 200, response.text | ||
| sessions = response.json() | ||
| assert isinstance(sessions, list) | ||
| assert len(sessions) == 0 | ||
|
|
||
|
|
||
| @pytest.mark.api_key_required | ||
| async def test_get_sessions_empty_database(client: AsyncClient, logged_in_headers): | ||
| """Test getting sessions when no messages exist in database.""" | ||
| response = await client.get("api/v1/monitor/messages/sessions", headers=logged_in_headers) | ||
|
|
||
| assert response.status_code == 200, response.text | ||
| sessions = response.json() | ||
| assert isinstance(sessions, list) | ||
| assert len(sessions) == 0 | ||
|
|
||
|
|
||
| @pytest.mark.api_key_required | ||
| async def test_get_sessions_invalid_flow_id_format(client: AsyncClient, logged_in_headers): | ||
| """Test getting sessions with invalid flow_id format returns 422.""" | ||
| response = await client.get( | ||
| "api/v1/monitor/messages/sessions", params={"flow_id": "invalid-uuid"}, headers=logged_in_headers | ||
| ) | ||
|
|
||
| assert response.status_code == 422, response.text | ||
| assert "detail" in response.json() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/frontend/src/controllers/API/queries/messages/use-delete-sessions.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { useMutationFunctionType } from "@/types/api"; | ||
| import { UseMutationResult } from "@tanstack/react-query"; | ||
| import { api } from "../../api"; | ||
| import { getURL } from "../../helpers/constants"; | ||
| import { UseRequestProcessor } from "../../services/request-processor"; | ||
|
|
||
| interface DeleteSessionParams { | ||
| sessionId: string; | ||
| } | ||
|
|
||
| export const useDeleteSession: useMutationFunctionType< | ||
| undefined, | ||
| DeleteSessionParams | ||
| > = (options?) => { | ||
| const { mutate, queryClient } = UseRequestProcessor(); | ||
|
|
||
| const deleteSession = async ({ | ||
| sessionId, | ||
| }: DeleteSessionParams): Promise<any> => { | ||
| const response = await api.delete( | ||
| `${getURL("MESSAGES")}/session/${sessionId}`, | ||
| ); | ||
| return response.data; | ||
| }; | ||
|
|
||
| const mutation: UseMutationResult< | ||
| DeleteSessionParams, | ||
| any, | ||
| DeleteSessionParams | ||
| > = mutate(["useDeleteSession"], deleteSession, { | ||
| ...options, | ||
| onSettled: (data, error, variables, context) => { | ||
| queryClient.invalidateQueries({ | ||
| queryKey: ["useGetSessionsFromFlowQuery"], | ||
| }); | ||
| options?.onSettled?.(data, error, variables, context); | ||
| }, | ||
| }); | ||
|
|
||
| return mutation; | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.