fix: Some minor template adjustments for icons in model dropdown#8690
Conversation
dosubot
Bot
added
the
size:L
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update modifies several starter project JSON files by updating the icon metadata for the "Google" provider in the embedded Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to metadata, property ordering, and internal identifiers without affecting control flow. Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
Bot
added
bug
github-actions
Bot
added
bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json (1)
1476-1490: Inconsistent icon slug between runtime code and stored templateThe persisted node template still advertises the old slug:
"options_metadata": [ { "icon": "OpenAI" }, { "icon": "Anthropic" }, { "icon": "Google" } <-- stale ]Whereas the component code (see lines 1413-1421) now emits:
options_metadata=[{"icon": "OpenAI"}, {"icon": "Anthropic"}, {"icon": "GoogleGenerativeAI"}]When this flow is re-hydrated the UI may show mismatched icons depending on which source wins the merge.
Suggested fix:
- { - "icon": "Google" - } + { + "icon": "GoogleGenerativeAI" + }Aligning both definitions prevents subtle visual regressions during import/export cycles.
src/backend/base/langflow/initial_setup/starter_projects/Research Translation Loop.json (1)
1624-1639: Google provider icon metadata is still outdatedAll other starter-project updates in this PR changed the Google provider icon from
"Google"→"GoogleGenerativeAI", and thecodefield inside this same node already expects the new value.
Leaving the old string here will make the UI show the generic Google icon instead of the Gemini one and breaks consistency across templates."options_metadata": [ { "icon": "OpenAI" }, { "icon": "Anthropic" }, { - "icon": "Google" + "icon": "GoogleGenerativeAI" } ],
♻️ Duplicate comments (3)
src/backend/base/langflow/initial_setup/starter_projects/Hybrid Search RAG.json (1)
2341-2342: Same inconsistency in the secondLanguageModelComponentinstanceThe duplicate component below repeats the pattern: embedded code lists
"GoogleGenerativeAI"while the surrounding JSON keeps"Google". Make sure both stay in sync.src/backend/base/langflow/initial_setup/starter_projects/Basic Prompt Chaining.json (2)
1586-1586: Same inconsistency as earlier nodeThe embedded code for
LanguageModelComponent-uV35fwas updated, but its surrounding template JSON still uses"Google"as the icon. Apply the same fix suggested above.
1873-1873: Third occurrence of template/code divergence
LanguageModelComponent-OVCTyshows the same divergence between code (GoogleGenerativeAI) and template (
🧹 Nitpick comments (1)
src/backend/base/langflow/initial_setup/starter_projects/Hybrid Search RAG.json (1)
2053-2054: Icon mismatch between embedded code & top-level metadataInside the
LanguageModelComponentcode you updated the Google provider’s icon to"GoogleGenerativeAI", but the outer-levelprovider.options_metadata(see lines 2124-2133) still uses"Google".
At runtime this will surface different icons for the same provider in the dropdown versus the component editor.Please align both places to a single value (preferably
"GoogleGenerativeAI"for consistency with the other starter projects).
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/backend/base/langflow/initial_setup/starter_projects/Basic Prompt Chaining.json(7 hunks)src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json(1 hunks)src/backend/base/langflow/initial_setup/starter_projects/Financial Report Parser.json(1 hunks)src/backend/base/langflow/initial_setup/starter_projects/Hybrid Search RAG.json(2 hunks)src/backend/base/langflow/initial_setup/starter_projects/Research Translation Loop.json(24 hunks)src/backend/base/langflow/initial_setup/starter_projects/SEO Keyword Generator.json(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Check PyPI Version Update
🔇 Additional comments (10)
src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json (1)
1409-1425: Verify newGoogleGenerativeAIicon is registered in the icon setThe
DropdownInputdefinition inside the embeddedLanguageModelComponentcode now references{"icon": "GoogleGenerativeAI"}.
If the asset (SVG / font-icon) with that exact slug is not shipped, the UI will silently fall back to a missing-icon placeholder.Please double-check that:
GoogleGenerativeAIexists in the icon registry that the frontend consumes, and- The casing matches exactly (most loaders are case-sensitive).
Otherwise, ship the icon or revert to the previous slug to avoid a broken glyph.
src/backend/base/langflow/initial_setup/starter_projects/Financial Report Parser.json (1)
1082-1090: ```shell
#!/bin/bashDisplay lines 1100-1180 to inspect both embedded code and outer-level options_metadata
sed -n '1100,1180p' "src/backend/base/langflow/initial_setup/starter_projects/Financial Report Parser.json"
</details> <details> <summary>src/backend/base/langflow/initial_setup/starter_projects/Basic Prompt Chaining.json (5)</summary> `311-312`: **No functional impact from JSON key re-ordering** Only the order of `"selected_output"` and `"type"` was swapped. Since JSON objects are unordered by specification, this has no runtime effect. --- `609-610`: **Same as above – cosmetic change only** Key order change in `ChatInput` node; no behaviour change. --- `1042-1043`: **Same as above – cosmetic change only** Key order change in `Prompt-F9fZA` node; safe to ignore. --- `1171-1172`: **Same as above – cosmetic change only** Key order change in `Prompt-kNwlW` node; safe to ignore. --- `1299-1299`: I’ll locate the starter‐project JSON and inspect its static `options_metadata` entries to confirm whether `"icon": "Google"` still appears. ```shell #!/bin/bash # Locate the Basic Prompt Chaining template JSON json_file=$(find src/backend/base/langflow/initial_setup/starter_projects -type f -iname "Basic Prompt Chaining.json") echo "Found: $json_file" # Show the provider block and its options_metadata entries rg -n '"provider"' -A8 -B2 -- "$json_file" rg -n '"options_metadata"' -A2 -B2 -- "$json_file"src/backend/base/langflow/initial_setup/starter_projects/SEO Keyword Generator.json (3)
344-346: No-op key order change – looks fine
Only theselected_outputkey was moved; this is a harmless cosmetic shuffle.
508-510: Second prompt node key order – also fine
Same key-ordering tweak as above; nothing to flag.
966-967: ```shell
#!/bin/bashShow the provider field and its metadata in the SEO Keyword Generator starter project
rg -n '"name": "provider"' -C5 "src/backend/base/langflow/initial_setup/starter_projects/SEO Keyword Generator.json"
Show the full options_metadata block around lines 1020–1060
sed -n '1020,1060p' "src/backend/base/langflow/initial_setup/starter_projects/SEO Keyword Generator.json"
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
…gflow-ai#8690) * fix: Minor template updates from refactoring * Update Research Translation Loop.json * Update Research Translation Loop.json
…gflow-ai#8690) * fix: Minor template updates from refactoring * Update Research Translation Loop.json * Update Research Translation Loop.json
2 participants
This pull request updates the icons for model providers to match the provider name in certain templates.
Summary by CodeRabbit