chore(workflow): comment out Docker build step for langflow-all in nightly release#8727
Conversation
…er limitations * Temporarily disabled the `call_docker_build_main_all` job in the nightly release workflow. * Added a TODO note to revisit this when the runner can accommodate builds with large dependencies like PyTorch.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA workflow step responsible for triggering a Docker build for "langflow-all" in the nightly release process has been commented out. This step is temporarily disabled due to runner environment limitations with large dependencies. No other workflow logic or control flow was changed. Changes
Sequence Diagram(s)✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release_nightly.yml (1)
238-247: Prefer conditional gating over full comment-out to avoid config driftHard-commenting a whole job works short-term, but it tends to diverge from the live pipeline (e.g., renamed inputs/outputs or updated secrets) and silently break when you eventually uncomment it.
Instead of commenting, keep the job live and guard it with an input flag that is alwaysfalse(or an environment variable) until the runner issue is solved:-# call_docker_build_main_all: -# name: Call Docker Build Workflow for langflow-all -# if: always() && ${{ inputs.build_docker_main == 'true' }} +# call_docker_build_main_all: +# name: Call Docker Build Workflow for langflow-all +# if: false # temporarily disabled – runner cannot fit PyTorchThis keeps the YAML syntax &
needsvalidation intact while guaranteeing the job never runs.
When ready, it’s a one-liner to flip the boolean rather than re-hydrate an outdated block.Please confirm no other workflows reference
call_docker_build_main_all; otherwise they will fail theirneedscheck once the job is uncommented.
…ghtly release (#8727) chore: Comment out Docker build workflow for langflow-all due to runner limitations * Temporarily disabled the `call_docker_build_main_all` job in the nightly release workflow. * Added a TODO note to revisit this when the runner can accommodate builds with large dependencies like PyTorch.
…ghtly release (langflow-ai#8727) chore: Comment out Docker build workflow for langflow-all due to runner limitations * Temporarily disabled the `call_docker_build_main_all` job in the nightly release workflow. * Added a TODO note to revisit this when the runner can accommodate builds with large dependencies like PyTorch.
Summary by CodeRabbit