Skip to content

chore(workflow): comment out Docker build step for langflow-all in nightly release#8727

Merged
ogabrielluiz merged 2 commits into
mainfrom
deacivate-build-all-nightly
Jun 26, 2025
Merged

chore(workflow): comment out Docker build step for langflow-all in nightly release#8727
ogabrielluiz merged 2 commits into
mainfrom
deacivate-build-all-nightly

Conversation

@ogabrielluiz
Copy link
Copy Markdown
Contributor

@ogabrielluiz ogabrielluiz commented Jun 25, 2025

Summary by CodeRabbit

  • Chores
    • Temporarily disabled the nightly Docker build for "langflow-all" due to environment limitations. This step will be re-enabled once the runner can handle large dependencies. No impact on other workflow steps.

…er limitations

* Temporarily disabled the `call_docker_build_main_all` job in the nightly release workflow.
* Added a TODO note to revisit this when the runner can accommodate builds with large dependencies like PyTorch.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 25, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A workflow step responsible for triggering a Docker build for "langflow-all" in the nightly release process has been commented out. This step is temporarily disabled due to runner environment limitations with large dependencies. No other workflow logic or control flow was changed.

Changes

File Change Summary
.github/workflows/release_nightly.yml Commented out the call_docker_build_main_all step; added a note explaining the temporary disablement.

Sequence Diagram(s)

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch deacivate-build-all-nightly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot changed the title @coderabbitai chore(workflow): comment out Docker build step for langflow-all in nightly release Jun 25, 2025
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 25, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/release_nightly.yml (1)

238-247: Prefer conditional gating over full comment-out to avoid config drift

Hard-commenting a whole job works short-term, but it tends to diverge from the live pipeline (e.g., renamed inputs/outputs or updated secrets) and silently break when you eventually uncomment it.
Instead of commenting, keep the job live and guard it with an input flag that is always false (or an environment variable) until the runner issue is solved:

-# call_docker_build_main_all:
-#   name: Call Docker Build Workflow for langflow-all
-#   if: always() && ${{ inputs.build_docker_main == 'true' }}
+# call_docker_build_main_all:
+#   name: Call Docker Build Workflow for langflow-all
+#   if: false  # temporarily disabled – runner cannot fit PyTorch

This keeps the YAML syntax & needs validation intact while guaranteeing the job never runs.
When ready, it’s a one-liner to flip the boolean rather than re-hydrate an outdated block.

Please confirm no other workflows reference call_docker_build_main_all; otherwise they will fail their needs check once the job is uncommented.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ae85ab and c319998.

📒 Files selected for processing (1)
  • .github/workflows/release_nightly.yml (1 hunks)

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2025
@ogabrielluiz ogabrielluiz enabled auto-merge June 26, 2025 17:26
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit e73c626 Jun 26, 2025
11 checks passed
@ogabrielluiz ogabrielluiz deleted the deacivate-build-all-nightly branch June 26, 2025 17:37
ogabrielluiz added a commit that referenced this pull request Jun 27, 2025
…ghtly release (#8727)

chore: Comment out Docker build workflow for langflow-all due to runner limitations

* Temporarily disabled the `call_docker_build_main_all` job in the nightly release workflow.
* Added a TODO note to revisit this when the runner can accommodate builds with large dependencies like PyTorch.
Khurdhula-Harshavardhan pushed a commit to JigsawStack/langflow that referenced this pull request Jul 1, 2025
…ghtly release (langflow-ai#8727)

chore: Comment out Docker build workflow for langflow-all due to runner limitations

* Temporarily disabled the `call_docker_build_main_all` job in the nightly release workflow.
* Added a TODO note to revisit this when the runner can accommodate builds with large dependencies like PyTorch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants