Skip to content

feat: clean messages table after run in flow_runner#8773

Merged
ogabrielluiz merged 9 commits into
langflow-ai:mainfrom
barnuri:patch-1
Jul 1, 2025
Merged

feat: clean messages table after run in flow_runner#8773
ogabrielluiz merged 9 commits into
langflow-ai:mainfrom
barnuri:patch-1

Conversation

@barnuri
Copy link
Copy Markdown
Contributor

@barnuri barnuri commented Jun 29, 2025

This pull request introduces updates to the FlowRunner service in src/backend/base/langflow/services/flow/flow_runner.py. The changes focus on improving database query efficiency and enhancing the handling of flow-related data. The most important changes include importing additional database models, modifying the clear_user_state method to handle cascading deletions more effectively, and updating imports for better organization.

Database query improvements:

  • src/backend/base/langflow/services/flow/flow_runner.py: Updated the clear_user_state method to first retrieve flow IDs associated with a user using a select query, then delete related entries in MessageTable and Flow based on those IDs. This ensures cascading deletions are handled more efficiently.

Import updates:

Summary by CodeRabbit

  • Bug Fixes
    • Improved deletion process to ensure that all messages associated with a user's flows are removed when deleting user data. This prevents leftover messages after user or flow deletion.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 29, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The code updates the flow for clearing a user's state by explicitly querying and deleting all message records associated with the user's flows before deleting the flows themselves. It also adjusts the order of deletions, ensuring user records are deleted after associated variable records. Import statements are consolidated for clarity.

Changes

File(s) Change Summary
src/backend/base/langflow/services/flow/flow_runner.py Refactored clear_user_state to explicitly delete messages linked to user flows before deleting flows; reordered user and variable deletions; updated and consolidated import statements.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant FlowRunner
    participant DB

    Caller->>FlowRunner: clear_user_state(user_id)
    FlowRunner->>DB: Query flow IDs for user_id
    DB-->>FlowRunner: Return flow IDs
    FlowRunner->>DB: Delete MessageTable entries for flow IDs
    FlowRunner->>DB: Delete Flow entries for user_id
    FlowRunner->>DB: Delete Variable entries for user_id
    FlowRunner->>DB: Delete User entry for user_id
    FlowRunner-->>Caller: Completion
Loading
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jun 29, 2025
@github-actions github-actions Bot added the enhancement New feature or request label Jun 29, 2025
Copy link
Copy Markdown
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the help, @barnuri !

I'll aprove this but I feel like we could use an in memory db, maybe using a context manager in the database_service. That way we don't have to worry about cleaning anything up, but it probably won't be that simple

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. lgtm This PR has been approved by a maintainer labels Jun 29, 2025
@ogabrielluiz ogabrielluiz enabled auto-merge June 29, 2025 14:53
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jun 29, 2025
@ogabrielluiz ogabrielluiz added lgtm This PR has been approved by a maintainer fast-track Skip tests and sends PR into the merge queue and removed lgtm This PR has been approved by a maintainer labels Jun 29, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jun 30, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jun 30, 2025
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 30, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jun 30, 2025
auto-merge was automatically disabled June 30, 2025 21:58

Pull Request is not mergeable

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 1, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 1, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 1, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 1, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 1, 2025
@ogabrielluiz ogabrielluiz changed the title feat: flow_runner cleanup messages table feat: clean messages table after run in flow_runner Jul 1, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jul 1, 2025
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 1, 2025
Merged via the queue into langflow-ai:main with commit 087fa34 Jul 1, 2025
20 checks passed
lucaseduoli pushed a commit that referenced this pull request Jul 1, 2025
* feat: flow_runner cleanup messages table

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* fix lint

* lint

* fix lint

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Khurdhula-Harshavardhan pushed a commit to JigsawStack/langflow that referenced this pull request Jul 1, 2025
* feat: flow_runner cleanup messages table

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* fix lint

* lint

* fix lint

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
ogabrielluiz pushed a commit that referenced this pull request Jul 2, 2025
* feat: flow_runner cleanup messages table

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* fix lint

* lint

* fix lint

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
jordanrfrazier pushed a commit that referenced this pull request Jul 3, 2025
* feat: flow_runner cleanup messages table

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* fix lint

* lint

* fix lint

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fast-track Skip tests and sends PR into the merge queue lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants