Skip to content

fix: updated Run Flow to not group outputs#8806

Merged
carlosrcoelho merged 1 commit into
mainfrom
fix/run_flow_outputs
Jul 1, 2025
Merged

fix: updated Run Flow to not group outputs#8806
carlosrcoelho merged 1 commit into
mainfrom
fix/run_flow_outputs

Conversation

@lucaseduoli
Copy link
Copy Markdown
Collaborator

@lucaseduoli lucaseduoli commented Jul 1, 2025

This pull request modifies the Output configuration in src/backend/base/langflow/base/tools/run_flow.py to introduce the group_outputs parameter for better organization of outputs. It also refactors the definition of flow_outputs_message for consistency.

Enhancements to output configuration:

  • Added the group_outputs=True parameter to the Output definitions for data_output, dataframe_output, and message_output to enable grouping of outputs. This change improves the organization and handling of flow outputs.

Refactoring for consistency:

  • Refactored the flow_outputs_message definition to align with the formatting style used for other Output definitions, making the code more consistent and readable.

Summary by CodeRabbit

  • Enhancements
    • Improved the display by grouping related output items together for a more organized and user-friendly experience.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 1, 2025

Walkthrough

The change updates the _base_outputs list in the RunFlowBaseComponent class by adding the group_outputs=True attribute to its three Output instances. No other modifications to class or function signatures are made, and all other parameters remain unchanged.

Changes

File(s) Change Summary
src/backend/base/langflow/base/tools/run_flow.py Added group_outputs=True to all three Output instances in _base_outputs of RunFlowBaseComponent.

Suggested labels

bug, size:XS, lgtm

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch fix/run_flow_outputs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 1, 2025
@github-actions github-actions Bot added the bug Something isn't working label Jul 1, 2025
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/backend/base/langflow/base/tools/run_flow.py (1)

66-68: Maintain consistent formatting style with other outputs.

While the addition of group_outputs=True is correct, the formatting change creates inconsistency within the _base_outputs list. Consider maintaining the same multi-line style as the other two outputs for better readability and consistency.

-        Output(
-            name="flow_outputs_message", group_outputs=True, display_name="Flow Message Output", method="message_output"
-        ),
+        Output(
+            name="flow_outputs_message",
+            display_name="Flow Message Output", 
+            method="message_output",
+            group_outputs=True,
+        ),
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 466a18c and bee6bf2.

📒 Files selected for processing (1)
  • src/backend/base/langflow/base/tools/run_flow.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`src/backend/**/*.py`: Run make format_backend to format Python code early and often Run make lint to check for linting issues in backend Python code

src/backend/**/*.py: Run make format_backend to format Python code early and often
Run make lint to check for linting issues in backend Python code

📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)

List of files the instruction was applied to:

  • src/backend/base/langflow/base/tools/run_flow.py
🧠 Learnings (1)
src/backend/base/langflow/base/tools/run_flow.py (2)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.428Z
Learning: Applies to src/backend/base/langflow/components/**/*.py : Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.428Z
Learning: Applies to src/backend/base/langflow/components/**/__init__.py : Update __init__.py with alphabetical imports when adding new components
🧬 Code Graph Analysis (1)
src/backend/base/langflow/base/tools/run_flow.py (1)
src/backend/base/langflow/template/field/base.py (1)
  • Output (181-257)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Run Ruff Check and Format
  • GitHub Check: Update Starter Projects
  • GitHub Check: Ruff Style Check (3.13)
🔇 Additional comments (1)
src/backend/base/langflow/base/tools/run_flow.py (1)

55-55: LGTM! Consistent addition of group_outputs parameter.

The addition of group_outputs=True to both output definitions aligns with the PR objectives to enable better grouping and organization of flow outputs.

Also applies to: 63-63

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jul 1, 2025
@carlosrcoelho carlosrcoelho added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 514b312 Jul 1, 2025
35 of 36 checks passed
@carlosrcoelho carlosrcoelho deleted the fix/run_flow_outputs branch July 1, 2025 19:07
lucaseduoli added a commit that referenced this pull request Jul 1, 2025
Changed run flow to not group outputs
ogabrielluiz pushed a commit that referenced this pull request Jul 2, 2025
Changed run flow to not group outputs
jordanrfrazier pushed a commit that referenced this pull request Jul 3, 2025
Changed run flow to not group outputs
ogabrielluiz pushed a commit that referenced this pull request Jul 3, 2025
Changed run flow to not group outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants