Skip to content

fix: make MCP naming changes, change actions to tools#8860

Merged
lucaseduoli merged 6 commits into
mainfrom
fix/mcp_naming_changes
Jul 3, 2025
Merged

fix: make MCP naming changes, change actions to tools#8860
lucaseduoli merged 6 commits into
mainfrom
fix/mcp_naming_changes

Conversation

@lucaseduoli
Copy link
Copy Markdown
Collaborator

@lucaseduoli lucaseduoli commented Jul 3, 2025

This pull request focuses on renaming terminology across the frontend codebase to improve clarity and consistency. Specifically, it replaces references to "actions" with "tools" and updates related labels, descriptions, and test cases accordingly. The changes span multiple files and components, ensuring the new terminology is consistently applied throughout the application.

Terminology Updates:

  • Component and UI Updates:

    • Updated descriptions, placeholders, and labels in MCPServerNotice, McpComponent, ToolsTable, and McpServerTab components to replace "actions" with "tools." For example, "Search actions..." was changed to "Search tools..." and "Flows/Actions" was changed to "Flows/Tools." ([[1]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-f61b943ddbd5597b737df702e9dfa7cb61a4f61ff75c9a5d1c21346e392f182dL27-R27), [[2]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-6627057181c3970ed9c9daea69fa855a4915363c9297f365fccded5c744c5e27L34-R35), [[3]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-74c8a3a7d322d9e3c2682246b095581a079f097b77acf319fd19a7922a39c7baL165-R165), [[4]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-74c8a3a7d322d9e3c2682246b095581a079f097b77acf319fd19a7922a39c7baL266-R266), [[5]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-da4edd139a58d412a5bba68a4e4e84c77cf40f53711bceee9c9a12da4ea2eda8L256-R257), [[6]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-da4edd139a58d412a5bba68a4e4e84c77cf40f53711bceee9c9a12da4ea2eda8L272-R276))
  • Settings Page Updates:

    • Renamed "MCP Connections" to "MCP Servers" in the Settings page and updated related labels and descriptions. For example, "Servers" was changed to "Added MCP Servers." ([[1]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-71d4eb4d8471e6b2c846279e40537123edcd7c0e0cac0c39bb6bbcbf16391ce3L42-R42), [[2]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-a4b5b22b3fc381cf0106e514b25841e55c25b132acca137a25bdc0215eb243c3L64-R64), [[3]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-a4b5b22b3fc381cf0106e514b25841e55c25b132acca137a25bdc0215eb243c3L95-R95))
  • Modal Updates:

    • Adjusted text in the AddMcpServerModal to reflect the change from "connections" to "servers." ([src/frontend/src/modals/addMcpServerModal/index.tsxL255-R255](https://github.com/langflow-ai/langflow/pull/8860/files#diff-2761edaffa0fb75a00335954fd6059dd4c93c3032fc2aa7282a472acdd59968dL255-R255))
  • Test Updates:

    • Updated test cases to align with the new terminology, ensuring references to "actions" are replaced with "tools" in selectors, labels, and assertions. For example, "user should be able to manage MCP server actions and configuration" was changed to "user should be able to manage MCP server tools and configuration." ([[1]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-12076cff30d0cc193e72edab3d5f11b01ed45e94e88ede30bbc3ae7267450665L43-R43), [[2]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-7be38a6d14c366a786e62666ed82fb46f758a4d65b76f8c486a56eb90b700e39L6-R6), [[3]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-7be38a6d14c366a786e62666ed82fb46f758a4d65b76f8c486a56eb90b700e39L50-R57), [[4]](https://github.com/langflow-ai/langflow/pull/8860/files#diff-37d0e42832061615b47a8d9aac2a99d55e565969f0e0e9311e1e536152013f9aL108-R112))

Summary by CodeRabbit

  • Style

    • Updated all user interface text to replace references to "actions" with "tools" and "MCP Connections" with "MCP Servers" for improved clarity and consistency across the application.
  • Tests

    • Adjusted test cases to align with the new terminology, ensuring test steps and validations now reference "tools" and "MCP Servers" where appropriate.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 3, 2025

Walkthrough

This update standardizes terminology across the frontend, replacing "action(s)" and "connection(s)" with "tool(s)" and "server(s)" in user-facing labels, tooltips, and test descriptions. The changes affect UI components, modal dialogs, server lists, and automated tests, with no modifications to logic, control flow, or exported entity signatures.

Changes

File(s) Change Summary
.../core/folderSidebarComponent/.../mcp-server-notice.tsx Replaced "actions" with "tools" in a descriptive paragraph.
.../core/parameterRenderComponent/components/mcpComponent/index.tsx Updated UI text: "No actions found" → "No tools found"; "action(s)" → "tool(s)" in server option descriptions.
.../modals/addMcpServerModal/index.tsx Changed "Manage added connections" to "Manage added servers" in a span element.
.../modals/toolsModal/components/toolsTable/index.tsx Replaced "action(s)" with "tool(s)" in column headers, placeholders, labels, and helper texts.
.../pages/MainPage/pages/homePage/components/McpServerTab.tsx Updated multiple UI texts and tooltips: "Actions" → "Tools" for MCP Server flows.
.../pages/SettingsPage/index.tsx Renamed sidebar navigation item: "MCP Connections" → "MCP Servers".
.../pages/SettingsPage/pages/MCPServersPage/index.tsx Changed titles/labels: "MCP Connections" → "MCP Servers"; "actions" → "tools" in server list descriptions.
tests/extended/features/edit-tools.spec.ts Changed test selector text from "actions" to "tools".
tests/extended/features/mcp-server-tab.spec.ts Updated test titles and assertions: "Actions" → "Tools" in all references.
tests/extended/features/mcp-server.spec.ts Updated navigation selectors: "MCP Connections" → "MCP Servers".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant MCPServer

    User->>UI: Navigates to MCP Servers
    UI->>MCPServer: Fetches list of servers
    MCPServer-->>UI: Returns server data (tools count, etc.)
    UI->>User: Displays "MCP Servers" and "tools" labels
    User->>UI: Interacts with tool management (search, edit, etc.)
    UI->>MCPServer: Sends tool-related requests
    MCPServer-->>UI: Responds with tool data
    UI->>User: Updates tool-related UI elements
Loading

Possibly related PRs

Suggested labels

bug, size:M, lgtm

Suggested reviewers

  • deon-sanchez
  • Cristhianzl
  • mfortman11
  • edwinjosechittilappilly

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1ae5e4 and 49765bb.

📒 Files selected for processing (10)
  • src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx (1 hunks)
  • src/frontend/src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx (1 hunks)
  • src/frontend/src/modals/addMcpServerModal/index.tsx (1 hunks)
  • src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx (6 hunks)
  • src/frontend/src/pages/MainPage/pages/homePage/components/McpServerTab.tsx (3 hunks)
  • src/frontend/src/pages/SettingsPage/index.tsx (1 hunks)
  • src/frontend/src/pages/SettingsPage/pages/MCPServersPage/index.tsx (3 hunks)
  • src/frontend/tests/extended/features/edit-tools.spec.ts (1 hunks)
  • src/frontend/tests/extended/features/mcp-server-tab.spec.ts (2 hunks)
  • src/frontend/tests/extended/features/mcp-server.spec.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
`src/frontend/**/*.{ts,tsx}`: Use React 18 with TypeScript for all UI components and frontend logic.

src/frontend/**/*.{ts,tsx}: Use React 18 with TypeScript for all UI components and frontend logic.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)

List of files the instruction was applied to:

  • src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx
  • src/frontend/src/pages/SettingsPage/index.tsx
  • src/frontend/src/modals/addMcpServerModal/index.tsx
  • src/frontend/tests/extended/features/edit-tools.spec.ts
  • src/frontend/src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx
  • src/frontend/src/pages/MainPage/pages/homePage/components/McpServerTab.tsx
  • src/frontend/tests/extended/features/mcp-server-tab.spec.ts
  • src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx
  • src/frontend/tests/extended/features/mcp-server.spec.ts
  • src/frontend/src/pages/SettingsPage/pages/MCPServersPage/index.tsx
`src/frontend/**/*.{ts,tsx,js,jsx,css,scss}`: Use Tailwind CSS for styling all frontend components.

src/frontend/**/*.{ts,tsx,js,jsx,css,scss}: Use Tailwind CSS for styling all frontend components.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)

List of files the instruction was applied to:

  • src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx
  • src/frontend/src/pages/SettingsPage/index.tsx
  • src/frontend/src/modals/addMcpServerModal/index.tsx
  • src/frontend/tests/extended/features/edit-tools.spec.ts
  • src/frontend/src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx
  • src/frontend/src/pages/MainPage/pages/homePage/components/McpServerTab.tsx
  • src/frontend/tests/extended/features/mcp-server-tab.spec.ts
  • src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx
  • src/frontend/tests/extended/features/mcp-server.spec.ts
  • src/frontend/src/pages/SettingsPage/pages/MCPServersPage/index.tsx
`src/frontend/src/components/**/*.{ts,tsx}`: All components must be styled using Tailwind CSS utility classes.

src/frontend/src/components/**/*.{ts,tsx}: All components must be styled using Tailwind CSS utility classes.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)

List of files the instruction was applied to:

  • src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx
  • src/frontend/src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx
`src/frontend/src/{components,hooks}/**/*.{ts,tsx}`: Implement dark mode support in components and hooks where needed.

src/frontend/src/{components,hooks}/**/*.{ts,tsx}: Implement dark mode support in components and hooks where needed.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)

List of files the instruction was applied to:

  • src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx
  • src/frontend/src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx
`{src/backend/tests/**/*.py,src/frontend/**/*.test.{ts,tsx,js,jsx},src/frontend/...

{src/backend/tests/**/*.py,src/frontend/**/*.test.{ts,tsx,js,jsx},src/frontend/**/*.spec.{ts,tsx,js,jsx},tests/**/*.py}: Each test should have a clear docstring explaining its purpose.
Complex test setups should be commented, and mock usage should be documented within the test code.
Expected behaviors should be explicitly stated in test docstrings or comments.
Create comprehensive unit tests for all new components.
Test both sync and async code paths in components.
Mock external dependencies appropriately in tests.
Test error handling and edge cases in components.
Validate input/output behavior in tests.
Test component initialization and configuration.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/testing.mdc)

List of files the instruction was applied to:

  • src/frontend/tests/extended/features/edit-tools.spec.ts
  • src/frontend/tests/extended/features/mcp-server-tab.spec.ts
  • src/frontend/tests/extended/features/mcp-server.spec.ts
`src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx}`: Frontend test files should be ...

src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx}: Frontend test files should be named with '.test.' or '.spec.' before the extension (e.g., 'Component.test.tsx', 'Component.spec.js').
Frontend tests should cover both sync and async code paths, including error handling and edge cases.
Frontend tests should mock external dependencies and APIs appropriately.
Frontend tests should validate input/output behavior and component state changes.
Frontend tests should be well-documented with clear descriptions of test purpose and expected behavior.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/testing.mdc)

List of files the instruction was applied to:

  • src/frontend/tests/extended/features/edit-tools.spec.ts
  • src/frontend/tests/extended/features/mcp-server-tab.spec.ts
  • src/frontend/tests/extended/features/mcp-server.spec.ts
🧠 Learnings (8)
📓 Common learnings
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.667Z
Learning: Applies to docs/docs/**/*.{md,mdx} : Use consistent terminology: always capitalize 'Langflow', 'Component', and 'Flow' when referring to Langflow concepts; always uppercase 'API' and 'JSON'.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: When implementing a new component icon in Langflow, ensure the icon name is clear, recognizable, and used consistently across both backend (Python 'icon' attribute) and frontend (React/TypeScript mapping).
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-23T12:46:29.953Z
Learning: All terminology such as 'Langflow', 'Component', 'Flow', 'API', and 'JSON' must be capitalized or uppercased as specified in the terminology section.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-30T14:40:50.836Z
Learning: Use clear, recognizable, and consistent icon names for both backend and frontend (e.g., 'AstraDB', 'Postgres', 'OpenAI').
src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx (5)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-23T12:46:42.048Z
Learning: Custom React Flow node types should be implemented as memoized components, using Handle components for connection points and supporting optional icons and labels.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: When implementing a new component icon in Langflow, ensure the icon name is clear, recognizable, and used consistently across both backend (Python 'icon' attribute) and frontend (React/TypeScript mapping).
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/components/**/*FlowGraph.tsx : Use React Flow for flow graph visualization components.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-23T12:46:29.953Z
Learning: All terminology such as 'Langflow', 'Component', 'Flow', 'API', and 'JSON' must be capitalized or uppercased as specified in the terminology section.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.667Z
Learning: Applies to docs/docs/**/*.{md,mdx} : Use consistent terminology: always capitalize 'Langflow', 'Component', and 'Flow' when referring to Langflow concepts; always uppercase 'API' and 'JSON'.
src/frontend/src/pages/SettingsPage/index.tsx (2)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.667Z
Learning: Applies to docs/sidebars.js : Sidebar navigation must be configured and updated in 'docs/sidebars.js' to reflect the current documentation structure.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.667Z
Learning: Applies to docs/docusaurus.config.js : Site configuration, including navbar, title, and theme settings, must be managed in 'docs/docusaurus.config.js'.
src/frontend/tests/extended/features/edit-tools.spec.ts (9)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should validate input/output behavior and component state changes.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should cover both sync and async code paths, including error handling and edge cases.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to {src/backend/tests/**/*.py,src/frontend/**/*.test.{ts,tsx,js,jsx},src/frontend/**/*.spec.{ts,tsx,js,jsx},tests/**/*.py} : Test both sync and async code paths in components.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should be well-documented with clear descriptions of test purpose and expected behavior.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/**/__tests__/**/*.{test,spec}.{ts,tsx} : Integration tests must be written for page-level components and flows.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should mock external dependencies and APIs appropriately.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend test files should be named with '.test.' or '.spec.' before the extension (e.g., 'Component.test.tsx', 'Component.spec.js').
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/**/__tests__/**/*.test.{ts,tsx} : All frontend components must have associated tests using React Testing Library.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to {src/backend/tests/**/*.py,src/frontend/**/*.test.{ts,tsx,js,jsx},src/frontend/**/*.spec.{ts,tsx,js,jsx},tests/**/*.py} : Validate input/output behavior in tests.
src/frontend/src/pages/MainPage/pages/homePage/components/McpServerTab.tsx (5)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.667Z
Learning: Applies to docs/docs/**/*.{md,mdx} : Use consistent terminology: always capitalize 'Langflow', 'Component', and 'Flow' when referring to Langflow concepts; always uppercase 'API' and 'JSON'.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-23T12:46:42.048Z
Learning: Custom React Flow node types should be implemented as memoized components, using Handle components for connection points and supporting optional icons and labels.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/components/**/*FlowGraph.tsx : Use React Flow for flow graph visualization components.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: When implementing a new component icon in Langflow, ensure the icon name is clear, recognizable, and used consistently across both backend (Python 'icon' attribute) and frontend (React/TypeScript mapping).
Learnt from: dolfim-ibm
PR: langflow-ai/langflow#8394
File: src/frontend/src/icons/Docling/index.tsx:4-6
Timestamp: 2025-06-16T11:14:04.200Z
Learning: The Langflow codebase consistently uses `React.PropsWithChildren<{}>` as the prop type for all icon components using forwardRef, rather than `React.SVGProps<SVGSVGElement>`. This is an established pattern across hundreds of icon files in src/frontend/src/icons/.
src/frontend/tests/extended/features/mcp-server-tab.spec.ts (4)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should be well-documented with clear descriptions of test purpose and expected behavior.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should validate input/output behavior and component state changes.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/**/__tests__/**/*.{test,spec}.{ts,tsx} : Integration tests must be written for page-level components and flows.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-23T12:46:42.048Z
Learning: Frontend tests should be written using @testing-library/react, with both component and integration tests verifying rendering, user interaction, and data loading.
src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx (2)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/{components,hooks}/**/*.{ts,tsx} : Implement dark mode support in components and hooks where needed.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/**/*.{ts,tsx} : Use React 18 with TypeScript for all UI components and frontend logic.
src/frontend/tests/extended/features/mcp-server.spec.ts (7)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should validate input/output behavior and component state changes.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should be well-documented with clear descriptions of test purpose and expected behavior.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-30T14:40:29.494Z
Learning: Applies to src/frontend/src/**/__tests__/**/*.{test,spec}.{ts,tsx} : Integration tests must be written for page-level components and flows.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend test files should be named with '.test.' or '.spec.' before the extension (e.g., 'Component.test.tsx', 'Component.spec.js').
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should mock external dependencies and APIs appropriately.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to src/frontend/**/*.@(test|spec).{ts,tsx,js,jsx} : Frontend tests should cover both sync and async code paths, including error handling and edge cases.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-06-30T14:41:58.837Z
Learning: Applies to {src/backend/tests/**/*.py,src/frontend/**/*.test.{ts,tsx,js,jsx},src/frontend/**/*.spec.{ts,tsx,js,jsx},tests/**/*.py} : Test both sync and async code paths in components.
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: autofix
🔇 Additional comments (23)
src/frontend/src/pages/SettingsPage/index.tsx (1)

42-42: LGTM! Consistent terminology update.

The sidebar navigation title change from "MCP Connections" to "MCP Servers" aligns with the PR objective to standardize terminology across the frontend. The change maintains all existing functionality while improving consistency.

src/frontend/src/modals/addMcpServerModal/index.tsx (1)

255-255: LGTM! Consistent terminology update.

The text change from "connections" to "servers" aligns with the standardized terminology and maintains clear user guidance for managing MCP servers.

src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/mcp-server-notice.tsx (1)

27-27: LGTM! Consistent terminology update.

The text change from "actions" to "tools" aligns with the standardized terminology and better reflects how flows are exposed to MCP clients.

src/frontend/tests/extended/features/edit-tools.spec.ts (1)

43-43: LGTM! Necessary test update to match UI changes.

The test selector update from "actions" to "tools" is required to maintain test functionality and aligns with the UI terminology changes.

src/frontend/src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx (1)

34-35: LGTM! Consistent terminology updates with proper grammar.

The text changes from "actions" to "tools" align with the standardized terminology while maintaining proper singular/plural handling in the tool count display.

src/frontend/tests/extended/features/mcp-server.spec.ts (1)

108-112: LGTM! Test selectors correctly updated to match UI changes.

The test selectors have been properly updated from "MCP Connections" to "MCP Servers" to align with the sidebar navigation label changes. The test logic remains unchanged, ensuring continued test coverage.

src/frontend/src/pages/MainPage/pages/homePage/components/McpServerTab.tsx (4)

256-257: Excellent terminology update for clarity.

The description text has been appropriately updated from "Actions" to "Tools" to better describe the MCP server functionality and improve user understanding.


272-272: Tooltip content appropriately updated.

The tooltip text correctly reflects the new "Tools" terminology while maintaining the helpful explanatory context.


276-276: Label text consistently updated.

The "Flows/Tools" label properly reflects the updated terminology and maintains clear user guidance.


288-292: ToolsComponent props correctly updated.

All props have been consistently updated to use "Tools" terminology:

  • title: "MCP Server Tools"
  • description: "Select tools to add to this server"
  • button_description: "Edit Tools"

The updates maintain proper component functionality while improving terminological consistency.

src/frontend/tests/extended/features/mcp-server-tab.spec.ts (4)

6-6: Test title correctly updated to reflect new terminology.

The test description has been appropriately updated from "actions" to "tools" to match the UI terminology changes while maintaining clear test intent.


50-50: Test assertion updated to match UI label changes.

The expected text assertion correctly reflects the UI change from "Flows/Actions" to "Flows/Tools".


52-52: Comment appropriately updated.

The test comment has been updated to reflect the new button label "Edit Tools" instead of "Edit Actions".


57-57: Modal title assertion correctly updated.

The test expectation for the modal title has been properly updated from "MCP Server Actions" to "MCP Server Tools" to match the UI changes.

src/frontend/src/pages/SettingsPage/pages/MCPServersPage/index.tsx (3)

64-64: Page title appropriately updated for clarity.

The title change from "MCP Connections" to "MCP Servers" better reflects the content and aligns with the consistent terminology updates across the application.


95-95: Label text improved for better clarity.

The change from "Servers" to "Added MCP Servers" provides more descriptive context for users understanding what the list contains.


119-121: Tools count display logic correctly updated.

The conditional logic has been improved to:

  • Show "No tools found" when count is zero (clearer than "0 actions")
  • Use proper singular/plural "tool"/"tools" terminology
  • Maintain the same logic structure while improving user-facing text

The change enhances clarity without affecting functionality.

src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx (6)

165-165: Column header appropriately updated.

The conditional column header correctly uses "Tool" instead of "Action" when isAction is true, maintaining consistency with the terminology updates.


266-266: Search placeholder text correctly updated.

The placeholder text change from "Search actions..." to "Search tools..." improves clarity and aligns with the consistent terminology updates.


303-303: Label text conditionally updated for clarity.

The conditional label {isAction ? "Tool name" : "Name"} correctly applies the new terminology when appropriate while maintaining existing behavior for non-action contexts.


325-325: Description label consistently updated.

The conditional label {isAction ? "Tool description" : "Description"} properly applies the new terminology in the appropriate context.


338-338: Helper text appropriately updated.

The description text correctly references "tool" instead of "action" when in action mode, improving terminology consistency while maintaining helpful context for users.


373-373: Section description consistently updated.

The parameters section description correctly uses "tool" instead of "action", maintaining consistency with the overall terminology updates.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in a Comment
  • Commit Unit Tests in branch fix/mcp_naming_changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jul 3, 2025
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 3, 2025
@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2025
@lucaseduoli lucaseduoli enabled auto-merge July 3, 2025 17:45
@lucaseduoli lucaseduoli added lgtm This PR has been approved by a maintainer and removed lgtm This PR has been approved by a maintainer labels Jul 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 71%
73.58% (117/159) 57.46% (77/134) 59.52% (25/42)

Unit Test Results

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 2.66s ⏱️

@lucaseduoli lucaseduoli added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 180a94a Jul 3, 2025
66 of 67 checks passed
@lucaseduoli lucaseduoli deleted the fix/mcp_naming_changes branch July 3, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants