Fix extra space share button#8896
Closed
rodrigosnader wants to merge 4 commits into
Closed
Conversation
* fix chat image sent * 🐛 (chat-input.tsx): fix issue where files were not being cleared immediately after sending a message 📝 (chat-input.tsx): refactor code to improve readability and maintainability by extracting filesToSend logic into a separate variable * Delete diff_output_ts.txt * ♻️ (chat-input.tsx): refactor code to store and restore files when sending a message to prevent losing files if an error occurs during sending. * ✅ (fileUploadComponent.spec.ts): update timeout values for better test reliability and performance * ✅ (fileUploadComponent.spec.ts): update test assertion to check for the correct attribute value to ensure accurate testing --------- Co-authored-by: Ítalo Johnny <italojohnnydosanjos@gmail.com> Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update modifies file upload handling and asynchronous control flow in the chat input and related UI components. It also adjusts a CSS utility class for button spacing and increases timeouts in a file upload test. No changes were made to exported or public entity declarations except for one interface method signature. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ChatInput
participant FileState
participant sendMessage
User->>ChatInput: Trigger send
ChatInput->>FileState: Store current files
ChatInput->>FileState: Clear files state
ChatInput->>sendMessage: Send message with filesToSend
alt sendMessage fails
ChatInput->>FileState: Restore files state
end
sequenceDiagram
participant User
participant NoInputView
participant sendMessage
User->>NoInputView: Click "Run Flow" button
NoInputView->>sendMessage: Await sendMessage({ repeat: 1 })
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
dosubot
Bot
added
the
size:M
dosubot
Bot
added
size:S
|
|
||
| const buttonVariants = cva( | ||
| "noflow nopan nodelete nodrag inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md text-sm font-medium ring-offset-background transition-colors focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:opacity-70 disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:size-4 [&_svg]:shrink-0", | ||
| "noflow nopan nodelete nodrag inline-flex items-center justify-center gap-1 whitespace-nowrap rounded-md text-sm font-medium ring-offset-background transition-colors focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:opacity-70 disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:size-4 [&_svg]:shrink-0", |
Contributor
There was a problem hiding this comment.
Is it safe to change this for all buttons?
Comment on lines
-326
to
-335
| await page | ||
| .getByTestId("handle-file-shownode-raw content-right") | ||
| .first() | ||
| .click(); | ||
|
|
||
| await page | ||
| .getByTestId("handle-chatoutput-noshownode-inputs-target") | ||
| .first() | ||
| .click(); | ||
|
|
SonicDMG
temporarily deployed
to
fix/button-gap - langflow-manual-install PR #8896
Render
Destroyed
SonicDMG
temporarily deployed
to
fix/button-gap - langflow-manual-install PR #8896
Render
Destroyed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decrease the gap between icon and text in the Share button for visual consistency with the Playground button.