feat: Add SambaNova Embeddings#8940
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update refactors SambaNova model handling by introducing a metadata-driven approach, adds a new embeddings component for SambaNova, updates the dependency version for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant SambaNovaEmbeddingsComponent
participant SambaNovaCloudEmbeddings
User->>UI: Selects SambaNova Embeddings Component
UI->>SambaNovaEmbeddingsComponent: Provides API key and model name
SambaNovaEmbeddingsComponent->>SambaNovaCloudEmbeddings: Instantiates with API key and model
SambaNovaCloudEmbeddings-->>SambaNovaEmbeddingsComponent: Returns embeddings instance or error
SambaNovaEmbeddingsComponent-->>UI: Outputs embeddings or error message
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
Bot
added
size:L
github-actions
Bot
added
enhancement
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx (1)
1-11: Add support for light and dark mode using theisdarkprop.According to the coding guidelines, custom SVG icon components must support both light and dark mode by using the
isdarkprop. The current implementation uses hardcoded colors that don't adapt to the theme.-const SvgSambaNovaLogo = ({ ...props }) => ( +const SvgSambaNovaLogo = ({ isdark, ...props }) => ( <svg xmlns="http://www.w3.org/2000/svg" aria-label="sambanova logo" role="img" className="fill-foreground" fill="none" viewBox="0 0 52.416 46.20814479638009" - style="max-height: 500px" + style={{ maxHeight: '500px' }} {...props} >Additionally, update the fill colors throughout the SVG to use conditional logic based on the
isdarkprop instead of hardcoded values.
🧹 Nitpick comments (3)
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx (1)
49-191: Consider theme-aware color handling for brand colors.The brand-specific colors (e.g.,
#250E36,#412AA0) may need adjustment for dark mode readability. Consider providing theme-appropriate variants or using CSS custom properties.<path - fill="#250E36" + fill={isdark ? "#3a1a4a" : "#250E36"} d="M46.1032 36.2716C42.7262 39.6641..." />This ensures the brand colors maintain appropriate contrast in both light and dark themes.
src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (2)
8-8: Remove unused constant.The
HTTP_STATUS_OKconstant is defined but never used in the component.-HTTP_STATUS_OK = 200 -
36-50: Enhance error handling and logging.Consider adding more specific error handling and logging for better debugging experience.
+import logging + +logger = logging.getLogger(__name__) + def build_embeddings(self) -> Embeddings: - embeddings = None api_key = SecretStr(self.api_key).get_secret_value() + logger.debug(f"Building SambaNova embeddings with model: {self.model_name}") + try: embeddings = SambaNovaCloudEmbeddings( sambanova_api_key=api_key, model=self.model_name, ) - except Exception as e: + except Exception as e: + logger.error(f"Failed to create SambaNova embeddings: {e}") msg = ( "Unable to create SambaNova Embeddings. " "Please verify the API key and model parameters, and try again." ) raise ValueError(msg) from e return embeddings
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/frontend/src/icons/SambaNova/SambaNovaLogo.svgis excluded by!**/*.svguv.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
pyproject.toml(1 hunks)src/backend/base/langflow/base/models/sambanova_constants.py(1 hunks)src/backend/base/langflow/components/sambanova/__init__.py(1 hunks)src/backend/base/langflow/components/sambanova/sambanova_embeddings.py(1 hunks)src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
`{uv.lock,pyproject.toml}`: Use uv (>=0.4) as the Python package manager for dependency management
{uv.lock,pyproject.toml}: Use uv (>=0.4) as the Python package manager for dependency management
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
pyproject.toml
`src/backend/base/langflow/components/**/*.py`: Add new backend components to th...
src/backend/base/langflow/components/**/*.py: Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
Implement async component methods using async def and await for asynchronous operations
Use asyncio.create_task for background work in async components and ensure proper cleanup on cancellation
Use asyncio.Queue for non-blocking queue operations in async components and handle timeouts appropriately
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.pysrc/backend/base/langflow/components/sambanova/sambanova_embeddings.py
`src/backend/base/langflow/components/**/__init__.py`: Update __init__.py with alphabetical imports when adding new components
src/backend/base/langflow/components/**/__init__.py: Update init.py with alphabetical imports when adding new components
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.py
`src/backend/**/*.py`: Run make format_backend to format Python code early and often Run make lint to check for linting issues in backend Python code
src/backend/**/*.py: Run make format_backend to format Python code early and often
Run make lint to check for linting issues in backend Python code
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.pysrc/backend/base/langflow/components/sambanova/sambanova_embeddings.pysrc/backend/base/langflow/base/models/sambanova_constants.py
`src/backend/**/components/**/*.py`: In your Python component class, set the `icon` attribute to a string matching the frontend icon mapping exactly (case-sensitive).
src/backend/**/components/**/*.py: In your Python component class, set theiconattribute to a string matching the frontend icon mapping exactly (case-sensitive).
📄 Source: CodeRabbit Inference Engine (.cursor/rules/icons.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.pysrc/backend/base/langflow/components/sambanova/sambanova_embeddings.py
`src/frontend/**/*.{ts,tsx,js,jsx,css,scss}`: Use Tailwind CSS for styling all frontend components.
src/frontend/**/*.{ts,tsx,js,jsx,css,scss}: Use Tailwind CSS for styling all frontend components.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
`src/frontend/src/icons/**/*.{ts,tsx,js,jsx}`: Use Lucide React for icons in frontend components.
src/frontend/src/icons/**/*.{ts,tsx,js,jsx}: Use Lucide React for icons in frontend components.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
`src/frontend/src/icons/*/*`: Create a new directory for your icon in `src/front...
src/frontend/src/icons/*/*: Create a new directory for your icon insrc/frontend/src/icons/YourIconName/and add your SVG as a React component (e.g.,YourIconName.jsx) that uses theisdarkprop to support both light and dark mode.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/icons.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
`src/frontend/src/icons/*/*.jsx`: Always support both light and dark mode for custom icons by using the `isdark` prop in your SVG component.
src/frontend/src/icons/*/*.jsx: Always support both light and dark mode for custom icons by using theisdarkprop in your SVG component.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/icons.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
🧠 Learnings (5)
📓 Common learnings
Learnt from: ogabrielluiz
PR: langflow-ai/langflow#0
File: :0-0
Timestamp: 2025-06-26T19:43:18.260Z
Learning: In langflow custom components, the `module_name` parameter is now propagated through template building functions to add module metadata and code hashes to frontend nodes for better component tracking and debugging.
src/backend/base/langflow/components/sambanova/__init__.py (3)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/__init__.py : Update __init__.py with alphabetical imports when adding new components
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/*.py : Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
Learnt from: ogabrielluiz
PR: langflow-ai/langflow#0
File: :0-0
Timestamp: 2025-06-26T19:43:18.260Z
Learning: In langflow custom components, the `module_name` parameter is now propagated through template building functions to add module metadata and code hashes to frontend nodes for better component tracking and debugging.
src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (2)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/*.py : Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
Learnt from: ogabrielluiz
PR: langflow-ai/langflow#0
File: :0-0
Timestamp: 2025-06-26T19:43:18.260Z
Learning: In langflow custom components, the `module_name` parameter is now propagated through template building functions to add module metadata and code hashes to frontend nodes for better component tracking and debugging.
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx (4)
Learnt from: dolfim-ibm
PR: langflow-ai/langflow#8394
File: src/frontend/src/icons/Docling/index.tsx:4-6
Timestamp: 2025-06-16T11:14:04.200Z
Learning: The Langflow codebase consistently uses `React.PropsWithChildren<{}>` as the prop type for all icon components using forwardRef, rather than `React.SVGProps<SVGSVGElement>`. This is an established pattern across hundreds of icon files in src/frontend/src/icons/.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-30T14:40:50.846Z
Learning: Applies to src/frontend/src/icons/*/* : Create a new directory for your icon in `src/frontend/src/icons/YourIconName/` and add your SVG as a React component (e.g., `YourIconName.jsx`) that uses the `isdark` prop to support both light and dark mode.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: Custom SVG icon components in React should always support both light and dark mode by accepting an 'isdark' prop and adjusting colors accordingly.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-30T14:40:50.846Z
Learning: Applies to src/frontend/src/icons/*/*.jsx : Always support both light and dark mode for custom icons by using the `isdark` prop in your SVG component.
src/backend/base/langflow/base/models/sambanova_constants.py (1)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/services/database/models/**/*.py : Place database models in src/backend/base/langflow/services/database/models/ and its subdirectories
🧬 Code Graph Analysis (2)
src/backend/base/langflow/components/sambanova/__init__.py (1)
src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (1)
SambaNovaEmbeddingsComponent(11-50)
src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (2)
src/backend/base/langflow/base/models/model.py (1)
LCModelComponent(25-375)src/backend/base/langflow/inputs/inputs.py (2)
DropdownInput(467-491)SecretStrInput(285-340)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: autofix
- GitHub Check: Ruff Style Check (3.13)
- GitHub Check: Update Starter Projects
- GitHub Check: Run Ruff Check and Format
🔇 Additional comments (3)
pyproject.toml (1)
97-97: langchain-sambanova 0.1.5 verified on PyPI with no known security advisories
- Confirmed version 0.1.5 exists on PyPI
- No security vulnerabilities found in the first 10 reported advisories
You can safely proceed with this dependency update.
src/backend/base/langflow/components/sambanova/__init__.py (1)
1-4: LGTM! Proper alphabetical imports and exports.The imports and exports follow the coding guidelines correctly with alphabetical ordering and proper all list maintenance.
src/backend/base/langflow/base/models/sambanova_constants.py (1)
1-56: Excellent restructuring of model metadata management.The transition from a flat list to structured metadata using
create_model_metadatais well-designed. This provides:
- Single source of truth: All model information centralized in
SAMBANOVA_MODELS_DETAILED- Flexible filtering: Easy to derive different model lists for various use cases
- Rich metadata: Support for preview status, tool calling capabilities, and deprecation
- Maintainability: Easier to add new models and update existing ones
The filtered lists (
SAMBANOVA_PRODUCTION_MODELS,SAMBANOVA_PREVIEW_MODELS,TOOL_CALLING_UNSUPPORTED_SAMBANOVA_MODELS) provide clear categorization for different component needs.
github-actions
Bot
added
enhancement
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx (1)
1-11: Add dark mode support using theisdarkprop.According to the coding guidelines, custom icons must support both light and dark modes using the
isdarkprop.Update the component signature and use the prop:
-const SvgSambaNovaLogo = ({ ...props }) => ( +const SvgSambaNovaLogo = ({ isdark, ...props }) => (Consider using the
isdarkprop to adjust colors for dark mode compatibility.
🧹 Nitpick comments (3)
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx (1)
8-8: Consider simplifying the viewBox precision.The viewBox has an unnecessarily precise decimal value that could be rounded for better maintainability.
- viewBox="0 0 52.416 46.20814479638009" + viewBox="0 0 52.416 46.208"src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (2)
8-8: Remove unused constant.The
HTTP_STATUS_OKconstant is defined but never used in the code.-HTTP_STATUS_OK = 200 - -
37-37: Remove unnecessary variable initialization.The
embeddingsvariable doesn't need to be initialized toNonesince it's assigned in the try block.- embeddings = None api_key = SecretStr(self.api_key).get_secret_value() try:
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/frontend/src/icons/SambaNova/SambaNovaLogo.svgis excluded by!**/*.svguv.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
pyproject.toml(1 hunks)src/backend/base/langflow/base/models/sambanova_constants.py(1 hunks)src/backend/base/langflow/components/sambanova/__init__.py(1 hunks)src/backend/base/langflow/components/sambanova/sambanova_embeddings.py(1 hunks)src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
`{uv.lock,pyproject.toml}`: Use uv (>=0.4) as the Python package manager for dependency management
{uv.lock,pyproject.toml}: Use uv (>=0.4) as the Python package manager for dependency management
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
pyproject.toml
`src/backend/base/langflow/components/**/*.py`: Add new backend components to th...
src/backend/base/langflow/components/**/*.py: Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
Implement async component methods using async def and await for asynchronous operations
Use asyncio.create_task for background work in async components and ensure proper cleanup on cancellation
Use asyncio.Queue for non-blocking queue operations in async components and handle timeouts appropriately
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.pysrc/backend/base/langflow/components/sambanova/sambanova_embeddings.py
`src/backend/base/langflow/components/**/__init__.py`: Update __init__.py with alphabetical imports when adding new components
src/backend/base/langflow/components/**/__init__.py: Update init.py with alphabetical imports when adding new components
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.py
`src/backend/**/*.py`: Run make format_backend to format Python code early and often Run make lint to check for linting issues in backend Python code
src/backend/**/*.py: Run make format_backend to format Python code early and often
Run make lint to check for linting issues in backend Python code
📄 Source: CodeRabbit Inference Engine (.cursor/rules/backend_development.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.pysrc/backend/base/langflow/components/sambanova/sambanova_embeddings.pysrc/backend/base/langflow/base/models/sambanova_constants.py
`src/backend/**/components/**/*.py`: In your Python component class, set the `icon` attribute to a string matching the frontend icon mapping exactly (case-sensitive).
src/backend/**/components/**/*.py: In your Python component class, set theiconattribute to a string matching the frontend icon mapping exactly (case-sensitive).
📄 Source: CodeRabbit Inference Engine (.cursor/rules/icons.mdc)
List of files the instruction was applied to:
src/backend/base/langflow/components/sambanova/__init__.pysrc/backend/base/langflow/components/sambanova/sambanova_embeddings.py
`src/frontend/**/*.{ts,tsx,js,jsx,css,scss}`: Use Tailwind CSS for styling all frontend components.
src/frontend/**/*.{ts,tsx,js,jsx,css,scss}: Use Tailwind CSS for styling all frontend components.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
`src/frontend/src/icons/**/*.{ts,tsx,js,jsx}`: Use Lucide React for icons in frontend components.
src/frontend/src/icons/**/*.{ts,tsx,js,jsx}: Use Lucide React for icons in frontend components.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/frontend_development.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
`src/frontend/src/icons/*/*`: Create a new directory for your icon in `src/front...
src/frontend/src/icons/*/*: Create a new directory for your icon insrc/frontend/src/icons/YourIconName/and add your SVG as a React component (e.g.,YourIconName.jsx) that uses theisdarkprop to support both light and dark mode.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/icons.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
`src/frontend/src/icons/*/*.jsx`: Always support both light and dark mode for custom icons by using the `isdark` prop in your SVG component.
src/frontend/src/icons/*/*.jsx: Always support both light and dark mode for custom icons by using theisdarkprop in your SVG component.
📄 Source: CodeRabbit Inference Engine (.cursor/rules/icons.mdc)
List of files the instruction was applied to:
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx
🧠 Learnings (5)
📓 Common learnings
Learnt from: ogabrielluiz
PR: langflow-ai/langflow#0
File: :0-0
Timestamp: 2025-06-26T19:43:18.260Z
Learning: In langflow custom components, the `module_name` parameter is now propagated through template building functions to add module metadata and code hashes to frontend nodes for better component tracking and debugging.
src/backend/base/langflow/components/sambanova/__init__.py (2)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/__init__.py : Update __init__.py with alphabetical imports when adding new components
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/*.py : Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (4)
Learnt from: ogabrielluiz
PR: langflow-ai/langflow#0
File: :0-0
Timestamp: 2025-06-26T19:43:18.260Z
Learning: In langflow custom components, the `module_name` parameter is now propagated through template building functions to add module metadata and code hashes to frontend nodes for better component tracking and debugging.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/*.py : Add new backend components to the appropriate subdirectory under src/backend/base/langflow/components/
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: When implementing a new component icon in Langflow, ensure the icon name is clear, recognizable, and used consistently across both backend (Python 'icon' attribute) and frontend (React/TypeScript mapping).
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/components/**/__init__.py : Update __init__.py with alphabetical imports when adding new components
src/backend/base/langflow/base/models/sambanova_constants.py (1)
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-06-30T14:39:17.464Z
Learning: Applies to src/backend/base/langflow/services/database/models/**/*.py : Place database models in src/backend/base/langflow/services/database/models/ and its subdirectories
src/frontend/src/icons/SambaNova/SambaNovaLogo.jsx (3)
Learnt from: dolfim-ibm
PR: langflow-ai/langflow#8394
File: src/frontend/src/icons/Docling/index.tsx:4-6
Timestamp: 2025-06-16T11:14:04.200Z
Learning: The Langflow codebase consistently uses `React.PropsWithChildren<{}>` as the prop type for all icon components using forwardRef, rather than `React.SVGProps<SVGSVGElement>`. This is an established pattern across hundreds of icon files in src/frontend/src/icons/.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-30T14:40:50.846Z
Learning: Applies to src/frontend/src/icons/*/* : Create a new directory for your icon in `src/frontend/src/icons/YourIconName/` and add your SVG as a React component (e.g., `YourIconName.jsx`) that uses the `isdark` prop to support both light and dark mode.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-30T14:40:50.846Z
Learning: Applies to src/frontend/src/icons/*/*.jsx : Always support both light and dark mode for custom icons by using the `isdark` prop in your SVG component.
🧬 Code Graph Analysis (1)
src/backend/base/langflow/components/sambanova/__init__.py (1)
src/backend/base/langflow/components/sambanova/sambanova_embeddings.py (1)
SambaNovaEmbeddingsComponent(11-50)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Update Starter Projects
🔇 Additional comments (3)
pyproject.toml (1)
97-97: langchain-sambanova version check completed
- Confirmed that
langchain-sambanova==0.1.5exists on PyPI; the latest release is 0.1.6.- No security advisories are listed on PyPI for this package.
Please consider upgrading to 0.1.6 and cross-check NVD or GitHub Security Advisories for any CVEs before merging.
src/backend/base/langflow/components/sambanova/__init__.py (1)
1-4: LGTM! Imports are correctly organized.The new import and all export follow the alphabetical ordering guideline as required.
src/backend/base/langflow/base/models/sambanova_constants.py (1)
1-56: Excellent refactoring to a metadata-driven approach!This structured approach with
create_model_metadataprovides better maintainability and allows for easy filtering based on model capabilities. The categorization into production, preview, and tool-calling models is well-organized.
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
github-actions
Bot
added
enhancement
|
@edwinjosechittilappilly could you please take a look at this PR adding SambaNova embeddings |
github-actions
Bot
added
enhancement
|
github-actions
Bot
added
enhancement
|
4 participants
Add SambaNova embeddings
Add models metadata
Updata Sambanova icon and docs link
Summary by CodeRabbit
New Features
Refactor
Style
Chores