refactor: Update icon dark mode comparison by mfortman11 · Pull Request #9060 · langflow-ai/langflow

mfortman11 · 2025-07-15T17:24:52Z

The Problem
Since icons are rendered by a memoized component. When a useDarkStore update comes in it does not trigger a rerender.
The current work around was to append a .toString() which creates a new string reference each time and does trigger the rerender.

const isdark = useDarkStore((state) => state.dark).toString();

The Fix
Moving the useDarkStore state to the genericIconComponent and pass it down as a prop.

_This does cause icons that don't have light/dark mode to rerender when changing themes but that change causes so many rerenders already (and seldom happens) the difference is negligible

Summary by CodeRabbit

Refactor
- Standardized the dark mode prop name from isdark to isDark across all icon components for consistency.
- Simplified icon components by removing internal dark mode state handling; icons now expect the isDark prop to be provided externally.
- Updated fill color and style logic in icons to use the boolean isDark prop directly.
Bug Fixes
- Fixed prop casing issues that could affect icon color rendering in dark mode.
Chores
- Improved internal logic for safer dark mode state initialization.

coderabbitai · 2025-07-15T17:25:03Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change standardizes the dark mode prop from isdark to isDark across all icon components, updates their internal logic to use a boolean rather than string-based prop, and removes the usage of the useDarkStore hook from individual icon wrappers. The dark mode state is now expected to be passed externally.

Changes

Files/Groups	Change Summary
`.cursor/rules/icons.mdc`	Documentation updated to use `isDark` prop and clarify dark mode prop handling.
`src/frontend/src/components/common/genericIconComponent/index.tsx`	Now subscribes to `useDarkStore` to pass `isDark` as a boolean prop to icons.
`src/frontend/src/icons/*/index.tsx` (all icon index files)	Removed `useDarkStore` usage; components now simply forward props and ref to SVG components.
`src/frontend/src/icons//.jsx` (all icon SVG files)	Changed prop from `isdark` to `isDark`, removed string-to-boolean conversion, and directly use boolean prop.
`src/frontend/src/icons/Ollama/Ollama.jsx`, `Pinecone/PineconeLogo.jsx`	Refactored to use local `color` variable based on `isDark` boolean.
`src/frontend/src/icons/JigsawStack/JigsawStackIcon.jsx`, `Anthropic/Anthropic.jsx`	Changed to access `isDark` from props object instead of destructuring.
`src/frontend/src/stores/darkStore.ts`	Improved localStorage parsing logic for dark mode state initialization.

Sequence Diagram(s)

sequenceDiagram
    participant ParentComponent
    participant IconComponent
    participant SVGComponent

    ParentComponent->>IconComponent: Render with isDark={isDark}
    IconComponent->>SVGComponent: Forward isDark prop
    SVGComponent->>SVGComponent: Use isDark to set fill/color

Possibly related PRs

feat: Add dark mode support to JigsawStackIcon #9013: Removes useDarkStore and isdark prop from JigsawStackIcon, which directly relates to the standardization and simplification of dark mode prop handling.
feat: add servers persistence to MCP connection component, add MCP connections settings page #8388: Involves MCP component refactoring, which may overlap with icon or component integration changes in this PR.
feat: Add dynamic theming support to WatsonxAI icon #8935: Removes useDarkStore and isdark prop from WatsonxAI icon, closely related to the changes in this PR regarding dark mode handling.

Suggested labels

size:S, lgtm

Suggested reviewers

mfortman11

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch icons-dark-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 7

🔭 Outside diff range comments (1)

src/frontend/src/icons/BW python/index.tsx (1)
1-10: Please update the SVG component to handle a boolean isDark prop (using stringToBool) instead of comparing to the string "true", so it matches the pattern used by other icons.

• File to update:

src/frontend/src/icons/BW python/Python.jsx

• Changes needed:

Import the stringToBool utility.

Replace all props.isDark === "true" checks with stringToBool(props.isDark).

Invert logic for the <rect> fill accordingly (use !stringToBool(props.isDark) for light mode).

Example diff:
--- a/src/frontend/src/icons/BW python/Python.jsx
+++ b/src/frontend/src/icons/BW python/Python.jsx
@@
-import React from "react";
+import React from "react";
+import { stringToBool } from "../../utils";   // adjust path as needed

@@
-        fill={props.isDark === "true" ? "white" : "black"}
+        fill={stringToBool(props.isDark) ? "white" : "black"}
@@
-        fill={props.isDark === "true" ? "white" : "black"}
+        fill={stringToBool(props.isDark) ? "white" : "black"}
@@
-        fill={props.isDark === "true" ? "black" : "white"}
+        fill={stringToBool(props.isDark) ? "black" : "white"}
This ensures consistent boolean-based theming across all icon components.

🧹 Nitpick comments (2)

src/frontend/src/icons/xAI/xAIIcon.jsx (1)
1-1: Remove unused import.

The stringToBool import is no longer used after the refactor. Consider removing it to keep the code clean.
-import { stringToBool } from "@/utils/utils";
src/frontend/src/icons/DeepSeek/index.tsx (1)
1-2: Consider removing unnecessary React import.

The React import is only used for typing. Since you're using forwardRef directly, you could import just the types needed.
-import type React from "react";
-import { forwardRef } from "react";
+import { forwardRef, type PropsWithChildren } from "react";
Then update the type usage:
-  React.PropsWithChildren<Record<string, never>>
+  PropsWithChildren<Record<string, never>>

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1e9594 and 82336ea.

📒 Files selected for processing (44)

.cursor/rules/icons.mdc (4 hunks)
src/frontend/src/components/common/genericIconComponent/index.tsx (3 hunks)
src/frontend/src/icons/AWS/AWS.jsx (1 hunks)
src/frontend/src/icons/AWS/index.tsx (1 hunks)
src/frontend/src/icons/AWSInverted/AWS.jsx (1 hunks)
src/frontend/src/icons/AWSInverted/index.tsx (1 hunks)
src/frontend/src/icons/Anthropic/Anthropic.jsx (1 hunks)
src/frontend/src/icons/Anthropic/index.tsx (1 hunks)
src/frontend/src/icons/AstraDB/AstraDB.jsx (1 hunks)
src/frontend/src/icons/AstraDB/index.tsx (1 hunks)
src/frontend/src/icons/BW python/Python.jsx (1 hunks)
src/frontend/src/icons/BW python/index.tsx (1 hunks)
src/frontend/src/icons/Cleanlab/Cleanlab.jsx (1 hunks)
src/frontend/src/icons/Cleanlab/index.tsx (1 hunks)
src/frontend/src/icons/Composio/composio.jsx (1 hunks)
src/frontend/src/icons/Composio/index.tsx (1 hunks)
src/frontend/src/icons/DeepSeek/DeepSeekIcon.jsx (1 hunks)
src/frontend/src/icons/DeepSeek/index.tsx (1 hunks)
src/frontend/src/icons/HCD/HCD.jsx (1 hunks)
src/frontend/src/icons/HCD/index.tsx (1 hunks)
src/frontend/src/icons/IBMWatsonx/WatsonxAI.jsx (1 hunks)
src/frontend/src/icons/IBMWatsonx/index.tsx (1 hunks)
src/frontend/src/icons/JSicon/JSIcon.jsx (1 hunks)
src/frontend/src/icons/JSicon/index.tsx (1 hunks)
src/frontend/src/icons/JigsawStack/JigsawStackIcon.jsx (2 hunks)
src/frontend/src/icons/JigsawStack/index.tsx (1 hunks)
src/frontend/src/icons/MCP/McpIcon.jsx (1 hunks)
src/frontend/src/icons/MCP/index.tsx (1 hunks)
src/frontend/src/icons/Mem0/SvgMem.jsx (1 hunks)
src/frontend/src/icons/Mem0/index.tsx (1 hunks)
src/frontend/src/icons/Novita/index.tsx (1 hunks)
src/frontend/src/icons/Nvidia/index.tsx (1 hunks)
src/frontend/src/icons/Nvidia/nvidia.jsx (2 hunks)
src/frontend/src/icons/Ollama/Ollama.jsx (1 hunks)
src/frontend/src/icons/Ollama/index.tsx (1 hunks)
src/frontend/src/icons/Pinecone/PineconeLogo.jsx (1 hunks)
src/frontend/src/icons/Pinecone/index.tsx (1 hunks)
src/frontend/src/icons/Twitter X/TwitterX.jsx (1 hunks)
src/frontend/src/icons/Twitter X/index.tsx (1 hunks)
src/frontend/src/icons/Windsurf/Windsurf.jsx (1 hunks)
src/frontend/src/icons/Windsurf/index.tsx (1 hunks)
src/frontend/src/icons/xAI/index.tsx (1 hunks)
src/frontend/src/icons/xAI/xAIIcon.jsx (1 hunks)
src/frontend/src/stores/darkStore.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (9)

src/frontend/**/*.{ts,tsx,js,jsx,css,scss}

Instructions used from: