Skip to content

fix: updated design of info button on files component#9146

Merged
lucaseduoli merged 3 commits into
mainfrom
fix/files_type_design
Jul 23, 2025
Merged

fix: updated design of info button on files component#9146
lucaseduoli merged 3 commits into
mainfrom
fix/files_type_design

Conversation

@lucaseduoli
Copy link
Copy Markdown
Collaborator

@lucaseduoli lucaseduoli commented Jul 23, 2025

This pull request updates the DragFilesComponent in the file manager modal to enhance the user interface and improve clarity. The most important changes involve adding a new icon component for better visual cues, updating styles for consistency, and improving text formatting.

UI Enhancements:

  • Added the ForwardedIconComponent to display an "info" icon next to the "+X more" text, providing a clearer visual indicator for additional file types. (src/frontend/src/modals/fileManagerModal/components/dragFilesComponent/index.tsx, [1] [2]

Style and Text Improvements:

Summary by CodeRabbit

  • Style
    • Improved the display of accepted file types with updated layout and spacing.
    • Added an info icon next to the "+N more" indicator for additional file types.
    • Refined the presentation of the maximum file size label for better clarity.

@lucaseduoli lucaseduoli self-assigned this Jul 23, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 23, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The component responsible for displaying accepted file types in the file manager modal was updated to use a new icon component for the tooltip trigger. The layout of accepted file types and the "max" file size label was adjusted for improved visual structure, without altering any business logic or event handling.

Changes

File(s) Change Summary
src/frontend/src/modals/fileManagerModal/components/dragFilesComponent/index.tsx Updated accepted file types display: used a new icon component, adjusted flex layout, and moved the "max" label

Estimated code review effort

1 (~5 minutes)

Suggested labels

javascript, size:M, lgtm

Suggested reviewers

  • deon-sanchez
  • Cristhianzl
  • mfortman11
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/files_type_design

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added the bug Something isn't working label Jul 23, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jul 23, 2025
@lucaseduoli lucaseduoli enabled auto-merge July 23, 2025 13:30
Copy link
Copy Markdown
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Jul 23, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jul 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 82%
81.44% (373/458) 64.82% (223/344) 67.69% (44/65)

Unit Test Results

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 2.846s ⏱️

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.83%. Comparing base (d59c890) to head (98960cd).
Report is 3 commits behind head on main.

❌ Your project status has failed because the head coverage (51.83%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9146      +/-   ##
==========================================
- Coverage   51.83%   51.83%   -0.01%     
==========================================
  Files         632      632              
  Lines       43362    43361       -1     
  Branches      125      125              
==========================================
- Hits        22478    22476       -2     
- Misses      20834    20835       +1     
  Partials       50       50              
Flag Coverage Δ
frontend 69.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucaseduoli lucaseduoli added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit e6ca374 Jul 23, 2025
58 of 59 checks passed
@lucaseduoli lucaseduoli deleted the fix/files_type_design branch July 23, 2025 18:36
lucaseduoli added a commit that referenced this pull request Jul 24, 2025
* Updated design of info button

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>
2getsandesh pushed a commit to 2getsandesh/langflow-IBM that referenced this pull request Aug 6, 2025
* Updated design of info button

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants