⚡️ Speed up function _classify_dependency by 7,582% in PR #9192 (add-deps-metadata)

[codeflash-ai]

⚡️ This pull request contains optimizations for PR #9192

If you approve this dependent PR, these changes will be merged into the original PR branch add-deps-metadata.

This PR will be automatically closed if the original PR is merged.

---

📄 7,582% (75.82x) speedup for _classify_dependency in src/backend/base/langflow/custom/dependency_analyzer.py

⏱️ Runtime : 4.77 milliseconds → 62.1 microseconds (best of 123 runs)

📝 Explanation and details

Here is a faster version of your _classify_dependency function. The profiling shows that the real bottlenecks are md.distribution(dep.name) and accessing dist.version, both of which trigger expensive package metadata resolution.

Optimizations:

• Use an LRU cache for package version lookup. Since md.distribution does not cache results, this can greatly reduce overhead for repeated package names.
• Only import importlib.metadata module objects once (move md.distribution and exceptions out to top-level).
• If dep.is_local is true or dep.name is falsy, skip lookups immediately.

Notes:

• This keeps function signature and behavior identical.
• Comments are unchanged unless the relevant code changes.

Optimized code.

Why this is faster:

• Repeated queries for the same package name are almost instant due to the LRU cache.
• Fewer redundant imports or lookups.
• No extra overhead unless package version lookup is actually needed.

✅ Correctness verification report:

Test	Status
⏪ Replay Tests	🔘 None Found
⚙️ Existing Unit Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 29 Passed
📊 Tests Coverage	100.0%

🌀 Generated Regression Tests and Runtime

from __future__ import annotations

import importlib.metadata as md
from dataclasses import dataclass
from typing import Optional

# imports
import pytest  # used for our unit tests
from langflow.custom.dependency_analyzer import _classify_dependency


@dataclass(frozen=True)
class DependencyInfo:
    name: Optional[str]
    version: Optional[str]
    is_local: bool
from langflow.custom.dependency_analyzer import _classify_dependency

# unit tests

# ----------- Basic Test Cases -----------

def test_external_dependency_installed():
    # Test with a common installed package (pytest itself)
    dep = DependencyInfo(name="pytest", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_not_installed():
    # Test with a non-existent package
    dep = DependencyInfo(name="nonexistent_package_abcdefg", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_local_dependency():
    # Local dependencies should not be resolved, version remains None
    dep = DependencyInfo(name="my_local_lib", version=None, is_local=True)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_version_preserves_name_and_local():
    # Should preserve name and is_local fields
    dep = DependencyInfo(name="pytest", version="1.2.3", is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_empty_name():
    # Empty name should not attempt to resolve version
    dep = DependencyInfo(name="", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_none_name():
    # None name should not attempt to resolve version
    dep = DependencyInfo(name=None, version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

# ----------- Edge Test Cases -----------

def test_local_dependency_with_none_name():
    # Local dependency with None name should not error
    dep = DependencyInfo(name=None, version=None, is_local=True)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_local_dependency_with_empty_name():
    # Local dependency with empty name should not error
    dep = DependencyInfo(name="", version=None, is_local=True)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_case_sensitivity():
    # Some systems are case-sensitive; test with capitalized package name
    dep = DependencyInfo(name="PyTest", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_special_characters():
    # Unlikely to be a valid package, but should not crash
    dep = DependencyInfo(name="pytest!@#$%", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_long_name():
    # Very long package name, should not crash
    long_name = "a" * 256
    dep = DependencyInfo(name=long_name, version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_unicode_name():
    # Unicode in package name, should not crash
    dep = DependencyInfo(name="pytesté", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_leading_trailing_spaces():
    # Spaces should be preserved, but package won't be found
    dep = DependencyInfo(name=" pytest ", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_dependencyinfo_immutable():
    # Ensure DependencyInfo is immutable (frozen dataclass)
    dep = DependencyInfo(name="pytest", version=None, is_local=True)
    with pytest.raises(Exception):
        dep.name = "foo"

# ----------- Large Scale Test Cases -----------






from __future__ import annotations

import importlib.metadata as md
from dataclasses import dataclass
from typing import Optional

# imports
import pytest  # used for our unit tests
from langflow.custom.dependency_analyzer import _classify_dependency


@dataclass(frozen=True)
class DependencyInfo:
    name: Optional[str]
    version: Optional[str]
    is_local: bool
from langflow.custom.dependency_analyzer import _classify_dependency

# unit tests

# ----------- BASIC TEST CASES ------------

def test_external_dependency_installed_package():
    """Test with a common installed external package (pytest itself)."""
    dep = DependencyInfo(name="pytest", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_not_installed():
    """Test with a non-existent external package name."""
    dep = DependencyInfo(name="definitely_not_installed_package_12345", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_local_dependency_with_name():
    """Test with a local dependency, name given."""
    dep = DependencyInfo(name="my_local_package", version=None, is_local=True)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_local_dependency_no_name():
    """Test with a local dependency, name is None."""
    dep = DependencyInfo(name=None, version=None, is_local=True)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_no_name():
    """Test with an external dependency, name is None."""
    dep = DependencyInfo(name=None, version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

# ----------- EDGE TEST CASES ------------

def test_external_dependency_empty_string_name():
    """Test with external dependency, name is empty string."""
    dep = DependencyInfo(name="", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_local_dependency_empty_string_name():
    """Test with local dependency, name is empty string."""
    dep = DependencyInfo(name="", version=None, is_local=True)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_case_sensitivity():
    """Test with external dependency, name with different case."""
    # 'PyTeSt' should resolve to the same package as 'pytest'
    dep = DependencyInfo(name="PyTeSt", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_dependency_with_existing_version():
    """Test that existing version in DependencyInfo is ignored and replaced."""
    dep = DependencyInfo(name="pytest", version="0.0.1", is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_special_characters():
    """Test with a package name containing special characters (invalid)."""
    dep = DependencyInfo(name="!nv@lid_n@me", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_external_dependency_with_hyphens_and_underscores():
    """Test with a package name that uses hyphens and underscores."""
    # 'importlib_metadata' is installed as 'importlib-metadata'
    dep = DependencyInfo(name="importlib_metadata", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

def test_dependencyinfo_immutability():
    """Test that returned DependencyInfo is a new object and not mutated in place."""
    dep = DependencyInfo(name="pytest", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output

# ----------- LARGE SCALE TEST CASES ------------




def test_determinism_for_same_input():
    """Test that repeated calls with the same input yield the same output."""
    dep = DependencyInfo(name="pytest", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result1 = codeflash_output
    codeflash_output = _classify_dependency(dep); result2 = codeflash_output

# ----------- TYPE AND ATTRIBUTE TESTS ------------

def test_return_type_and_fields():
    """Test that the returned object is of type DependencyInfo and has correct fields."""
    dep = DependencyInfo(name="pytest", version=None, is_local=False)
    codeflash_output = _classify_dependency(dep); result = codeflash_output
# codeflash_output is used to check that the output of the original code is the same as that of the optimized code.

To edit these changes git checkout codeflash/optimize-pr9192-2025-07-25T17.43.34 and push.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[misrasaurabh1]

this looks good, i suspect repeated dependencies. caching could be useful especially because the gains are considerable.