Skip to content

build: add structlog dep to base package#9516

Merged
jordanrfrazier merged 1 commit into
mainfrom
add-struclog-to-windows
Aug 25, 2025
Merged

build: add structlog dep to base package#9516
jordanrfrazier merged 1 commit into
mainfrom
add-struclog-to-windows

Conversation

@jordanrfrazier
Copy link
Copy Markdown
Collaborator

@jordanrfrazier jordanrfrazier commented Aug 25, 2025

Build - https://github.com/langflow-ai/langflow/actions/runs/17210804644/job/48822287646

Summary by CodeRabbit

  • Chores
    • Windows CI: Tests now activate the virtual environment before running CLI help checks, improving reliability of cross-platform test runs.
    • Backend: Added a structured logging library as a dependency; log output may become clearer and more consistent.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates Windows steps in the cross-platform CI workflow to activate the Python virtual environment before invoking the CLI help command. Adds structlog (>=25.4.0) as a dependency in the backend base pyproject. No Unix workflow changes and no public API changes.

Changes

Cohort / File(s) Summary
CI workflow: Windows CLI help invocation
.github/workflows/cross-platform-test.yml
Modify two Windows steps to call test-env\Scripts\activate.bat before running python -m langflow --help, replacing direct test-env\Scripts\python.exe -m langflow --help. Unix steps unchanged.
Backend dependency update
src/backend/base/pyproject.toml
Add dependency structlog>=25.4.0 after loguru entry. No other config changes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant CI as GitHub Actions (Windows)
    participant Shell as PowerShell/CMD
    participant Venv as venv (test-env)
    participant Python as python
    participant LangFlow as langflow module

    CI->>Shell: Run step "Test CLI help command"
    Shell->>Venv: call Scripts/activate.bat
    Note right of Venv: Activates venv, sets PATH
    Shell->>Python: python -m langflow --help
    Python->>LangFlow: Load module and print help
    LangFlow-->>CI: Exit code/status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • ogabrielluiz

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d3abfb5 and 887c826.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/cross-platform-test.yml (2 hunks)
  • src/backend/base/pyproject.toml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-struclog-to-windows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added the build label Aug 25, 2025
@sonarqubecloud
Copy link
Copy Markdown

@jordanrfrazier jordanrfrazier marked this pull request as ready for review August 25, 2025 13:58
@github-actions github-actions Bot added build and removed build labels Aug 25, 2025
@jordanrfrazier jordanrfrazier merged commit bbb0838 into main Aug 25, 2025
17 of 20 checks passed
@jordanrfrazier jordanrfrazier deleted the add-struclog-to-windows branch August 25, 2025 13:59
@github-actions github-actions Bot added build and removed build labels Aug 25, 2025
lucaseduoli pushed a commit that referenced this pull request Aug 25, 2025
Add structlog dep to base package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant