Skip to content

error#9556

Closed
Vigtu wants to merge 1 commit into
langflow-ai:mainfrom
Vigtu:fix/message-history-session-id-visibility-9464
Closed

error#9556
Vigtu wants to merge 1 commit into
langflow-ai:mainfrom
Vigtu:fix/message-history-session-id-visibility-9464

Conversation

@Vigtu
Copy link
Copy Markdown
Contributor

@Vigtu Vigtu commented Aug 26, 2025

Summary

Fixes the UI bug where the session_id input field was hidden when the Message History component was in "Retrieve" mode, preventing users from dynamically setting the session ID for retrieving specific conversation history.

Changes Made

  • Added session_id to default_keys list to make it visible by default
  • Added session_id to the Retrieve mode configuration in mode_config
  • Kept advanced=True as requested to maintain proper field categorization

Root Cause

The issue was caused by triple visibility control:

  1. session_id was missing from mode_config["Retrieve"] list
  2. session_id was missing from default_keys list
  3. Field was marked as advanced=True (kept as requested)

Test Plan

  • Verify session_id field is now visible in Message History component when in Retrieve mode
  • Verify session_id field appears in advanced settings section
  • Verify the field accepts input and properly retrieves messages for specific sessions

Fixes #9464

Technical Details

Files modified:

  • src/backend/base/langflow/components/helpers/memory.py
    • Line 22: Added session_id to default_keys
    • Line 25: Added session_id to Retrieve mode config

The fix ensures the session_id field is properly visible and functional when using the Message History component in Retrieve mode, allowing users to dynamically specify which conversation's messages to retrieve.

Summary by CodeRabbit

  • New Features

    • Memory component now supports session-scoped retrieval via session ID.
    • Added optional developer UX enhancements: dynamic status line and pre-action hooks.
  • Documentation

    • Added comprehensive agent guidelines and specifications.
    • Published troubleshooting and validated responses for JWT, SSL, PostgreSQL, streaming, multimodal images, MCP, Helm assets, Vite proxy, YouTube transcripts, and more.
    • Introduced /wish command usage and examples.
    • Provided hook examples and configuration guidance.
  • Chores

    • Added cross-platform scripts and configuration to enable status line rendering and hooks.
    • Included version metadata for tooling.

- Added session_id to default_keys to make it visible by default
- Added session_id to Retrieve mode config to show it when mode is selected
- Kept advanced=True as requested to maintain field categorization
- Fixes issue where session_id input was hidden preventing dynamic session retrieval

Fixes langflow-ai#9464
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds extensive documentation and tooling under .claude/, multiple issue-response docs, and introduces cross-platform Genie statusline scripts/config. The only product code change updates MemoryComponent to expose session_id in defaults and in Retrieve mode fields, addressing UI visibility of session_id in Message History retrieval.

Changes

Cohort / File(s) Change Summary
Memory component UI fields
src/backend/base/langflow/components/helpers/memory.py
Expose session_id in default_keys; include session_id in mode_config["Retrieve"] fields.
Agent core rules and definitions
.claude/agent-definitions/ALL_AGENTS_CORE_RULES.md, .claude/agent-definitions/langflow-analyzer.md, .claude/agent-definitions/langflow-dev-fixer.md, AGENT_ENHANCEMENTS_v2.md, CLAUDE.md, VALIDATION_LEARNINGS_SUMMARY.md
Add policy/rules and agent specifications; no executable code changes.
Agents specs
.claude/agents/* including langflow-analyzer.md, langflow-agent-creator.md, langflow-agent-enhancer.md, langflow-claudemd.md, langflow-clone.md, langflow-dev-*
Add multiple Langflow agent manifests and guidance docs.
Genie statusline tooling
.claude/genie-statusline.js, .claude/genie-statusline.sh, .claude/genie-statusline.ps1, .claude/genie-version.json, .claude/settings.json
Add cross-platform statusline wrappers, version metadata, and CLAUDE hooks/settings (enable hooks, status line command).
Hooks examples
.claude/hooks/examples/*, .claude/minimal-hook.sh
Add sample TDD/quality hooks, settings, and a minimal hook script.
Commands
.claude/commands/wish.md
Add /wish workflow command documentation.
Issue analyses and validated responses
*_issue_*_*.md, *validated_response*.md, *corrected_response*.md, *final_solution*.md, cluster_setup_9421_validated_response.md, streaming_api_8474_validated_response.md, openai_api_4664_validated_response.md, ...
Add numerous support/analysis documents for specific issues (Docling, JWT, SSL, MCP, Helm, PostgreSQL, Vite, Multimodal, etc.).

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
Make session_id input visible/connectable in Message History “Retrieve” mode [#9464]

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Add Genie statusline wrappers and config (.claude/genie-statusline.{js,sh,ps1}, .claude/genie-version.json, .claude/settings.json) Tooling integration unrelated to Message History UI session_id visibility.
Add hooks examples and minimal hook (.claude/hooks/examples/*, .claude/minimal-hook.sh) Development hooks not tied to the session_id field exposure.
Add multiple agent specs and rules (.claude/agents/*, .claude/agent-definitions/*, AGENT_ENHANCEMENTS_v2.md, CLAUDE.md) Documentation/manifests unrelated to the specific UI bug.
Add numerous issue-response docs (e.g., docling_*, jwt_*, ssl_*, mcp_*, helm_*, postgresql_*, vite_proxy_*, streaming_api_*) Knowledge base additions not connected to #9464’s requirement.

Possibly related PRs

Suggested labels

bug, size:L, lgtm

Suggested reviewers

  • ogabrielluiz
  • jordanrfrazier
  • edwinjosechittilappilly

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d835313 and 18d123a.

📒 Files selected for processing (59)
  • .claude/agent-definitions/ALL_AGENTS_CORE_RULES.md (1 hunks)
  • .claude/agent-definitions/langflow-analyzer.md (1 hunks)
  • .claude/agent-definitions/langflow-dev-fixer.md (1 hunks)
  • .claude/agents/langflow-agent-creator.md (1 hunks)
  • .claude/agents/langflow-agent-enhancer.md (1 hunks)
  • .claude/agents/langflow-analyzer.md (1 hunks)
  • .claude/agents/langflow-claudemd.md (1 hunks)
  • .claude/agents/langflow-clone.md (1 hunks)
  • .claude/agents/langflow-dev-coder.md (1 hunks)
  • .claude/agents/langflow-dev-designer.md (1 hunks)
  • .claude/agents/langflow-dev-fixer.md (1 hunks)
  • .claude/agents/langflow-dev-planner.md (1 hunks)
  • .claude/commands/wish.md (1 hunks)
  • .claude/genie-statusline.js (1 hunks)
  • .claude/genie-statusline.ps1 (1 hunks)
  • .claude/genie-statusline.sh (1 hunks)
  • .claude/genie-version.json (1 hunks)
  • .claude/hooks/examples/README.md (1 hunks)
  • .claude/hooks/examples/settings.json (1 hunks)
  • .claude/hooks/examples/tdd-hook.sh (1 hunks)
  • .claude/minimal-hook.sh (1 hunks)
  • .claude/settings.json (1 hunks)
  • AGENT_ENHANCEMENTS_v2.md (1 hunks)
  • CLAUDE.md (1 hunks)
  • VALIDATION_LEARNINGS_SUMMARY.md (1 hunks)
  • cluster_setup_9421_validated_response.md (1 hunks)
  • docling_hf_401_issue_9348_corrected_response.md (1 hunks)
  • docling_issue_9024_corrected_response.md (1 hunks)
  • docling_issue_9024_validated_response.md (1 hunks)
  • docling_issue_9024_validation_report.md (1 hunks)
  • execution_blocked_8771_validated_response.md (1 hunks)
  • file_deletion_issue_9053_validated_response.md (1 hunks)
  • gemini_mcp_issue_9437_validated_response.md (1 hunks)
  • helm_profile_pictures_issue_9439_corrected_response.md (1 hunks)
  • helm_profile_pictures_issue_9439_response.md (1 hunks)
  • jwt_docker_issue_solution.md (1 hunks)
  • jwt_docker_issue_solution_updated.md (1 hunks)
  • langfuse_thread_leak_issue_9066_corrected_response.md (1 hunks)
  • macos_m1_issue_9029_response.md (1 hunks)
  • mcp_duplicate_output_issue_9036_response.md (1 hunks)
  • mcp_issue_9064_corrected_response.md (1 hunks)
  • mcp_server_naming_issue_9392_corrected_response.md (1 hunks)
  • mcp_tool_mode_issue_9003_response.md (1 hunks)
  • multimodal_issue_9465_validated_response.md (1 hunks)
  • openai_api_4664_validated_response.md (1 hunks)
  • output_issue_9071_corrected_response.md (1 hunks)
  • postgresql_9356_updated_response.md (1 hunks)
  • postgresql_9356_validated_response.md (1 hunks)
  • postgresql_issue_corrected_response.md (1 hunks)
  • security_issue_9055_validated_response.md (1 hunks)
  • src/backend/base/langflow/components/helpers/memory.py (1 hunks)
  • ssl_issue_4157_final_solution.md (1 hunks)
  • ssl_issue_4157_validated_response.md (1 hunks)
  • streaming_api_8474_validated_response.md (1 hunks)
  • structured_output_vllm_issue_9470_corrected_response.md (1 hunks)
  • structured_output_vllm_issue_9470_final_response.md (1 hunks)
  • structured_output_vllm_issue_9470_validated_response.md (1 hunks)
  • vite_proxy_issue_8972_validated_response.md (1 hunks)
  • youtube_transcripts_5486_validated_response.md (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added the bug Something isn't working label Aug 26, 2025
@Vigtu Vigtu closed this Aug 26, 2025
@sonarqubecloud
Copy link
Copy Markdown

@Vigtu Vigtu deleted the fix/message-history-session-id-visibility-9464 branch August 26, 2025 20:53
@Vigtu Vigtu changed the title fix: make session_id visible in Message History Retrieve mode error Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Bug: "Session ID" input is hidden in Message History component's "Retrieve" mode

1 participant