Skip to content

fix: Correct the docling dependencies and Chroma in particular#9925

Merged
jordanrfrazier merged 1 commit into
release-1.6.0-follow-upsfrom
fix-docling-deps
Sep 19, 2025
Merged

fix: Correct the docling dependencies and Chroma in particular#9925
jordanrfrazier merged 1 commit into
release-1.6.0-follow-upsfrom
fix-docling-deps

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

This pull request updates dependency version constraints for Chroma-related packages and improves how the limit parameter is handled in the Chroma vector store component to prevent potential issues with invalid or empty values.

Dependency version updates:

  • Updated chromadb dependency constraint to allow versions >=0.5.6,<0.6.0 in pyproject.toml for better compatibility and flexibility.
  • Updated langchain-chroma dependency constraint to allow versions >=0.1.4,<0.2.0 in pyproject.toml.

Chroma vector store improvements:

  • Improved handling of the limit parameter in build_vector_store and _add_documents_to_vector_store methods in chroma.py by converting it to an integer only when it is not None or empty, preventing issues with invalid values. [1] [2]

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-docling-deps

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label Sep 19, 2025
@sonarqubecloud
Copy link
Copy Markdown

@jordanrfrazier jordanrfrazier enabled auto-merge (squash) September 19, 2025 15:09
@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.24%. Comparing base (005f926) to head (9492e09).
⚠️ Report is 1 commits behind head on release-1.6.0-follow-ups.

❌ Your project status has failed because the head coverage (45.52%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           release-1.6.0-follow-ups    #9925      +/-   ##
============================================================
- Coverage                     23.25%   23.24%   -0.02%     
============================================================
  Files                          1090     1090              
  Lines                         39837    39837              
  Branches                       5530     5530              
============================================================
- Hits                           9264     9259       -5     
- Misses                        30402    30407       +5     
  Partials                        171      171              
Flag Coverage Δ
backend 45.52% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jordanrfrazier jordanrfrazier merged commit 54e7a46 into release-1.6.0-follow-ups Sep 19, 2025
33 of 34 checks passed
@jordanrfrazier jordanrfrazier deleted the fix-docling-deps branch September 19, 2025 15:17
github-merge-queue Bot pushed a commit that referenced this pull request Sep 19, 2025
* fix: Load flows autologin false (#9578)

* docs: update support documentation to reflect support rebranding (#9538)

* docs: update support documentation to reflect rebranding to IBM Elite Support for Langflow

* remove-info-tab

* Apply suggestions from code review

Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>

---------

Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>

* setup.py disable autologin check for loading flows

* [autofix.ci] apply automated fixes

* New base branch, updated files for release

---------

Co-authored-by: Mendon Kissling <59585235+mendonk@users.noreply.github.com>
Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jordan Frazier <jordan.frazier@datastax.com>

* fix: Move docling dependency into core dependencies instead of dev (#9906)

* fix: Make sure strings can be parsed in the python interpreter (#9908)

* fix: Execution of python interpreter

* Update test_python_repl_tool.py

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* Remove docling dep from optional group since its in main dep group

* fix: Correct the docling dependencies and Chroma in particular (#9925)

fix: Correct docling dependencies

---------

Co-authored-by: Sebastián Estévez <estevezsebastian@gmail.com>
Co-authored-by: Mendon Kissling <59585235+mendonk@users.noreply.github.com>
Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Hare <ericrhare@gmail.com>
Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants