fix: Correct the docling dependencies and Chroma in particular#9925
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (45.52%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.6.0-follow-ups #9925 +/- ##
============================================================
- Coverage 23.25% 23.24% -0.02%
============================================================
Files 1090 1090
Lines 39837 39837
Branches 5530 5530
============================================================
- Hits 9264 9259 -5
- Misses 30402 30407 +5
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
54e7a46
into
release-1.6.0-follow-ups
* fix: Load flows autologin false (#9578) * docs: update support documentation to reflect support rebranding (#9538) * docs: update support documentation to reflect rebranding to IBM Elite Support for Langflow * remove-info-tab * Apply suggestions from code review Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com> --------- Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com> * setup.py disable autologin check for loading flows * [autofix.ci] apply automated fixes * New base branch, updated files for release --------- Co-authored-by: Mendon Kissling <59585235+mendonk@users.noreply.github.com> Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Jordan Frazier <jordan.frazier@datastax.com> * fix: Move docling dependency into core dependencies instead of dev (#9906) * fix: Make sure strings can be parsed in the python interpreter (#9908) * fix: Execution of python interpreter * Update test_python_repl_tool.py * [autofix.ci] apply automated fixes --------- Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Remove docling dep from optional group since its in main dep group * fix: Correct the docling dependencies and Chroma in particular (#9925) fix: Correct docling dependencies --------- Co-authored-by: Sebastián Estévez <estevezsebastian@gmail.com> Co-authored-by: Mendon Kissling <59585235+mendonk@users.noreply.github.com> Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Hare <ericrhare@gmail.com> Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>



This pull request updates dependency version constraints for Chroma-related packages and improves how the
limitparameter is handled in the Chroma vector store component to prevent potential issues with invalid or empty values.Dependency version updates:
chromadbdependency constraint to allow versions>=0.5.6,<0.6.0inpyproject.tomlfor better compatibility and flexibility.langchain-chromadependency constraint to allow versions>=0.1.4,<0.2.0inpyproject.toml.Chroma vector store improvements:
limitparameter inbuild_vector_storeand_add_documents_to_vector_storemethods inchroma.pyby converting it to an integer only when it is notNoneor empty, preventing issues with invalid values. [1] [2]