fix(core): add guard for provider metadata; revise exception messages

[ogabrielluiz]

Summary by CodeRabbit

• Bug Fixes

  • Prevented crashes in the model provider dropdown when a provider lacks metadata, ensuring reliable model selection.
  • Improved error handling during custom class creation to avoid ambiguous failures.

• Refactor

  • Enhanced error messages to include the exception type and details for clearer diagnostics without changing behavior or APIs.

[coderabbitai]

Walkthrough

Adds a guard when building model provider metadata to avoid missing-key errors and revises exception message formatting in class creation without changing signatures or control flow.

Changes

Cohort / File(s)	Summary of Changes
Agent provider metadata guard src/lfx/src/lfx/components/agents/agent.py	Filters DropdownInput.options_metadata to include only providers present in MODELS_METADATA, preventing KeyError. No other logic or signatures changed.
Validation error message formatting src/lfx/src/lfx/custom/validate.py	In create_class, generic exception handling now raises ValueError with formatted message: includes exception type and wraps original message in parentheses. No API/signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title "@coderabbitai" is an @-mention and does not describe the changes in this pull request (which guard MODELS_METADATA lookups in the agent provider options and adjust the create_class exception message), so it fails to summarize the main change or provide context for reviewers. Because the title is unrelated to the changeset content, the check fails.	Replace the title with a concise, single-sentence summary of the primary change; for example, "Guard missing model metadata in agent provider options and improve create_class error message" or "Guard MODELS_METADATA lookup in agent and include exception type in create_class error message." Ensure the new title is specific, short, and focused on the main code change rather than an @-mention.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-agent-lfx

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7df5173 and fbccc16.

📒 Files selected for processing (2)

• src/lfx/src/lfx/components/agents/agent.py (1 hunks)
• src/lfx/src/lfx/custom/validate.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Update Starter Projects
• GitHub Check: Run Ruff Check and Format
• GitHub Check: Ruff Style Check (3.13)

🔇 Additional comments (3)

src/lfx/src/lfx/components/agents/agent.py (2)

69-70: LGTM! Defensive programming prevents KeyError.

The guard prevents potential KeyError exceptions when a provider exists in MODEL_PROVIDERS_LIST but lacks corresponding metadata in MODELS_METADATA. This is a solid defensive programming practice that improves robustness.

KeyError occurs when trying to access a key that doesn't exist in a dictionary, and using conditional checks like if key in dict is a standard best practice to prevent such errors.

---

535-535: Duplicate guard implementation - consistent with above change.

This implements the same defensive pattern as line 69, ensuring consistency across the codebase where MODELS_METADATA is accessed.

src/lfx/src/lfx/custom/validate.py (1)

284-284: Improved error message format provides better diagnostics.

The new format "Error creating class. {ExceptionName}({original_message})." is more informative than the previous "Error creating class: {original_message}", as it now includes the exception type name. This helps developers quickly identify the root cause of class creation failures.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.25%. Comparing base (bb098a5) to head (f3f09dc).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (45.55%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9927   +/-   ##
=======================================
  Coverage   23.25%   23.25%           
=======================================
  Files        1090     1090           
  Lines       39837    39837           
  Branches     5530     5530           
=======================================
  Hits         9264     9264           
  Misses      30402    30402           
  Partials      171      171           

Flag	Coverage Δ
backend	45.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[edwinjosechittilappilly]

LGTM