Skip to content

docs: descriptions content for bundles tables#9968

Closed
mendonk wants to merge 3 commits into
mainfrom
docs-css-bundles-tables
Closed

docs: descriptions content for bundles tables#9968
mendonk wants to merge 3 commits into
mainfrom
docs-css-bundles-tables

Conversation

@mendonk
Copy link
Copy Markdown
Collaborator

@mendonk mendonk commented Sep 24, 2025

This pull request updates the descriptions for several component bundles and integrations.

Summary by CodeRabbit

  • Documentation
    • Expanded parameter descriptions for Bing, Google (Generative AI, Search, Serper), and Glean bundles, including authentication notes, model selection guidance, defaults, and usage context.
    • Clarified CSV Agent (LangChain) parameters with richer guidance and examples.
    • Enhanced Redis Chat Memory docs with defaults and authentication details.
    • Improved component helper docs (unique_id, id) and processing components (lists, indexing, update behavior, router specs).
    • Updated Docling integration docs with accepted file formats, pipeline recommendations, and OCR engine selection guidance.

@mendonk mendonk requested a review from aimurphy September 24, 2025 17:10
@mendonk mendonk self-assigned this Sep 24, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 24, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Documentation-only updates expanding parameter descriptions across multiple component and integration docs. Changes add authentication notes, usage guidance, defaults, and clarifications for bundles (Bing, Glean, Google, LangChain, Redis), component helpers/processing, and the Docling integration. No code, logic, control flow, or public API changes.

Changes

Cohort / File(s) Summary of Changes
Bundles docs
docs/docs/Components/bundles-bing.mdx, docs/docs/Components/bundles-glean.mdx, docs/docs/Components/bundles-google.mdx, docs/docs/Components/bundles-langchain.mdx, docs/docs/Components/bundles-redis.mdx
Expanded parameter descriptions: authentication requirements, input usage, defaults/optionality, endpoint/model guidance, pagination/options; wording clarifications. No functional changes.
Components docs
docs/docs/Components/components-helpers.mdx, docs/docs/Components/components-processing.mdx
Clarified helper IDs and final identifiers; refined LLM Router flag text; detailed data list/index/selection semantics; expanded Update Data field/validation descriptions. No logic changes.
Integration: Docling
docs/docs/Integrations/Docling/integrations-docling.mdx
Expanded guidance on accepted file formats, pipeline choices, and OCR engine selection. No API or behavior changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

documentation, size:XL, lgtm

Suggested reviewers

  • aimurphy
  • edwinjosechittilappilly

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly conveys that the primary change is updating documentation descriptions for bundle tables and directly reflects the main scope of the pull request without including unnecessary detail or irrelevant information.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 24, 2025
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (8)
docs/docs/Integrations/Docling/integrations-docling.mdx (1)

73-75: Tighten enum formatting and clarify option sets

Use backticks for literal option values and tighten phrasing.

Apply this diff:

-| files | File | The files to process. This parameter accepts various file formats including PDF, DOCX, images, and other document types that Docling supports for processing and analysis. |
-| pipeline | String | The Docling pipeline to use (standard, vlm). The standard pipeline is recommended for most use cases, while the vlm pipeline provides enhanced visual language model capabilities for documents with complex layouts and images. |
-| ocr_engine | String | OCR engine to use (easyocr, tesserocr, rapidocr, ocrmac). Choose the OCR engine based on your performance requirements and accuracy needs. |
+| files | File | The files to process. Accepts common document formats (for example, `pdf`, `docx`, and image files such as `png`/`jpg`) supported by Docling. |
+| pipeline | String | The Docling pipeline to use (one of: `standard`, `vlm`). Use `standard` for most cases; `vlm` adds visual‑layout modeling for complex documents. |
+| ocr_engine | String | The OCR engine to use (one of: `easyocr`, `tesserocr`, `rapidocr`, `ocrmac`). Choose based on performance and accuracy needs. |
docs/docs/Components/bundles-redis.mdx (1)

27-33: Minor clarity + security nudge for Redis connection fields

  • Tighten defaults and phrasing.
  • Consider adding a short security admonition about auth/TLS.

Apply this diff:

-| host | hostname | Input parameter. The IP address or hostname. This should be the network address of your Redis server, such as "localhost" for local development or a specific IP address for remote servers. |
-| port | port | Input parameter. The Redis Port Number. The default Redis port is 6379, but you can specify a different port if your Redis instance is configured to use a non-standard port. |
-| database | database | Input parameter. The Redis database. Redis supports multiple databases (0-15 by default), allowing you to separate different applications or data types within the same Redis instance. |
-| username | Username | Input parameter. The Redis username. This is required for Redis 6.0+ authentication. If your Redis instance doesn't require authentication, this field can be left empty. |
-| password | Password | Input parameter. The password for the username. This is required for Redis authentication. If your Redis instance doesn't require authentication, this field can be left empty. |
-| key_prefix | Key prefix | Input parameter. The key prefix. This prefix will be added to all Redis keys to help organize and identify your chat memory data, preventing conflicts with other applications using the same Redis instance. |
-| session_id | Session ID | Input parameter. The unique session identifier for the message. This identifier groups related chat messages together, allowing you to maintain separate conversation threads or user sessions within your Redis storage. |
+| host | hostname | Input parameter. The IP address or hostname of your Redis server (for example, `localhost` for local development or an internal IP/DNS for remote servers). |
+| port | port | Input parameter. The Redis port number. Default: `6379`. Change only if your instance uses a non‑standard port. |
+| database | database | Input parameter. The Redis logical database index (typically `0`–`15`). Use separate indexes to isolate applications within the same instance. |
+| username | Username | Input parameter. The Redis username (required for Redis 6.0+ ACL‑based auth). Leave empty if your instance doesn't require auth. |
+| password | Password | Input parameter. The password for the username. Store as a secret; avoid hardcoding credentials. |
+| key_prefix | Key prefix | Input parameter. Prefix added to all keys to organize chat memory data and avoid key collisions. |
+| session_id | Session ID | Input parameter. The unique session identifier to group related chat messages (separate threads/users). |

Add a brief admonition after the table:

:::warning
For production, enable authentication and TLS for Redis (or use `rediss://` endpoints via a proxy) to protect chat memory from unauthorized access.
:::
docs/docs/Components/components-helpers.mdx (1)

226-227: Clarify ID Generator input vs. output semantics

Avoid calling the input “generated.” Make it explicit the input is optional and the output is the final ID.

Apply this diff:

-| unique_id | String | Input parameter. The generated unique ID. This parameter allows you to specify a custom identifier or use the component's automatic ID generation functionality. |
-| id | String | Output parameter. The generated unique ID. This contains the final unique identifier that can be used for tracking, referencing, or identifying specific items in your flow. |
+| unique_id | String | Input parameter. Optional custom ID to use. Leave empty to auto‑generate a unique identifier. |
+| id | String | Output parameter. The generated unique ID for tracking or referencing downstream. |
docs/docs/Components/bundles-glean.mdx (1)

25-29: Confirm base URL and document token usage header

  • Verify the base URL pattern; provide a concrete, correct example.
  • Mention the Authorization: Bearer header for the access token.

Apply this diff:

-| glean_api_url | String | Input parameter. The URL of the Glean API. This should be the base URL for your Glean instance, typically in the format `https://your-domain.glean.com/api/v1`. |
-| glean_access_token | SecretString | Input parameter. An access token for Glean API authentication. This token is required to authenticate with the Glean API and should be obtained from your Glean admin settings. |
+| glean_api_url | String | Input parameter. The base URL for your Glean API (for example, `https://<your-domain>.glean.com/api/v1`). |
+| glean_access_token | SecretString | Input parameter. Access token for Glean API authentication (send as `Authorization: Bearer <token>`). Obtain it from your Glean admin settings. |

Please confirm the correct base URL format from Glean’s docs and whether any region‑specific hosts exist.

docs/docs/Components/bundles-bing.mdx (1)

25-28: Add authoritative links and defaults; verify k default and endpoint

  • Add an Azure key acquisition link.
  • If you expose bing_search_url, document the default endpoint.
  • Confirm the default for k to avoid ambiguity.

Apply this diff:

-| bing_subscription_key | SecretString | Input parameter. A Bing API subscription key. This key is required for authentication with Microsoft's Bing Search API and should be obtained from the Azure portal. |
+| bing_subscription_key | SecretString | Input parameter. A Bing API subscription key. Required for authentication with Microsoft's Bing Search API; obtain it from the Azure portal (see https://aka.ms/cognitive-services-keys). |
-| bing_search_url | String | Input parameter. A custom Bing Search URL. This parameter is optional and allows you to specify a custom endpoint for the Bing Search API if you have a specific configuration or regional requirement. |
+| bing_search_url | String | Input parameter. Optional custom Bing Search URL (defaults to `https://api.bing.microsoft.com/v7.0/search`). Use only for regional or proxy endpoints. |
-| k | Integer | Input parameter. The number of search results to return. This parameter is optional and controls how many search results are included in the output DataFrame. If not specified, a default number of results will be returned. |
+| k | Integer | Input parameter. The number of search results to return. If omitted, the component’s default is used (confirm the default value). |

Please confirm the component’s default for k and whether the default endpoint above matches the implementation.

docs/docs/Components/components-processing.mdx (3)

391-391: Minor style: literal booleans and default formatting

Use backticks for booleans and default values for consistency.

Apply this diff:

-| `use_openrouter_specs` | **Use OpenRouter Specs** | Input parameter. Whether to fetch model specifications from the OpenRouter API. If false, only the model name is provided to the judge LLM. Default: Enabled (true) |
+| `use_openrouter_specs` | **Use OpenRouter Specs** | Input parameter. Whether to fetch model specifications from the OpenRouter API. If disabled (`false`), only the model name is provided to the judge LLM. Default: Enabled (`true`). |

1241-1244: Define out-of-range index behavior for Select Data

Document what happens if data_index is out of bounds (error, empty output, or fallback). This avoids confusion in flows.

Proposed wording:

If the index is out of range, the component returns no item and logs an error.

Please adjust to match actual behavior.


1258-1263: Clarify validator failure behavior and limits

  • State explicitly what happens when text_key_validator fails (skip, error, or fallback).
  • For number_of_fields, indicate whether the 15‑field cap is enforced by UI only or also validated at runtime.

I can draft exact wording once you confirm the runtime behavior.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5f215d and e2d8c80.

📒 Files selected for processing (8)
  • docs/docs/Components/bundles-bing.mdx (1 hunks)
  • docs/docs/Components/bundles-glean.mdx (1 hunks)
  • docs/docs/Components/bundles-google.mdx (3 hunks)
  • docs/docs/Components/bundles-langchain.mdx (1 hunks)
  • docs/docs/Components/bundles-redis.mdx (1 hunks)
  • docs/docs/Components/components-helpers.mdx (1 hunks)
  • docs/docs/Components/components-processing.mdx (3 hunks)
  • docs/docs/Integrations/Docling/integrations-docling.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (.cursor/rules/docs_development.mdc)

docs/docs/**/*.{md,mdx}: All documentation content must be written in Markdown or MDX files located under docs/docs/, following the prescribed directory structure for guides, reference, how-to, concepts, and API documentation.
All documentation Markdown and MDX files must begin with a frontmatter block including at least title and description fields.
Use admonitions (:::tip, :::warning, :::danger) in Markdown/MDX files to highlight important information, warnings, or critical issues.
All images referenced in documentation must include descriptive alt text for accessibility.
All code examples included in documentation must be tested and verified to work as shown.
Internal links in documentation must be functional and not broken.
Content must follow the style guide: professional but approachable tone, second person voice, present tense, short paragraphs, sentence case headers, inline code with backticks, bold for UI elements, italic for emphasis, and parallel structure in lists.
Use consistent terminology: always capitalize Langflow, Component, Flow, and uppercase API and JSON.

Files:

  • docs/docs/Components/components-processing.mdx
  • docs/docs/Components/bundles-redis.mdx
  • docs/docs/Components/bundles-bing.mdx
  • docs/docs/Components/bundles-glean.mdx
  • docs/docs/Components/bundles-google.mdx
  • docs/docs/Integrations/Docling/integrations-docling.mdx
  • docs/docs/Components/components-helpers.mdx
  • docs/docs/Components/bundles-langchain.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test Docs Build / Test Docs Build
  • GitHub Check: build-and-deploy
🔇 Additional comments (3)
docs/docs/Components/bundles-google.mdx (3)

55-61: LGTM: Clear, actionable Google Search API parameter docs

Descriptions align with common usage and clarify outputs and LangChain tool integration.


70-74: LGTM: Serper parameters are clear and correctly scoped

Auth notes and output/tool descriptions look good.


24-31: Do not remove N—LangChain’s ChatGoogleGenerativeAI supports the n parameter and the listed generation_config fields.

Likely an incorrect or invalid review comment.

Comment thread docs/docs/Components/bundles-langchain.mdx
@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 24, 2025
@sonarqubecloud
Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 24, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@mendonk
Copy link
Copy Markdown
Collaborator Author

mendonk commented Sep 24, 2025

Closing until 1.6 release

@mendonk mendonk closed this Sep 24, 2025
@mendonk mendonk deleted the docs-css-bundles-tables branch September 26, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant