fix: add any_configured() to ProvidersConfig to prevent onboarding 500#1201
Merged
Conversation
#1177) settings.py calls current_config.providers.any_configured() but ProvidersConfig had no such method, causing an AttributeError that surfaces as a 500 error during onboarding when configuring watsonx.ai or ollama providers. Closes #1163 Made-with: Cursor Co-authored-by: themavik <themavik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Onboarding fails with a 500 error when configuring watsonx.ai or ollama providers because
ProvidersConfigis missing theany_configured()method thatsettings.pycalls.Problem
src/api/settings.pyline 1088 calls:But
ProvidersConfiginsrc/config/config_manager.pyonly hasget_provider_config()— noany_configured()method exists. This raisesAttributeError: 'ProvidersConfig' object has no attribute 'any_configured', which surfaces as a 500 error during the onboarding settings save.Root cause
The
any_configured()call was added tosettings.pybut the corresponding method was never implemented on theProvidersConfigdataclass.Fix
Add
any_configured()toProvidersConfigthat returnsTrueif any provider'sconfiguredflag is set. Each provider dataclass (OpenAIConfig,AnthropicConfig,WatsonXConfig,OllamaConfig) already has aconfigured: boolfield.Testing
any_configured()returnsTruewhen at least one provider is configuredany_configured()returnsFalsewhen no providers are configuredCloses #1163