fix: added check for podman compose inside startup checks#1266
Merged
Conversation
github-actions
Bot
added
backend
github-actions
Bot
added
bug
mpawlow
requested changes
Mar 26, 2026
github-actions
Bot
added
bug
mpawlow
reviewed
Mar 26, 2026
Collaborator
mpawlow
left a comment
mpawlow
left a comment
There was a problem hiding this comment.
Code Review 2
- ✅ LGTM / Approved
- See PR comments: (2a) to (2c)
- New PR comments are all Minor severity
- 🚧 Functional Review 1 is in progress...
mpawlow
approved these changes
Mar 26, 2026
Collaborator
mpawlow
left a comment
mpawlow
left a comment
There was a problem hiding this comment.
Functional Review 1
- ✅ LGTM / Approved
- Successfully ran 3 sanity simulated tests on my VM:
- Scenario A — Happy path: podman-compose already installed
- Scenario B — Not installed, user declines
- Scenario C — Full run_startup_checks() with podman as runtime
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands and improves support for Podman Compose in the startup checks utility. The main focus is to ensure environments using Podman have the necessary compose tooling available, whether as a built-in subcommand or a standalone binary, and to provide automated installation options for
podman-composeacross platforms.The most important changes are:
Compose availability checks:
compose_available()function now checks for both Docker Compose and Podman Compose, including the built-inpodman composesubcommand and the standalonepodman-composebinary. This ensures broader compatibility with different container runtimes and installation methods. [1] [2]Podman Compose installation:
install_podman_compose()function that installs the standalonepodman-composebinary if it is not present, supporting macOS (via Homebrew) and Linux/WSL (via pip3 or the system package manager). This function is robust to different environments and provides user prompts and error handling.Startup check flow improvements:
run_startup_checks()function to always attempt installingpodman-composewhen Podman is the selected runtime, regardless of whether the built-in compose subcommand is available. This helps ensure all required dependencies are present for OpenRAG to function reliably with Podman.