Skip to content

[Chore/Refactor] db.session.xxx -> with Session as session #24115

@asukaminato0721

Description

@asukaminato0721

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
  • Please do not modify this template :) and fill in all the required fields.

Description

db.session.commit() is Flask-SQLAlchemy

with Session(...) is Pure SQLAlchemy

Image

Motivation

for migration.

Additional Context

https://docs.sqlalchemy.org/en/20/orm/session_basics.html#framing-out-a-begin-commit-rollback-block

part of COM-7832

need facebook/pyrefly#954

one example: #24135

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions