Skip to content

fix wrongly remove reset nodes#20880

Merged
Nov1c444 merged 1 commit intolanggenius:mainfrom
zalcit:fix_wrongly_remove_rest_nodes
Jun 19, 2025
Merged

fix wrongly remove reset nodes#20880
Nov1c444 merged 1 commit intolanggenius:mainfrom
zalcit:fix_wrongly_remove_rest_nodes

Conversation

@zalcit
Copy link
Copy Markdown
Contributor

@zalcit zalcit commented Jun 10, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

reproduce:
image
image
expect: the final answer node print streamly
image

truth:

  1. when first chat. first ifelse node execute.
  2. _fetch_node_ids_in_reachable_branch can not fetch all node when the second ifelse's branch_identify is not match.
    for the ifelse2 node' branch_identify is a uuid but the ifelse1 node's branch_identify is true. so the node link break.
    image
  3. then _remove_node_ids_in_unreachable_branch with a 'wrong' reachable_node_ids. this method will remove all nodes
    image
  4. cause the wrong rest_node_ids, then cause the final answer node can not print stream. replaced with blocking answer.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@crazywoola crazywoola requested a review from Nov1c444 June 18, 2025 06:06
@crazywoola
Copy link
Copy Markdown
Member

@zalcit
Copy link
Copy Markdown
Contributor Author

zalcit commented Jun 18, 2025

It seems that we fixed in plugin daemon side

This is nothing todo with backwards invocations. It's just a normal call with ifelse branch. Maybe u can try the above method to reproduce.

Copy link
Copy Markdown
Contributor

@Nov1c444 Nov1c444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 19, 2025
@Nov1c444 Nov1c444 merged commit 6325129 into langgenius:main Jun 19, 2025
6 checks passed
@Nov1c444 Nov1c444 mentioned this pull request Jun 27, 2025
5 tasks
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Co-authored-by: zhuqingchao <zhuqingchao@xiaomi.com>
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 15, 2025
Co-authored-by: zhuqingchao <zhuqingchao@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants