Skip to content

feat(question-classifier): add instanceId to class-item editor#22002

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
Minamiyama:fix/ui/class-item-instanceid
Jul 8, 2025
Merged

feat(question-classifier): add instanceId to class-item editor#22002
crazywoola merged 1 commit intolanggenius:mainfrom
Minamiyama:fix/ui/class-item-instanceid

Conversation

@Minamiyama
Copy link
Copy Markdown
Contributor

@Minamiyama Minamiyama commented Jul 7, 2025

Summary

Ensure unique editor instance when nodeId changes by generating a new instanceId

fixed #22006

Screenshots

Before After
148bd0a181e4749afc4fc06c472a8da 159159933bc95deb5139c785d16ca6a

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Ensure unique editor instance when nodeId changes by generating a new instanceId
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript labels Jul 7, 2025
@crazywoola
Copy link
Copy Markdown
Member

Thanks for the PR, please add my wechat crazyphage :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2025
@crazywoola crazywoola merged commit a4bdeba into langgenius:main Jul 8, 2025
5 checks passed
yijiaquan pushed a commit to yijiaquan/dify that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: when click "quickly insert" button of any of class editor in question classifier node, / is inserted to all editor

2 participants