fix(api): fix incorrect path handling in Langfuse integration#22766
fix(api): fix incorrect path handling in Langfuse integration#22766QuantumGhost merged 7 commits intolanggenius:mainfrom
Conversation
|
Please fix the tests. |
|
The validate_url function itself only verifies whether the url is correct and should not change the original url. This is the definition of a validation function. |
|
@chenguowei I agree with your principle that The I suggest a more conservative approach:
|
- Add a note about its behavior of not retaining the `path` component in its return value. - Mark the function as deprecated (as in most situations, we need to retain the `path` component) - Revert changes about `validate_url` and its test cases.
The validation function should keep the original path instead of returning a modified result.
Call `validate_url_with_path` directly in `LangfuseConfig`, instead of calling `cls.validate_endpoint_url`. (The later introduces a tight coupling between `LangfuseConfig` and `BaseTracingConfig`)
The `BaseTraceInstance` requires the configuration to be a subclass of `BaseTracingConfig`.
|
Not interested in your artifactsi |
chenguowei
left a comment
There was a problem hiding this comment.
by modifying case by case in this way, I understand that other subsequent modifications may also need to be made successively
|
@chenguowei Yes, I understand your concern about potential cascading changes. However, it appears that other integrations are working fine with the current approach. Let's keep it as-is for now and monitor if similar issues arise elsewhere. |
…nius#22766) Co-authored-by: QuantumGhost <obelisk.reg+git@gmail.com>

Solve the problem of langfuse configuration error resolves #22757
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods