fix(dataset): CELERY_BROKER uses amqp rabbitmq. When adding document segments in batches and uploading large files, the status will always remain stuck at "In batch processing" #22709#23038
Merged
crazywoola merged 1 commit intolanggenius:mainfrom Jul 28, 2025
zhaobingshuang:main
Merged
Conversation
…segments in batches and uploading large files, the status will always remain stuck at "In batch processing" #22709
crazywoola
approved these changes
Jul 28, 2025
tutkun
pushed a commit
to tutkun/dify
that referenced
this pull request
Aug 15, 2025
…segments in batches and uploading large files, the status will always remain stuck at "In batch processing" langgenius#22709 (langgenius#23038)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22709
Important
Fixes #<issue number>.Summary
The original "batch_create_segment_to_index_task" task would store all the contents of the file as the parameter "content" in the AMQP, and the size of the MQ message could be very large, even exceeding the "max_message_size" configuration of RabbitMQ, which could cause Celery to lose the task.
This modification changed the parameter of "batch_create_segment_to_index_task" from "content" to "upload_file_id". During the execution of the task, the file was downloaded and further processed to avoid large MQ messages.
If the Celery broker uses Redis, this modification can also prevent the occurrence of large Redis keys.
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods