Skip to content

fix: return empty list instead of raising exception for qdrant search when score_threshold is 1#24032

Merged
crazywoola merged 2 commits intolanggenius:mainfrom
BoWuGit:fix/qdrant-score-threshold-1-error
Aug 18, 2025
Merged

fix: return empty list instead of raising exception for qdrant search when score_threshold is 1#24032
crazywoola merged 2 commits intolanggenius:mainfrom
BoWuGit:fix/qdrant-score-threshold-1-error

Conversation

@BoWuGit
Copy link
Copy Markdown
Contributor

@BoWuGit BoWuGit commented Aug 16, 2025 •
edited
Loading

Summary

Fixes #24031, I searched the error response, and found the following issue qdrant/fastembed#145, so I think it may be related with qdrant store:

image

But I can't reproduce it on my dev environment, which the qdrant store is the newest version: 1.15.3, build: a7d21f16. Even set score_threshold to be 2, the search request to qdrant still doesn't raise exception, so it won't be the precision issue of str to float conversion.

Then I estimate that the qdrant version on cloud.dify.ai may not be the newest, which would report this error, so I fix it by returning empty list to be compatible with old qdrant versions. Please help me check it.

Much thanks.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@BoWuGit BoWuGit marked this pull request as ready for review August 16, 2025 04:54
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Aug 16, 2025
@BoWuGit BoWuGit mentioned this pull request Aug 16, 2025
Closed
6 tasks
@BoWuGit BoWuGit marked this pull request as draft August 17, 2025 01:41
@BoWuGit BoWuGit marked this pull request as ready for review August 17, 2025 11:17
@BoWuGit
Copy link
Copy Markdown
Contributor Author

BoWuGit commented Aug 17, 2025

I have checked that the above tests errors have nothing to do with my changes, please check, thanks.

@crazywoola crazywoola force-pushed the fix/qdrant-score-threshold-1-error branch from c87e6d3 to c92761b Compare August 18, 2025 01:43
@crazywoola
Copy link
Copy Markdown
Member

crazywoola commented Aug 18, 2025

Please fix the vdb tests.

@BoWuGit
Copy link
Copy Markdown
Contributor Author

BoWuGit commented Aug 18, 2025

It seems to be a timeout error? Or have I missed something?

https://github.com/langgenius/dify/actions/runs/17004503157/job/48219876117?pr=24032
image

@crazywoola
Copy link
Copy Markdown
Member

crazywoola commented Aug 18, 2025

Please fix the vdb tests.

I will rerun this tests to see if these errors persist.

@crazywoola crazywoola requested a review from JohnJyong August 18, 2025 02:17
crazywoola
crazywoola approved these changes Aug 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @JohnJyong

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 18, 2025
@crazywoola crazywoola merged commit 790a6ec into langgenius:main Aug 18, 2025
9 checks passed
bowenliang123 pushed a commit to bowenliang123/dify that referenced this pull request Aug 18, 2025
@BoWuGit @bowenliang123
fix: return empty list instead of raising exception for qdrant search…
679a8e4 
… when score_threshold is 1 (langgenius#24032)
asukaminato0721 added a commit to asukaminato0721/dify that referenced this pull request Aug 20, 2025
@asukaminato0721 @hyongtao-code
@crazywoola @lyzno1 @NeatGuyCoding @Zhehao-P @laipz8200 @liugddx @WTW0313 @Mairuis @iamjoel @Stream29 @autofix-ci @BoWuGit @github-actions @HyaCiovo @RockChinQ @ZeroZ-lab @ElvisWai @whhe @9527MrLi @1wangshu @Blackoutta @JzoNgKVO @yihong0618
merge (#1)
219e9b1 
* Restore useLabelStore mistakenly removed in commit 403e2d5 (langgenius#24052)

Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>

* chore: synchronize translations (langgenius#24044)

* feat: add testcontainers based tests for metadata service (langgenius#24048)

* feat: add testcontainers based tests for model loadbalancing service (langgenius#24066)

* feat: add select input support to the conversation opener (langgenius#24043)

* feat: add CLAUDE.md for LLM-assisted development guidance (langgenius#23946)

* feat: add Redis SSL/TLS certificate authentication support (langgenius#23624)

* Fix sticky table header transparency with backdrop-filter blur in dark mode (langgenius#23999)

* fix: update first_id logic to use the oldest answer item in chat messages (langgenius#23992)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>

* refactor: improve loading animation and debug panel styles (langgenius#24075)

* fix(oauth): redis compatibility (langgenius#23959)

* feat: enchance prompt and code (langgenius#23633)

Co-authored-by: stream <stream@dify.ai>
Co-authored-by: Stream <1542763342@qq.com>
Co-authored-by: Stream <Stream_2@qq.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: return empty list instead of raising exception for qdrant search when score_threshold is 1 (langgenius#24032)

* chore: translate i18n files (langgenius#24081)

Co-authored-by: Stream29 <36751053+Stream29@users.noreply.github.com>

* fix: no current code caused code generation show error (langgenius#24086)

* fix(ui): Optimize UI component styles and layouts (langgenius#24090) (langgenius#24092)

* feat: no longer enable auto upgrade when marketplace is disabled (langgenius#24… (langgenius#24101)

* Feature/improve goto anything commands (langgenius#24091)

* chore: translate i18n files (langgenius#24102)

Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>

* fix  pg_vector extension requires SUPERUSER, but not available on Huawei Cloud RDS (langgenius#24093)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* Revert "fix  pg_vector extension requires SUPERUSER, but not availabl… (langgenius#24108)

* fix: validate checklist before publishing workflow (langgenius#24104)

* Chore: remove some dead code in experience-enhance-group (langgenius#24110)

Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>

* fix: treat default template of code as empty (langgenius#24106)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* Bump pyobvector to 0.2.15 (langgenius#24120)

* Use typing.Literal to replace str places (langgenius#24099)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* feat: add delete avatar functionality with confirmation modal (langgenius#24127)

Co-authored-by: crazywoola <427733928@qq.com>

* chore: translate i18n files (langgenius#24131)

Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>

* an example of suppress (langgenius#24136)

* feat: add testcontainers based tests for feature service (langgenius#24026)

* feat: Implements periodic deletion of workflow run logs that exceed t… (langgenius#23881)

Co-authored-by: shiyun.li973792 <shiyun.li@seres.cn>
Co-authored-by: 1wangshu <suewangswu@gmail.com>
Co-authored-by: Blackoutta <hyytez@gmail.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>

* try ast-grep (langgenius#24149)

* fix: correct behaviour of code fix (langgenius#24152)

Co-authored-by: Joel <iamjoel007@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* Fix number input in  tool configure form of agent node tool item (langgenius#24154)

* Remove the second `if self.runtime is None:` check (langgenius#24171)

Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>

* Fix: correctly match http/https URLs in image upload file (langgenius#24180)

* feat: add testcontainers based tests for model provider service (langgenius#24193)

* Fix: replace `get_builtin_provider` with `get_plugin_provider` (langgenius#24191)

* docs: format all md files (langgenius#24195)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

* hotfix: fix multiple case match syntax (langgenius#24204)

---------

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: Yongtao Huang <yongtaoh2022@gmail.com>
Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: lyzno1 <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Co-authored-by: Zhehao Peng <32246435+Zhehao-P@users.noreply.github.com>
Co-authored-by: -LAN- <laipz8200@outlook.com>
Co-authored-by: Guangdong Liu <liugddx@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Wu Tianwei <30284043+WTW0313@users.noreply.github.com>
Co-authored-by: Maries <xh001x@hotmail.com>
Co-authored-by: Joel <iamjoel007@gmail.com>
Co-authored-by: stream <stream@dify.ai>
Co-authored-by: Stream <1542763342@qq.com>
Co-authored-by: Stream <Stream_2@qq.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Bo Wu <wubo616@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Stream29 <36751053+Stream29@users.noreply.github.com>
Co-authored-by: HyaCinth <88471803+HyaCiovo@users.noreply.github.com>
Co-authored-by: Junyan Qin (Chin) <rockchinq@gmail.com>
Co-authored-by: GuanMu <ballmanjq@gmail.com>
Co-authored-by: Elvis_LEE <41870265+ElvisWai@users.noreply.github.com>
Co-authored-by: He Wang <wanghechn@qq.com>
Co-authored-by: crazywoola <427733928@qq.com>
Co-authored-by: 9527MrLi <69895702+9527MrLi@users.noreply.github.com>
Co-authored-by: shiyun.li973792 <shiyun.li@seres.cn>
Co-authored-by: 1wangshu <suewangswu@gmail.com>
Co-authored-by: Blackoutta <hyytez@gmail.com>
Co-authored-by: KVOJJJin <jzongcode@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>
qiqizjl pushed a commit to qiqizjl/dify that referenced this pull request Aug 27, 2025
@BoWuGit @qiqizjl
fix: return empty list instead of raising exception for qdrant search…
40e2cf2 
… when score_threshold is 1 (langgenius#24032)
HarryReidx pushed a commit to HarryReidx/dify that referenced this pull request Sep 1, 2025
@BoWuGit @HarryReidx
fix: return empty list instead of raising exception for qdrant search…
86057b0 
… when score_threshold is 1 (langgenius#24032)

(cherry picked from commit 790a6ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazywoola crazywoola crazywoola approved these changes

@JohnJyong JohnJyong Awaiting requested review from JohnJyong JohnJyong is a code owner

Assignees

No one assigned

Labels

👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Retrieval testing responses error on vector search when Score Threshold is 1

2 participants

@BoWuGit @crazywoola