feat: implement Schedule Trigger validation with multi-start node topology support#24134
Merged
crazywoola merged 7 commits intolanggenius:feat/triggerfrom Aug 19, 2025
Merged
Conversation
dosubot
bot
added
size:L
- Update getValidTreeNodes to handle multiple start nodes (Start + Trigger) - Ensure all start node types are treated as equivalent entry points - Fix traversal logic to avoid duplicate node processing - Support parallel workflows with different start node types
lyzno1
changed the title
…le-trigger-validation
lyzno1
added a commit
to lyzno1/dify
that referenced
this pull request
Aug 20, 2025
This was referenced Aug 21, 2025
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive validation for the Schedule Trigger node and fixes critical workflow topology validation to support multiple start nodes (Start + all Trigger types) working in parallel.
🎯 Key Features
getValidTreeNodesand checklist validation🔧 Technical Improvements
Intl.DateTimeFormatfor standard validation🧪 Quality Assurance
🌐 Multi-Language Support
Complete localization with parameter-based error messages for better user experience.
📦 Files Changed
trigger-schedule/default.ts- Comprehensive validation implementationutils/workflow.ts- Multi-start node support ingetValidTreeNodeshooks/use-checklist.ts- Trigger node equivalence handlingRelated: #24001