Fix incorrect exception reference for json.dumps()#24329
Merged
crazywoola merged 2 commits intolanggenius:mainfrom Aug 23, 2025
Merged
Fix incorrect exception reference for json.dumps()#24329crazywoola merged 2 commits intolanggenius:mainfrom
json.dumps()#24329crazywoola merged 2 commits intolanggenius:mainfrom
Conversation
hjlarry
approved these changes
Aug 22, 2025
Contributor
Author
|
Thanks for your review. |
qiaofenlin
pushed a commit
to qiaofenlin/dify
that referenced
this pull request
Aug 24, 2025
Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>
Closed
qiqizjl
pushed a commit
to qiqizjl/dify
that referenced
this pull request
Aug 27, 2025
Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>
HarryReidx
pushed a commit
to HarryReidx/dify
that referenced
this pull request
Sep 1, 2025
Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com> (cherry picked from commit 1d09708)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #24328
This PR corrects a misleading exception reference related to Python’s json module.
json.dumps()was previously described as potentially raisingjson.JSONDecodeError, which is not possible.json.dumps()
TypeErrorwhen the object is not JSON-serializable (e.g., contains set, bytes, or unsupported custom objects).json.JSONDecodeError.json.loads()
json.JSONDecodeErrorwhen the input string is not valid JSON.Important
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods