fix(vector): use semantic version comparison for version check#24409
Merged
crazywoola merged 1 commit intolanggenius:mainfrom Aug 24, 2025
Merged
fix(vector): use semantic version comparison for version check#24409crazywoola merged 1 commit intolanggenius:mainfrom
crazywoola merged 1 commit intolanggenius:mainfrom
Conversation
crazywoola
approved these changes
Aug 24, 2025
qiaofenlin
pushed a commit
to qiaofenlin/dify
that referenced
this pull request
Aug 24, 2025
Closed
qiqizjl
pushed a commit
to qiqizjl/dify
that referenced
this pull request
Aug 27, 2025
HarryReidx
pushed a commit
to HarryReidx/dify
that referenced
this pull request
Sep 1, 2025
…enius#24409) (cherry picked from commit 23dcb2d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug in Milvus vector database version comparison that could incorrectly evaluate version requirements for hybrid search functionality.
Problem
The current implementation in
MilvusVector._check_hybrid_search_support()andOceanBaseVector._check_hybrid_search_support()uses string comparison ofbase_versionattributes:String comparison fails for multi-digit version numbers. This could disable hybrid search on newer Milvus versions that actually support it.
Solution
Replace string comparison with proper semantic version comparison using Version objects:
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods