Merged
Conversation
`Unauthorized` is a subclass of `Exception`, so the old code silently swallowed it, causing 401 responses to never reach the client. Now, - Replace `except Exception: pass` with explicit handling: - `except Unauthorized: raise` → let 401 bubble up correctly - `except Exception:` → log and re-raise unexpected errors Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Contributor
|
how about #24427 :P |
crazywoola
approved these changes
Aug 25, 2025
Eric-Guo
added a commit
to Eric-Guo/dify
that referenced
this pull request
Aug 25, 2025
This reverts commit 9a18911.
Closed
qiqizjl
pushed a commit
to qiqizjl/dify
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com> Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>
HarryReidx
pushed a commit
to HarryReidx/dify
that referenced
this pull request
Sep 1, 2025
Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com> Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com> (cherry picked from commit 9a18911)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24337
Unauthorizedis a subclass ofHTTPException -> Exception, so the old code silently swallowed it, causing 401 responses to never reach the client.Now,
except Exception: passwith explicit handling:except Unauthorized: raise→ let 401 bubble up correctlyexcept Exception:→ log and re-raise unexpected errorsImportant
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods