fix: determine cpu cores determination in baseedpyright-check script on macos

[bowenliang123]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

• to fix nproc: command not found on macOS when running dev/basedpyright-check script #28057

Screenshots

Before:

% dev/basedpyright-check 
+++ realpath dev/basedpyright-check
++ dirname /Users/bw/dev/dify/dev/basedpyright-check
+ SCRIPT_DIR=/Users/bw/dev/dify/dev
+ cd /Users/bw/dev/dify/dev/..
+ PATH_TO_CHECK=
+ '[' -n '' ']'
++ nproc
dev/basedpyright-check: line 15: nproc: command not found
+ uv run --directory api --dev -- basedpyright --threads
0 errors, 0 warnings, 0 notes

After:

% dev/basedpyright-check 
+++ realpath dev/basedpyright-check
++ dirname /Users/bw/dev/dify/dev/basedpyright-check
+ SCRIPT_DIR=/Users/bw/dev/dify/dev
+ cd /Users/bw/dev/dify/dev/..
+ PATH_TO_CHECK=
+++ uname -s
++ [[ Darwin == \D\a\r\w\i\n ]]
++ sysctl -n hw.ncpu
+ CPU_CORES=16
+ uv run --directory api --dev -- basedpyright --threads 16
0 errors, 0 warnings, 0 notes

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @bowenliang123, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical compatibility issue with the dev/basedpyright-check script on macOS. By implementing platform-specific CPU core detection, it ensures that the script can successfully execute basedpyright with the correct number of threads on both macOS and other Unix-like systems, thereby improving the developer experience and preventing script failures.

Highlights

• macOS Compatibility Fix: The dev/basedpyright-check script has been updated to correctly determine the number of CPU cores on macOS by utilizing sysctl -n hw.ncpu, resolving an issue where the nproc command was not found on Apple systems.
• Improved CPU Core Detection Logic: The script now includes conditional logic to detect the operating system (uname -s) and use the appropriate command (sysctl for macOS, nproc for others) to get the CPU core count, ensuring broader compatibility.
• Script Refactoring: The basedpyright execution command has been streamlined, using a CPU_CORES variable to pass the determined core count, simplifying the script's structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR enhances the basedpyright type checking script to support macOS environments by adding cross-platform CPU core detection and simplifying the command execution logic.

• Adds OS-specific CPU core detection using sysctl for macOS and nproc for Linux
• Removes conditional branching by consolidating the basedpyright command into a single line

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where the basedpyright-check script fails on macOS due to the absence of the nproc command. The switch to sysctl on Darwin systems is appropriate. The simplification of the command execution logic is also a welcome improvement. However, I've identified a couple of issues. Firstly, the script lacks robustness in CPU core detection, which could lead to failures if the detection commands are not found. Secondly, a regression has been introduced where file paths with spaces are no longer handled correctly. I've provided specific suggestions to address both of these points.