Skip to content

fix: remove legacy z-index overrides on model config popup #33769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyzno1 merged 1 commit into from
Mar 20, 2026
Merged

fix: remove legacy z-index overrides on model config popup #33769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion web/app/components/app/configuration/config/automatic/get-automatic-res.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ const GetAutomaticRes: FC<IGetAutomaticResProps> = ({
<div>
<ModelParameterModal
popupClassName="!w-[520px]"
portalToFollowElemContentClassName="z-[1000]"
isAdvancedMode={true}
provider={model.provider}
completionParams={model.completion_params}
Expand Down
1 change: 0 additions & 1 deletion web/app/components/app/configuration/config/code-generator/get-code-generator-res.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ export const GetCodeGeneratorResModal: FC<IGetCodeGeneratorResProps> = (
<div className="mb-4">
<ModelParameterModal
popupClassName="!w-[520px]"
portalToFollowElemContentClassName="z-[1000]"
isAdvancedMode={true}
provider={model.provider}
completionParams={model.completion_params}
Expand Down
1 change: 0 additions & 1 deletion web/app/components/app/configuration/dataset-config/params-config/config-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ const ConfigContent: FC<Props> = ({
<ModelParameterModal
isInWorkflow={isInWorkflow}
popupClassName="!w-[387px]"
portalToFollowElemContentClassName="!z-[1002]"
isAdvancedMode={true}
provider={model?.provider}
completionParams={model?.completion_params}
Expand Down
3 changes: 0 additions & 3 deletions ...app/components/header/account-setting/model-provider-page/model-parameter-modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import Trigger from './trigger'

export type ModelParameterModalProps = {
popupClassName?: string
portalToFollowElemContentClassName?: string
isAdvancedMode: boolean
modelId: string
provider: string
Expand All @@ -50,7 +49,6 @@ export type ModelParameterModalProps = {

const ModelParameterModal: FC<ModelParameterModalProps> = ({
popupClassName,
portalToFollowElemContentClassName,
isAdvancedMode,
modelId,
provider,
Expand Down Expand Up @@ -161,7 +159,6 @@ const ModelParameterModal: FC<ModelParameterModalProps> = ({
<PopoverContent
placement={isInWorkflow ? 'left' : (renderTrigger ? 'bottom-end' : 'left-start')}
sideOffset={4}
className={portalToFollowElemContentClassName}
popupClassName={cn(popupClassName, 'w-[400px] rounded-2xl')}
positionerProps={!renderTrigger ? { anchor: settingsIconRef } : undefined}
>
Expand Down
1 change: 0 additions & 1 deletion ...mponents/workflow/nodes/knowledge-retrieval/components/metadata/metadata-filter/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ const MetadataFilter = ({
</div>
<div className="mt-1 px-4">
<ModelParameterModal
portalToFollowElemContentClassName="z-[50]"
popupClassName="!w-[387px]"
isInWorkflow
isAdvancedMode={true}
Expand Down
1 change: 0 additions & 1 deletion ...low/nodes/llm/components/json-schema-config-modal/json-schema-generator/prompt-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ const PromptEditor: FC<PromptEditorProps> = ({
</div>
<ModelParameterModal
popupClassName="!w-[448px]"
portalToFollowElemContentClassName="z-[1000]"
isAdvancedMode={true}
provider={model.provider}
completionParams={model.completion_params}
Expand Down
Loading