refactor(api): migrate console message responses from marshal_with to BaseModel#35204
Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom Apr 14, 2026
Conversation
Contributor
Pyrefly DiffNo changes detected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the console message endpoints to stop using inline Flask-RESTX api.model(...) / @marshal_with response definitions and instead serialize responses via Pydantic models registered with register_schema_models(), while preserving key field mappings and normalization.
Changes:
- Introduces
MessageDetailResponseandMessageInfiniteScrollPaginationResponsePydantic response models (with alias normalization + timestamp conversion). - Updates chat-message list and message-detail endpoints to return
model_dump(mode="json")output instead of relying on@marshal_with. - Adds a unit test covering alias normalization (
re_sign_file_url_answer→answer,message_metadata_dict→metadata) and datetime → unix timestamp conversion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/controllers/console/app/message.py | Replaces RESTX marshal models with registered Pydantic response models and uses Pydantic serialization in endpoints. |
| api/tests/unit_tests/controllers/console/app/test_message_api.py | Adds unit coverage for new MessageDetailResponse alias + timestamp normalization behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asukaminato0721
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #28015
Summary
Extract message response schemas from inline Flask-RESTX
api.model(...)/@marshal_withinto PydanticBaseModelclasses and register them withregister_schema_models(). Keep response compatibility by mappingre_sign_file_url_answer->answer,message_metadata_dict->metadata, and normalizing datetime/file-contained fields.Checklist
make lintandmake type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods