refactor(api): migrate console tag responses from marshal_with to BaseModel#35208
Open
ai-hpc wants to merge 2 commits intolanggenius:mainfrom
Open
refactor(api): migrate console tag responses from marshal_with to BaseModel#35208ai-hpc wants to merge 2 commits intolanggenius:mainfrom
ai-hpc wants to merge 2 commits intolanggenius:mainfrom
Conversation
Contributor
Pyrefly DiffNo changes detected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the console tag endpoints to stop using Flask-RESTX @marshal_with for the tag list response and instead serialize responses via Pydantic BaseModel (via ResponseModel), while registering the response schema for API documentation.
Changes:
- Introduces
TagResponse(ResponseModel)and registers it withconsole_nsfor schema docs. - Updates
GET /tagsto return a list ofTagResponse-serialized dicts instead of relying on@marshal_with. - Adds a unit test to verify
TagResponsenormalizes enum-backedtypevalues during JSON serialization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| api/controllers/console/tag/tags.py | Replaces @marshal_with response marshalling with Pydantic serialization; adds TagResponse schema + normalization validator. |
| api/tests/unit_tests/controllers/console/tag/test_tags.py | Adds a unit test covering TagResponse enum normalization behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
auto-merge was automatically disabled
April 14, 2026 19:32
Head branch was pushed to by a user without write access
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Apr 14, 2026
Contributor
Author
|
@asukaminato0721 please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #28015
Summary
Replace
@marshal_within console tag list response path with PydanticBaseModelserialization. AddTagResponseschema registration and normalize enum-backedtypevalues while keeping endpoint response shape unchanged.Checklist
make lintandmake type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods