bugfix: remove clear pass (https://github.com/lapce/lapce/issues/120)#7
Open
pollend wants to merge 1 commit into
Open
bugfix: remove clear pass (https://github.com/lapce/lapce/issues/120)#7pollend wants to merge 1 commit into
pollend wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR. Lapce is now using the opengl branch which has issues as well. Would you mind taking a look at the opengl branch for me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should resolve this problem: lapce/lapce#120
why is the swapchain cleared on a seperate render pass. this might be a work around for the issue since I'm not really clear on the original change. there is a multisample example in wgpu that I was looking at and this seems consistent with that.